From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corey Minyard Date: Tue, 7 Apr 2020 08:36:08 -0500 Subject: [PATCH] ipmi: kcs: Fix aspeed_kcs_probe_of_v1() In-Reply-To: <20200407122149.GA100026@mwanda> References: <20200407122149.GA100026@mwanda> Message-ID: <20200407133608.GB6130@minyard.net> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Apr 07, 2020 at 03:21:49PM +0300, Dan Carpenter wrote: > This needs to return the newly allocated struct but instead it returns > zero which leads to an immediate Oops in the caller. Thanks, this is applied. -corey > > Fixes: 09f5f680707e ("ipmi: kcs: aspeed: Implement v2 bindings") > Signed-off-by: Dan Carpenter > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c > index 9422d55a0476..a140203c079b 100644 > --- a/drivers/char/ipmi/kcs_bmc_aspeed.c > +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c > @@ -271,7 +271,7 @@ static struct kcs_bmc *aspeed_kcs_probe_of_v1(struct platform_device *pdev) > kcs->ioreg = ast_kcs_bmc_ioregs[channel - 1]; > aspeed_kcs_set_address(kcs, slave); > > - return 0; > + return kcs; > } > > static int aspeed_kcs_calculate_channel(const struct kcs_ioreg *regs) > -- > 2.25.1 >