From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manikandan Date: Fri, 29 May 2020 15:18:13 +0530 Subject: [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN In-Reply-To: <76D2694A-C80C-49F8-B51D-8A74341CA4ED@fb.com> References: <20200528141523.GA8810@cnn> <76D2694A-C80C-49F8-B51D-8A74341CA4ED@fb.com> Message-ID: <20200529094813.GA29323@cnn> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, May 28, 2020 at 05:34:22PM +0000, Vijay Khemka wrote: > > > ?On 5/28/20, 7:15 AM, "Manikandan Elumalai" wrote: > > > The adm1278 temperature sysfs attribute need it for one of the our openbmc platform . > This functionality is not enabled by default, so PMON_CONFIG needs to be modified in order to enable it. > > There is no Signed-off-by. > > --- > drivers/hwmon/pmbus/adm1275.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c > index 5caa37fb..47b293d 100644 > --- a/drivers/hwmon/pmbus/adm1275.c > +++ b/drivers/hwmon/pmbus/adm1275.c > @@ -681,6 +681,21 @@ static int adm1275_probe(struct i2c_client *client, > } > } > > + config = i2c_smbus_read_byte_data(client, ADM1275_PMON_CONFIG); > + if (config < 0) > + return config; > + > + /* Enable TEMP1 by defult */ > + config |= ADM1278_TEMP1_EN; > + ret = i2c_smbus_write_byte_data(client, > + ADM1275_PMON_CONFIG, > + config); > + if (ret < 0) { > + dev_err(&client->dev, > + "Failed to enable temperature config\n"); > + return -ENODEV; > + } > + > if (config & ADM1278_TEMP1_EN) > > This check becomes irrelevant as you are enabling it above then rather than > enabling it just remove this check. Thanks for review Vijay. I will submit changes in v2. > > info->func[0] |= > PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP; > -- > 2.7.4 > > >