From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Date: Sun, 29 Aug 2021 15:53:44 +0100 Subject: [v4 01/15] dt-bindings: iio: adc: Add ast2600-adc bindings In-Reply-To: References: <20210823070240.12600-1-billy_tsai@aspeedtech.com> <20210823070240.12600-2-billy_tsai@aspeedtech.com> Message-ID: <20210829155344.370348d1@jic23-huawei> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, 25 Aug 2021 00:06:47 +0000 Billy Tsai wrote: > Hi Rob, > > On 2021/8/24, 8:13 PM, "Rob Herring" wrote: > > On Mon, Aug 23, 2021 at 03:02:26PM +0800, Billy Tsai wrote: > > > +properties: > > > + compatible: > > > + enum: > > > + - aspeed,ast2600-adc0 > > > + - aspeed,ast2600-adc1 > > > What's the difference between 0 and 1? > > Their trimming data, which is used to calibrate internal reference volage, > locates in different address of OTP. At very least document that with a description: here to avoid anyone looking at this later asking the same question! Jonathan > > Best Regards, > Billy Tsai > > >