From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Date: Sat, 18 Sep 2021 18:55:30 +0100 Subject: [v5 04/15] iio: adc: aspeed: Keep model data to driver data. In-Reply-To: References: <20210831071458.2334-1-billy_tsai@aspeedtech.com> <20210831071458.2334-5-billy_tsai@aspeedtech.com> <20210905153339.751732cc@jic23-huawei> <20210905155029.3faa2c04@jic23-huawei> Message-ID: <20210918185530.4f667796@jic23-huawei> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, 16 Sep 2021 03:52:24 +0000 Joel Stanley wrote: > On Sun, 5 Sept 2021 at 14:47, Jonathan Cameron wrote: > > > > On Sun, 5 Sep 2021 15:33:39 +0100 > > Jonathan Cameron wrote: > > > > > On Tue, 31 Aug 2021 15:14:47 +0800 > > > Billy Tsai wrote: > > > > > > > Keep the model data pointer to driver data for reducing the usage of > > > > of_device_get_match_data(). > > > > > > > > Signed-off-by: Billy Tsai > > > This one starts to be impacted by the fix (as its in the context). > > > Rather than making a mess of things for linux-next etc I'll hold > > > off on these until that fix is upstream in a few weeks. > > > > > > If I seem to have lost it (it's been known to happen :( ) then > > > feel free to poke me! > > > > Having taken another look at the rest of the series (and Philipp's review) > > please do a v6 starting from this patch. > > I'd recommend against the practice of half applying a series. I have > just spent a good chunk of time looking at v6, and wondering why it > won't apply to any tags in Linus tree nor to next. Hi Joel, In this particular case it may been unwise, but in general it allows me to handle a higher volume of patches than would otherwise be possible. There are of course other approaches, but this one works well for me. I did express to what tree and branch these were being applied + exposed for build tests. > > (It was made worse by the branch you applied them to not being part of > linux-next.) It will be shortly. That was just unfortunate timing because of the end of the merge window and a some issues that 0-day found in other patches in the tree that needed to be fixed up before making a mess in next. Jonathan > > Cheers, > > Joel