linux-aspeed.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [bug report] pinctrl: aspeed: Improve debug output
@ 2022-02-07 12:41 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2022-02-07 12:41 UTC (permalink / raw)
  To: linux-aspeed

Hello Andrew Jeffery,

This is a semi-automatic email about new static checker warnings.

The patch aa639e443704: "pinctrl: aspeed: Improve debug output" from
Jul 1, 2020, leads to the following Smatch complaint:

    ./drivers/pinctrl/aspeed/pinctrl-aspeed.c:241 aspeed_pinmux_set_mux()
    warn: variable dereferenced before check 'pdesc' (see line 239)

./drivers/pinctrl/aspeed/pinctrl-aspeed.c
   238	
   239			pr_debug("Muxing pin %s for %s\n", pdesc->name, pfunc->name);
                                                           ^^^^^^^^^^^
Dereference

   240	
   241			if (!pdesc)
                             ^^^^^
Checked too late.

   242				return -EINVAL;
   243	

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-02-07 12:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-07 12:41 [bug report] pinctrl: aspeed: Improve debug output Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).