* [PATCH] iio: adc: aspeed: Fix refcount leak in aspeed_adc_set_trim_data
@ 2022-05-16 7:52 Miaoqian Lin
2022-05-22 11:48 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-05-16 7:52 UTC (permalink / raw)
To: linux-aspeed
of_find_node_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.
Fixes: d0a4c17b4073 ("iio: adc: aspeed: Get and set trimming data.")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/iio/adc/aspeed_adc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
index 0793d2474cdc..9341e0e0eb55 100644
--- a/drivers/iio/adc/aspeed_adc.c
+++ b/drivers/iio/adc/aspeed_adc.c
@@ -186,6 +186,7 @@ static int aspeed_adc_set_trim_data(struct iio_dev *indio_dev)
return -EOPNOTSUPP;
}
scu = syscon_node_to_regmap(syscon);
+ of_node_put(syscon);
if (IS_ERR(scu)) {
dev_warn(data->dev, "Failed to get syscon regmap\n");
return -EOPNOTSUPP;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] iio: adc: aspeed: Fix refcount leak in aspeed_adc_set_trim_data
2022-05-16 7:52 [PATCH] iio: adc: aspeed: Fix refcount leak in aspeed_adc_set_trim_data Miaoqian Lin
@ 2022-05-22 11:48 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-05-22 11:48 UTC (permalink / raw)
To: linux-aspeed
On Mon, 16 May 2022 11:52:02 +0400
Miaoqian Lin <linmq006@gmail.com> wrote:
> of_find_node_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: d0a4c17b4073 ("iio: adc: aspeed: Get and set trimming data.")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
In the 'hopefully obviously correct' category so applied to the fixes
togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/adc/aspeed_adc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
> index 0793d2474cdc..9341e0e0eb55 100644
> --- a/drivers/iio/adc/aspeed_adc.c
> +++ b/drivers/iio/adc/aspeed_adc.c
> @@ -186,6 +186,7 @@ static int aspeed_adc_set_trim_data(struct iio_dev *indio_dev)
> return -EOPNOTSUPP;
> }
> scu = syscon_node_to_regmap(syscon);
> + of_node_put(syscon);
> if (IS_ERR(scu)) {
> dev_warn(data->dev, "Failed to get syscon regmap\n");
> return -EOPNOTSUPP;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-22 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-16 7:52 [PATCH] iio: adc: aspeed: Fix refcount leak in aspeed_adc_set_trim_data Miaoqian Lin
2022-05-22 11:48 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).