* [PATCH v1] Update for Facebook yosemite V2 BMC.
@ 2022-09-06 5:07 Karthikeyan Pasupathi
2022-09-06 6:27 ` Tao Ren
0 siblings, 1 reply; 4+ messages in thread
From: Karthikeyan Pasupathi @ 2022-09-06 5:07 UTC (permalink / raw)
To: linux-aspeed
Added IPMB-13 channel for Debug Card communication.
---
--- v1 - Initial draft.
---
Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
---
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
index 8864e9c312a8..84236df522dc 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
@@ -215,6 +215,17 @@
};
};
+&i2c13 {
+ status = "okay";
+ // Debug Card
+ multi-master;
+ ipmb13 at 10 {
+ compatible = "ipmb-dev";
+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+ i2c-protocol;
+ };
+};
+
&pwm_tacho {
status = "okay";
//FSC
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v1] Update for Facebook yosemite V2 BMC.
2022-09-06 5:07 [PATCH v1] Update for Facebook yosemite V2 BMC Karthikeyan Pasupathi
@ 2022-09-06 6:27 ` Tao Ren
2022-09-06 7:31 ` karthikeyan P
0 siblings, 1 reply; 4+ messages in thread
From: Tao Ren @ 2022-09-06 6:27 UTC (permalink / raw)
To: linux-aspeed
Hi Karthikeyan,
I don't have much experience with ipmb-dev, but I'd suggest updating the
patch tile so it's consistent with other dts patches. For example:
"ARM: dts: aspeed: yosemitev2: Enable i2c13 controller"
Cheers,
- Tao
On Tue, Sep 06, 2022 at 10:37:02AM +0530, Karthikeyan Pasupathi wrote:
> Added IPMB-13 channel for Debug Card communication.
>
> ---
> --- v1 - Initial draft.
> ---
>
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> index 8864e9c312a8..84236df522dc 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> @@ -215,6 +215,17 @@
> };
> };
>
> +&i2c13 {
> + status = "okay";
> + // Debug Card
> + multi-master;
> + ipmb13 at 10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> &pwm_tacho {
> status = "okay";
> //FSC
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v1] Update for Facebook yosemite V2 BMC.
2022-09-06 6:27 ` Tao Ren
@ 2022-09-06 7:31 ` karthikeyan P
0 siblings, 0 replies; 4+ messages in thread
From: karthikeyan P @ 2022-09-06 7:31 UTC (permalink / raw)
To: linux-aspeed
Noted.
On Tue, Sep 6, 2022 at 11:57 AM Tao Ren <rentao.bupt@gmail.com> wrote:
> Hi Karthikeyan,
>
> I don't have much experience with ipmb-dev, but I'd suggest updating the
> patch tile so it's consistent with other dts patches. For example:
>
> "ARM: dts: aspeed: yosemitev2: Enable i2c13 controller"
>
>
> Cheers,
>
> - Tao
>
> On Tue, Sep 06, 2022 at 10:37:02AM +0530, Karthikeyan Pasupathi wrote:
> > Added IPMB-13 channel for Debug Card communication.
> >
> > ---
> > --- v1 - Initial draft.
> > ---
> >
> > Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> > ---
> > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > index 8864e9c312a8..84236df522dc 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> > @@ -215,6 +215,17 @@
> > };
> > };
> >
> > +&i2c13 {
> > + status = "okay";
> > + // Debug Card
> > + multi-master;
> > + ipmb13 at 10 {
> > + compatible = "ipmb-dev";
> > + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> > + i2c-protocol;
> > + };
> > +};
> > +
> > &pwm_tacho {
> > status = "okay";
> > //FSC
> > --
> > 2.17.1
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20220906/50588086/attachment.htm>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1] Update for Facebook yosemite V2 BMC.
@ 2022-09-06 11:12 Karthikeyan Pasupathi
0 siblings, 0 replies; 4+ messages in thread
From: Karthikeyan Pasupathi @ 2022-09-06 11:12 UTC (permalink / raw)
To: linux-aspeed
Removed NIC EEPROM driver IPMB-12 channel and keeping it as
"status ok".
Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
---
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
index 8864e9c312a8..2293f10e94d6 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
@@ -207,12 +207,6 @@
&i2c12 {
status = "okay";
- //MEZZ_FRU
- eeprom at 51 {
- compatible = "atmel,24c64";
- reg = <0x51>;
- pagesize = <32>;
- };
};
&pwm_tacho {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-06 11:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-06 5:07 [PATCH v1] Update for Facebook yosemite V2 BMC Karthikeyan Pasupathi
2022-09-06 6:27 ` Tao Ren
2022-09-06 7:31 ` karthikeyan P
-- strict thread matches above, loose matches on Subject: below --
2022-09-06 11:12 Karthikeyan Pasupathi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).