linux-aspeed.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 05/10] iio: imu: Replace spi->chip_select references to spi->chip_select[0]
Date: Mon, 17 Oct 2022 14:32:02 +0100	[thread overview]
Message-ID: <20221017143202.00003b1d@huawei.com> (raw)
In-Reply-To: <20221017121249.19061-6-amit.kumar-mahapatra@amd.com>

On Mon, 17 Oct 2022 17:42:44 +0530
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com> wrote:

> For adding multi CS support & to prevent any existing driver from
> breaking, replaced all spi->chip_select references to spi->chip_slect[0].
> 
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>

Hmm. No particular reason why that print should exist at all.
The warning above it covers the case where there is a mismatch
in IDs so this adds nothing useful.

So patch is fine, but I'd be equally happy with just dropping the
print.

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  drivers/iio/imu/adis16400.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c
> index 17bb0c40a149..aa7bfcee3510 100644
> --- a/drivers/iio/imu/adis16400.c
> +++ b/drivers/iio/imu/adis16400.c
> @@ -466,7 +466,7 @@ static int adis16400_initial_setup(struct iio_dev *indio_dev)
>  
>  		dev_info(&indio_dev->dev, "%s: prod_id 0x%04x at CS%d (irq %d)\n",
>  			indio_dev->name, prod_id,
> -			st->adis.spi->chip_select, st->adis.spi->irq);
> +			st->adis.spi->chip_select[0], st->adis.spi->irq);
>  	}
>  	/* use high spi speed if possible */
>  	if (st->variant->flags & ADIS16400_HAS_SLOW_MODE) {


  reply	other threads:[~2022-10-17 13:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 12:12 [PATCH 00/10] spi: Add support for stacked/parallel memories Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 01/10] spi: Add stacked memories support in SPI core Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 02/10] spi: Replace all spi->chip_select & spi->cs_gpiod references with array Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 03/10] net: Replace spi->chip_select references to spi->chip_select[0] Amit Kumar Mahapatra
2022-10-17 13:04   ` Lars-Peter Clausen
2022-10-17 12:12 ` [PATCH 04/10] mtd: devices: " Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 05/10] iio: imu: " Amit Kumar Mahapatra
2022-10-17 13:32   ` Jonathan Cameron [this message]
2022-10-17 12:12 ` [PATCH 06/10] mtd: spi-nor: Add stacked memories support in spi-nor Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 07/10] spi: spi-zynqmp-gqspi: Add stacked memories support in GQSPI driver Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 08/10] spi: Add parallel memories support in SPI core Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 09/10] mtd: spi-nor: Add parallel memories support in spi-nor Amit Kumar Mahapatra
2022-10-17 12:12 ` [PATCH 10/10] spi: spi-zynqmp-gqspi: Add parallel memories support in GQSPI driver Amit Kumar Mahapatra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017143202.00003b1d@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).