From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 000/117] media: Convert to platform remove callback returning void
Date: Mon, 17 Apr 2023 09:19:28 +0300 [thread overview]
Message-ID: <20230417061928.GD28551@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20230417060203.le3izz56wt73si6k@pengutronix.de>
Hi Uwe,
On Mon, Apr 17, 2023 at 08:02:03AM +0200, Uwe Kleine-K?nig wrote:
> Hello Mauro
>
> On Sun, Mar 26, 2023 at 04:30:25PM +0200, Uwe Kleine-K?nig wrote:
> > Hello,
> >
> > this series adapts the platform drivers below drivers/pci to use the
>
> copy&paste failure here: s/pci/media/ of course.
>
> > .remove_new() callback. Compared to the traditional .remove() callback
> > .remove_new() returns no value. This is a good thing because the driver core
> > doesn't (and cannot) cope for errors during remove. The only effect of a
> > non-zero return value in .remove() is that the driver core emits a warning. The
> > device is removed anyhow and an early return from .remove() usually yields a
> > resource leak.
> >
> > By changing the remove callback to return void driver authors cannot
> > reasonably assume any more that there is some kind of cleanup later.
> >
> > Only three drivers needed some preparation first to make sure they
> > return 0 unconditionally in their remove callback. Then all drivers
> > could be trivially converted without side effects to .remove_new().
> >
> > The changes to the individual drivers are all orthogonal. If I need to
> > resend some patches because of some review feedback, I'd like to only
> > send the patches that actually needed changes, so please pick up the
> > remaining patches that don't need changing to reduce the amount of mail.
>
> I didn't hear anything back about application of this series. Is there a
> blocker somewhere?
I think the series got applied to the master branch of
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git.
It should thus appear in v6.4.
The corresponding series for staging media drivers has also been applied
to the same branch as far as I can tell.
> Apart from the three preparatory patches that are a precondition to the
> conversion of the respective drivers, the patches are all pairwise
> orthogonal. So from my POV the best would be to apply all patches that
> still apply (which might be all), I will care for the fallout later
> then.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-04-17 6:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 14:30 [PATCH 000/117] media: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-26 14:30 ` [PATCH 017/117] media: aspeed-video: " Uwe Kleine-König
2023-04-17 6:02 ` [PATCH 000/117] media: " Uwe Kleine-König
2023-04-17 6:19 ` Laurent Pinchart [this message]
2023-04-17 7:30 ` Uwe Kleine-König
2023-04-17 7:35 ` Laurent Pinchart
2023-04-17 7:57 ` Biju Das
2023-04-17 8:54 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417061928.GD28551@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox