Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] usb: gadget: aspeed: fix buffer overflow
Date: Wed, 21 Jun 2023 17:59:55 +0200	[thread overview]
Message-ID: <2023062146-stony-lair-b6a3@gregkh> (raw)
In-Reply-To: <CAGm54UG2uD2jruRc33Xm4izepYpuFNBBcGe594as8_fx1uEWQg@mail.gmail.com>

On Wed, Jun 21, 2023 at 08:02:14PM +0800, Lei Yu wrote:
> On Wed, Dec 21, 2022 at 10:26?AM Lei Yu <yulei.sh@bytedance.com> wrote:
> >
> > On Wed, Dec 21, 2022 at 10:17 AM Neal Liu <neal_liu@aspeedtech.com> wrote:
> > > > > > > > Using rndis is able to set MTU to 2000, and the issue can be
> > > > reproduced.
> > > >
> > > > USB ecm is also tested and it is possible to set MTU to 2000, and could
> > > > reproduce the issue.
> > > > So I think this patch is needed anyway.
> > > >
> > > > @Neal Liu Could you kindly help to verify the USB ECM case?
> > >
> > > How to set MTU to 2000 on USB ECM case? I remember last time I cannot set by using "ifconfig ..."
> > > Regardless ECM or RNDIS, I agree this patch is still needed.
> >
> > You were able to set MTU to 2000 for RNDIS but not for NCM.
> > @Greg Kroah-Hartman indicated that RNDIS should not be used anymore.
> > So I tested ECM and verified it could set MTU 2000 and the issue could
> > be reproduced.
> 
> This patch fixes the kernel oops in the aspeed-vhub driver for both
> USB ECM and RNDIS.
> It now has an Acked-by from benh and Reviewed-by from neal_liu
> 
> Should we merge this patch?

Can you please resend it?

thanks,

greg k-h

  reply	other threads:[~2023-06-21 15:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  9:48 [PATCH] usb: gadget: aspeed: fix buffer overflow Lei YU
2022-10-24 21:59 ` Benjamin Herrenschmidt
2022-10-25  6:21   ` Lei Yu
2022-10-25 22:29     ` Benjamin Herrenschmidt
2022-10-28  6:59 ` Neal Liu
2022-10-28  7:41   ` Lei Yu
2022-10-28  9:04     ` Neal Liu
2022-10-28  9:17       ` Greg Kroah-Hartman
2022-10-28  9:55         ` Neal Liu
2022-10-28 10:45           ` Greg Kroah-Hartman
2022-12-20 10:51             ` Lei Yu
2022-12-21  2:17               ` Neal Liu
2022-12-21  2:26                 ` Lei Yu
2023-06-21 12:02                   ` Lei Yu
2023-06-21 15:59                     ` Greg Kroah-Hartman [this message]
2023-06-25  3:07                       ` [External] " Lei Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023062146-stony-lair-b6a3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox