public inbox for linux-aspeed@lists.ozlabs.org
 help / color / mirror / Atom feed
From: Lixue Liang <lianglixuehao@126.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] i2c: aspeed: Avoid accessing freed buffers during i2c transfers.
Date: Fri, 28 Jul 2023 12:24:16 +0000	[thread overview]
Message-ID: <20230728122416.17782-1-lianglixuehao@126.com> (raw)

From: Lixue Liang <lianglixue@greatwall.com.cn>

After waiting for the transmission timeout, the I2C controller will
continue to transmit data when the bus is idle. Clearing bus->msg will
avoid kernel panic when accessing the freed msg->buf in
aspeed_i2c_master_irq.

Signed-off-by: Lixue Liang <lianglixue@greatwall.com.cn>
---
 drivers/i2c/busses/i2c-aspeed.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 2e5acfeb76c8..c83057497e26 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -713,6 +713,8 @@ static int aspeed_i2c_master_xfer(struct i2c_adapter *adap,
 		spin_lock_irqsave(&bus->lock, flags);
 		if (bus->master_state == ASPEED_I2C_MASTER_PENDING)
 			bus->master_state = ASPEED_I2C_MASTER_INACTIVE;
+
+		bus->msgs = NULL;
 		spin_unlock_irqrestore(&bus->lock, flags);
 
 		return -ETIMEDOUT;
-- 
2.27.0


             reply	other threads:[~2023-07-28 12:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28 12:24 Lixue Liang [this message]
2023-07-31  4:21 ` [PATCH] i2c: aspeed: Avoid accessing freed buffers during i2c transfers Joel Stanley
2023-07-31  6:10   ` Lei YU
2023-08-02 13:41     ` Eddie James
2023-08-10  1:30       ` 梁礼学
2023-08-05 10:10 ` Andi Shyti
2023-08-10  1:14   ` 梁礼学

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230728122416.17782-1-lianglixuehao@126.com \
    --to=lianglixuehao@126.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox