Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings
Date: Wed, 10 Jan 2024 16:23:25 +0000	[thread overview]
Message-ID: <20240110-straggler-around-a53bc0a669fb@spud> (raw)
In-Reply-To: <385b06e9-1daa-408a-a0ed-7b09d7d539df@linux.ibm.com>

On Wed, Jan 10, 2024 at 09:54:19AM -0600, Ninad Palsule wrote:
> Hello Krzysztof,
> 
> 
> On 1/10/24 09:37, Krzysztof Kozlowski wrote:
> > On 10/01/2024 15:31, Ninad Palsule wrote:
> > > Hello Krzysztof,
> > > 
> > > 
> > > 
> > > > > > > I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ninad at linux.ibm.com/
> > > > > > Why did you do that? It now just adds undocumented compatibles to the
> > > > > > driver. Please, as Rob requested, work with Lukas on his series to make
> > > > > > sure that these devices are documented.
> > > > > I think krzysztof kozlowski suggested to send these patches separately:
> > > > > https://lore.kernel.org/linux-kernel/1c5ace65-2fd8-4503-b22f-e0f564d1c83f at linaro.org/
> > > > > 
> > > > > Did I misunderstood it? Do you guys want me to include that commit again?
> > > > My comment was in DTS thread under specific DTS patch. How did you
> > > > figure out it applies to driver and bindings? This does not make sense.
> > > Sorry for the misunderstanding. Where do you want me to add driver
> > > patch? Before all DTS patches or after all DTS patches?
> > Does not matter, why do you insist on combining them with DTS? Drivers
> > and bindings are going together. DTS better separate, although depending
> > on the case can be together.
> > 
> I have combined DTS and Driver because DTS was using compatibility string
> which is not upstream yet hence I thought it is logical to send it under
> same patchset.
> 
> Conor and Rob, Do you have preference?

I'm not sure what you want from me that Krzysztof hasn't already
provided. dt-bindings and drivers usually go together, and the dts
patches are often in the same series. If you send dts separately, note
under the --- line the patches adding the binding so that the platform
maintainer knows that the compatible has not yet been documented.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240110/113a8355/attachment.sig>

  reply	other threads:[~2024-01-10 16:23 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 16:39 [PATCH v1 0/8] Add device tree for IBM system1 BMC Ninad Palsule
2023-12-12 16:39 ` [PATCH v1 1/8] dt-bindings: arm: aspeed: add IBM system1-bmc Ninad Palsule
2023-12-12 17:10   ` Conor Dooley
2023-12-12 20:06     ` Ninad Palsule
2023-12-13 18:18   ` Jarkko Sakkinen
2023-12-13 18:36     ` Ninad Palsule
2023-12-12 16:39 ` [PATCH v1 2/8] dt-bindings: tpm: Add schema for TIS I2C devices Ninad Palsule
2023-12-12 17:14   ` Conor Dooley
2023-12-12 18:20     ` Guenter Roeck
2023-12-14 15:37       ` Ninad Palsule
2023-12-14 15:34     ` Ninad Palsule
2023-12-14 16:35       ` Conor Dooley
2023-12-14 20:13         ` Rob Herring
2023-12-13 16:13   ` Rob Herring
2023-12-14 22:23     ` Ninad Palsule
2024-01-08 19:44     ` Ninad Palsule
2023-12-13 18:20   ` Jarkko Sakkinen
2023-12-13 18:38     ` Ninad Palsule
2023-12-12 16:39 ` [PATCH v1 3/8] ARM: dts: aspeed: System1: IBM system1 BMC board Ninad Palsule
2023-12-12 20:20   ` Krzysztof Kozlowski
2023-12-14 15:06     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 4/8] ARM: dts: aspeed: System1: Add i2c and muxes Ninad Palsule
2023-12-12 20:21   ` Krzysztof Kozlowski
2023-12-14 18:34     ` Ninad Palsule
2023-12-15  7:35       ` Krzysztof Kozlowski
2023-12-12 16:40 ` [PATCH v1 5/8] ARM: dts: aspeed: System1: Voltage regulators Ninad Palsule
2023-12-12 20:22   ` Krzysztof Kozlowski
2023-12-14 16:30     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 6/8] ARM: dts: aspeed: System1: GPIO, Fan ctrl, Led Ninad Palsule
2023-12-12 20:25   ` Krzysztof Kozlowski
2024-01-08 19:56     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings Ninad Palsule
2023-12-12 17:16   ` Conor Dooley
2023-12-12 18:00     ` Guenter Roeck
2023-12-12 18:51       ` Conor Dooley
2023-12-12 19:50         ` Guenter Roeck
2024-01-08 20:05           ` Ninad Palsule
2024-01-09 17:14             ` Conor Dooley
2024-01-09 23:55               ` Ninad Palsule
2024-01-09 23:55               ` Ninad Palsule
2024-01-10  7:50                 ` Krzysztof Kozlowski
2024-01-10 14:31                   ` Ninad Palsule
2024-01-10 15:37                     ` Krzysztof Kozlowski
2024-01-10 15:54                       ` Ninad Palsule
2024-01-10 16:23                         ` Conor Dooley [this message]
2024-01-10 17:54                         ` Krzysztof Kozlowski
2024-01-10 19:06                           ` Guenter Roeck
2024-01-10 20:34                             ` Krzysztof Kozlowski
2024-01-10 20:36                               ` Krzysztof Kozlowski
2024-01-10 21:41                               ` Guenter Roeck
2024-01-08 20:04     ` Ninad Palsule
2023-12-12 16:40 ` [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more Ninad Palsule
2023-12-12 20:26   ` Krzysztof Kozlowski
2023-12-13 19:02     ` Ninad Palsule
2023-12-13 19:37       ` Krzysztof Kozlowski
2023-12-13 19:49         ` Ninad Palsule
2023-12-14  7:24           ` Krzysztof Kozlowski
2023-12-14 14:24             ` Ninad Palsule
2023-12-14 15:04     ` Ninad Palsule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110-straggler-around-a53bc0a669fb@spud \
    --to=conor@kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox