From mboxrd@z Thu Jan 1 00:00:00 1970 From: Conor Dooley Date: Thu, 15 Feb 2024 17:12:50 +0000 Subject: =?utf-8?B?5Zue6KaG?= =?utf-8?Q?=3A?= [PATCH] Add eSPI device driver (flash channel) In-Reply-To: References: <20240213-espi_driver-v1-1-92741c812843@gmail.com> <20240214-yoyo-platinum-dcd0e7e16a22@spud> Message-ID: <20240215-probable-gimmick-83d5dcbc4729@spud> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Feb 15, 2024 at 01:56:00AM +0000, ChiaWei Wang wrote: > > > > On Wed, Feb 14, 2024 at 11:34:31AM +0000, ChiaWei Wang wrote: > > > We appreciate that you are willing to help on the open source contribution. > > > However, please co-work with Aspeed before submitting drivers of Aspeed > > HW. > > > Otherwise, a misleading driver on the community are going to bring tons of > > customer issues to Aspeed. > > > > It may not apply in this particular case as Aspeed did write the original driver > > and it is polite to work with previous authors when respinning a patchset, but in > > general there is no need to work with a hardware vendor before writing drivers > > for their hardware. > > > > Blocking a driver because that company might receive more support requests > > is not the kernel's problem. > > I agree with that and Aspeed will not refuse to support. > > However, in this case, the authors, IBM, and Aspeed already have discussion (at least 4 times) before and foresee "issues" on practical eSPI SAFS use. > If there is already a known issue of the driver, why ignoring the previous discussion and push it? > A compromise is to ask for driver renaming to espi-mafs to avoid confusion. > Otherwise we need to explain, again, why the driver does not fulfill the SAFS expectation. To be clear, in case you misunderstood, I was making a general point and not about this particular patchset. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: