From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Tue, 25 Jun 2024 17:25:05 +0200 Subject: [PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc In-Reply-To: <5fa430f5-3e18-4c20-93d4-6733afd6bdcf@web.de> References: <20240625022306.2568122-1-make24@iscas.ac.cn> <2024062556-ladder-canister-1ab1@gregkh> <2024062532-strep-president-44d7@gregkh> <5fa430f5-3e18-4c20-93d4-6733afd6bdcf@web.de> Message-ID: <2024062553-koala-granddad-50f1@gregkh> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Jun 25, 2024 at 05:20:07PM +0200, Markus Elfring wrote: > >>>>> We should verify the bound of the array to assure that host > >>>>> may not manipulate the index to point past endpoint array. > >>>> > >>>> Why did you not choose an imperative wording for your change description? > >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94 > >>> > >>> Markus, please stop reviewing USB patches. This is not helpful at all, > >>> and causes new developers extra work for no reason at all. > >> > >> How does this feedback fit to the linked information source? > > > > That is not what I wrote. > > You indicated concerns according to patch review processes, > didn't you? > > See also: > * Patch submission notes > https://elixir.bootlin.com/linux/v6.10-rc5/source/Documentation/process/maintainer-tip.rst#L100 This is not the tip tree. > * Contributor Covenant Code of Conduct > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/code-of-conduct.rst?h=v6.10-rc5#n3 I do not see how this is relevant here. > > I wrote, "Please stop reviewing USB patches." > > > > Please stop now. > > I might be going to influence evolution of this software area in other ways > under other circumstances. Please take some time and find other projects to help out. greg k-h