Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 4/9] mtd: devices: add AT24 eeprom support
Date: Thu, 18 Jul 2024 09:20:01 -0000	[thread overview]
Message-ID: <20240718091753.apwsrvmekn2vvo4k@pengutronix.de> (raw)
In-Reply-To: <20240717101948.2e99f472@xps-13>

Hi Miquel,

On 24-07-17, Miquel Raynal wrote:
> Hi Marco,
> 
> > > > > Overall I think the idea of getting rid of these misc/ drivers is goes
> > > > > into the right direction, but registering directly into NVMEM makes
> > > > > more sense IMO.    
> > > > 
> > > > So you propose to have two places for the partition handling (one for
> > > > MTD and one for NVMEM) instead of one and moving the code into NVMEM
> > > > directly?  
> > > 
> > > Why two places for the partitions handling? Just one, in NVMEM. Also  
> > 
> > Without checking the details I think that converting the MTD
> > partitioning code into NVMEM partitioning code is a bigger task. As you
> > said below there are many legacy code paths you need to consider so they
> > still work afterwards as well.
> > 
> > > usually EEPROMs don't require very advanced partitioning schemes,
> > > unlike flashes (which are the most common MTD devices today).  
> > 
> > As said in my cover letter EEPROMs can become quite large and MTD
> > supports partitioning storage devices which is very handy for large
> > EEPROMs as well.
> 
> Did you had a look at nvmem-layouts ? In particular the fixed-layout.

Yes I had a look at nvmem-layouts and we use them within a
mtd-partition. Using them instead of a mtd-partition is not sufficient
since they:
 1) don't support user-space write (I send a patch for it but it doesn't
    seem to be accepted soon).
 2) If write would be supported the user-space need to write the
    complete cell e.g. no partial writes.

> Is there anything you would like to achieve already that is not
> possible with nvmem but is with mtd?

Please see above.

Regards,
  Marco

  reply	other threads:[~2024-07-18  9:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 14:15 [PATCH 0/9] AT24 EEPROM MTD Support Marco Felsch
2024-07-01 14:14 ` [PATCH 1/9] mtd: core: add nvmem_write support Marco Felsch
2024-07-01 14:14 ` [PATCH 7/9] MIPS: configs: convert to MTD_EEPROM_AT24 Marco Felsch
2024-07-01 14:15 ` [PATCH 3/9] mtd: add support to handle EEPROM devices Marco Felsch
2024-07-01 14:15 ` [PATCH 9/9] eeprom: at24: remove deprecated Kconfig symbol Marco Felsch
2024-07-02  8:57   ` Bartosz Golaszewski
2024-07-02  9:16     ` Marco Felsch
2024-07-01 14:15 ` [PATCH 8/9] LoongArch: convert to MTD_EEPROM_AT24 Marco Felsch
2024-07-01 14:15 ` [PATCH 5/9] ARM: defconfig: " Marco Felsch
2024-07-10 12:56   ` Arnd Bergmann
2024-07-10 13:00     ` Bartosz Golaszewski
2024-07-10 14:06       ` Arnd Bergmann
2024-07-01 14:15 ` [PATCH 6/9] powerpc: " Marco Felsch
2024-07-01 14:15 ` [PATCH 2/9] mtd: add mtd_is_master helper Marco Felsch
2024-07-01 16:14   ` Sergei Shtylyov
2024-07-02  8:39     ` Marco Felsch
2024-07-01 14:15 ` [PATCH 4/9] mtd: devices: add AT24 eeprom support Marco Felsch
2024-07-01 16:14   ` Tudor Ambarus
2024-07-02 13:42     ` Pratyush Yadav
2024-07-02 13:56       ` Maxime Ripard
2024-07-02 14:15         ` Pratyush Yadav
2024-07-02 14:34           ` Maxime Ripard
2024-07-08  7:05             ` Miquel Raynal
2024-07-09  9:24               ` Marco Felsch
2024-07-09  9:43                 ` Miquel Raynal
2024-07-09 10:39                   ` Marco Felsch
2024-07-17  8:20                     ` Miquel Raynal
2024-07-18  9:20                       ` Marco Felsch [this message]
2024-08-23 15:37                         ` Miquel Raynal
2024-08-23 16:24 ` [PATCH 0/9] AT24 EEPROM MTD Support Andy Shevchenko
2024-08-26  7:51   ` Marco Felsch
2024-08-26 10:32     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240718091753.apwsrvmekn2vvo4k@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox