Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Billy Tsai <billy_tsai@aspeedtech.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 5/6] gpio: aspeed: Change the macro to support deferred probe
Date: Fri, 13 Sep 2024 15:43:24 +0800	[thread overview]
Message-ID: <20240913074325.239390-6-billy_tsai@aspeedtech.com> (raw)
In-Reply-To: <20240913074325.239390-1-billy_tsai@aspeedtech.com>

Use module_platform_driver() to replace module_platform_driver_probe().
The former utilizes platform_driver_register(), which allows the driver to
defer probing when it doesn't acquire the necessary resources due to probe
order. In contrast, the latter uses __platform_driver_probe(), which
includes the comment "Note that this is incompatible with deferred
probing." Since our GPIO driver requires access to the clock resource, the
former is more suitable.

Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
 drivers/gpio/gpio-aspeed.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index 13495442e1aa..d322c03481a8 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1359,13 +1359,14 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev)
 }
 
 static struct platform_driver aspeed_gpio_driver = {
+	.probe = aspeed_gpio_probe,
 	.driver = {
 		.name = KBUILD_MODNAME,
 		.of_match_table = aspeed_gpio_of_table,
 	},
 };
 
-module_platform_driver_probe(aspeed_gpio_driver, aspeed_gpio_probe);
+module_platform_driver(aspeed_gpio_driver);
 
 MODULE_DESCRIPTION("Aspeed GPIO Driver");
 MODULE_LICENSE("GPL");
-- 
2.25.1


  parent reply	other threads:[~2024-09-13  7:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13  7:43 [PATCH v3 0/6] Add Aspeed G7 gpio support Billy Tsai
2024-09-13  7:43 ` [PATCH v3 1/6] dt-bindings: gpio: aspeed,ast2400-gpio: Support ast2700 Billy Tsai
2024-09-13 18:22   ` Conor Dooley
2024-09-13  7:43 ` [PATCH v3 2/6] gpio: aspeed: Remove the name for bank array Billy Tsai
2024-09-16  1:51   ` Andrew Jeffery
2024-09-13  7:43 ` [PATCH v3 3/6] gpio: aspeed: Create llops to handle hardware access Billy Tsai
2024-09-16  2:43   ` Andrew Jeffery
2024-09-16  3:00   ` Andrew Jeffery
2024-09-19  6:12     ` Billy Tsai
2024-09-13  7:43 ` [PATCH v3 4/6] gpio: aspeed: Support G7 Aspeed gpio controller Billy Tsai
2024-09-13  7:43 ` Billy Tsai [this message]
2024-09-14  8:44   ` [PATCH v3 5/6] gpio: aspeed: Change the macro to support deferred probe kernel test robot
2024-09-14 15:33   ` kernel test robot
2024-09-13  7:43 ` [PATCH v3 6/6] gpio: aspeed: Add the flush write to ensure the write complete Billy Tsai
2024-09-16  3:03   ` Andrew Jeffery
2024-09-19  6:07     ` Billy Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913074325.239390-6-billy_tsai@aspeedtech.com \
    --to=billy_tsai@aspeedtech.com \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox