From: Rob Herring <robh@kernel.org>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, krzk+dt@kernel.org,
conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
hkallweit1@gmail.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next 1/3] dt-bindings: net: add support for AST2700
Date: Tue, 19 Nov 2024 12:18:31 -0600 [thread overview]
Message-ID: <20241119181831.GA1962443-robh@kernel.org> (raw)
In-Reply-To: <20241118104735.3741749-2-jacky_chou@aspeedtech.com>
On Mon, Nov 18, 2024 at 06:47:33PM +0800, Jacky Chou wrote:
> The AST2700 is the 7th generation SoC from Aspeed.
> Add compatible support for AST2700 in yaml.
"Add compatible..." is obvious from the diff. Add something about why
the diff is how it is. For example, it is not compatible with AST2600
because...
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
> .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> index d6ef468495c5..6dadca099875 100644
> --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> @@ -19,7 +19,9 @@ allOf:
>
> properties:
> compatible:
> - const: aspeed,ast2600-mdio
> + enum:
> + - aspeed,ast2600-mdio
> + - aspeed,ast2700-mdio
>
> reg:
> maxItems: 1
> --
> 2.25.1
>
next prev parent reply other threads:[~2024-11-19 18:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241118104735.3741749-1-jacky_chou@aspeedtech.com>
[not found] ` <20241118104735.3741749-4-jacky_chou@aspeedtech.com>
2024-11-18 23:05 ` [net-next 3/3] net: mdio: aspeed: Add dummy read for fire control Andrew Jeffery
2024-11-19 1:52 ` Andrew Lunn
2024-11-19 1:50 ` [net-next 0/3] Add Aspeed G7 MDIO support Andrew Lunn
[not found] ` <SEYPR06MB513475D2B233EA9BDF52AD259D202@SEYPR06MB5134.apcprd06.prod.outlook.com>
2024-11-19 13:25 ` 回覆: " Andrew Lunn
2025-10-27 2:44 ` Jacky Chou
2025-10-27 12:34 ` Andrew Lunn
[not found] ` <20241118104735.3741749-2-jacky_chou@aspeedtech.com>
2024-11-19 18:18 ` Rob Herring [this message]
[not found] ` <20241118104735.3741749-3-jacky_chou@aspeedtech.com>
2024-11-19 18:20 ` [net-next 2/3] net: mdio: aspeed: Add support for AST2700 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119181831.GA1962443-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jacky_chou@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).