From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFC96C3ABB2 for ; Wed, 28 May 2025 10:42:05 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4b6mK83Cm1z2ydx; Wed, 28 May 2025 20:42:04 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2a00:1450:4864:20::333" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1748428924; cv=none; b=jJcn96Rcgm4ffCGO4wju5eQVUTbygpJywLx0+Hwd8ZfoFYF7ZxLlONDVapKuA5EbhPPXFUOGiEAVWR6N+yqasIgm7NCWgx59PDq0SIbiBcO8dy5wfNt1xW6+JHuZ0+YpoOnJyzw6zkBbikcdAuMMe4Idp/Cw1V+9MBstTgTNo9Ts9QbTy/EdA0VzfCbZpujPuzD0SEedKs/DLhK7uWps8eIKiWHHY5dsR1IISMq/B+sG4jsq7uhTQ+3JFCjIfj3GvoHcOjFDK8xoV1x4pImXL84pYwd9dIC6bKSbHznR4HN2+NSlknvUv6ZHe7OvtLKAaJAp3qEIsjyQv/3sxvx7eQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1748428924; c=relaxed/relaxed; bh=eeKeqm7bgqIFmnFmWd/B2Kjnby6+4VCIwEM6NzXgjEw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XHEDEsYKBF7qr2tg3R4BGww+pmutDHSj8Xs0Aw11y0SgWOOElkEoHmJ7FFSckc1BWsFraaky0Ke97unB5sjiZCPmCmyLZ1yP0L5INaT9Zy9GPTe4aN62x3RnLqlt0x5av9drVafr04IdW8BDl8RbLDUpXnS6MZs/bFZm4rdntPLoQQG3bYGr80SC6tQ8XwaDnyCxpK0e+uSxIz3KTNLTk9oAKxUXm4wD/iQwH+EO88GFttwH4NuXcACMUD/zc4GKm1SPBrWF6PeSFPy+ajwohGxICq/kWHXccjnhFxqf4ByZUBvaX+7l3tvrS/YAmjStUby9RYOzDit6LkyCNK0tog== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=KlKI+3zG; dkim-atps=neutral; spf=pass (client-ip=2a00:1450:4864:20::333; helo=mail-wm1-x333.google.com; envelope-from=krzysztof.kozlowski@linaro.org; receiver=lists.ozlabs.org) smtp.mailfrom=linaro.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=KlKI+3zG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::333; helo=mail-wm1-x333.google.com; envelope-from=krzysztof.kozlowski@linaro.org; receiver=lists.ozlabs.org) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4b6mK73RV3z2yds for ; Wed, 28 May 2025 20:42:03 +1000 (AEST) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-442cd12d28cso4688525e9.3 for ; Wed, 28 May 2025 03:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748428921; x=1749033721; darn=lists.ozlabs.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eeKeqm7bgqIFmnFmWd/B2Kjnby6+4VCIwEM6NzXgjEw=; b=KlKI+3zGlSwcklvRh0vYHvobgFsGfh1r98Rjx5o1eoCS66Znsh6g5r5IEdPYGCh9n3 BL24/Qe0qJe0kbVgnSIL8cnxDMmF+oVfUX85nADfalfrqiZCM9uUpYyoLEiXy2X9Iv1x YlzUZ8CZKZ4ILi0/mDieT1LUVtfDFZ+bjwdwbiUdGBq0nHDeZ5xrUVvWKejlBEQmDogI elQb8bqWPyovGhDKchi4PzSD9EznkP1UAuHcKHXgTAoIlk2zihBSlRkS+XGh/lcoDJ9O dcGxTRZDz8BiqYeeV1lDj/HNajB3tL85iPx5CaR83+VBifDkpWEiRn5jVcELLmM7IfAg X6IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748428921; x=1749033721; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eeKeqm7bgqIFmnFmWd/B2Kjnby6+4VCIwEM6NzXgjEw=; b=PDx4r6VPMvRn2XDVG/OTSBBIk5UyQyh0WG0yvDPt+dS8w0tivYpoiRnjkJin+eI+S/ y5bpFfjYI3cv117H6oARtOgZfekknodiTX4Gbh2jeYtdK1xKfK7RaGq3VKaida0PEVIH 61bJjSHYKtNw9AzW3zepbZTIwuKTWugCiOYEtpCVCqFcI9PH3JoM9xEKgcZsUFhSGGcZ Q52OqiI229cu3WQikMPK8G4uMo1Li1PKVyQt6xdaAZMfVm3J3BKI8N1JQ55Y/vbZ0RrY 94n0IsY7w0uFIWuV6jcsAyrgDGzIif5XJ/RffA13t5/+8hNClb4zypH6sEI9jxZjQp/L t5dg== X-Forwarded-Encrypted: i=1; AJvYcCWFSrE9EnmPFvXhySWjqf8y7bQjsCmd3SVCce3Py8p8Zz6juVjXvpWPS4bDwoMXQHqiVwbdAvs0lOUF/kQ=@lists.ozlabs.org X-Gm-Message-State: AOJu0YyOO7t4ZHZ8DBN8jJplL+KtAeV1Qww7W2rnaxoOj/RWvY0205qQ W8jAXdztkEHlY/Owv1FGIi/OfCa/OmpQ1J2FVXnKdXbsDpAbhOqnTK6RQc+XuzcIsMo= X-Gm-Gg: ASbGncvZOQ1ExY+JmLhbe2QR3EJRX7p0iytZ7Tc6V0rvHB/4b/fPlbtlwyy81IDsKKw wNRa/cyVuUoDm4KuC/dfDsk+Iakw9Ksj+wnbBI7UymJrzFAiuye9bIqlKAhSxXBKN0XYOvQWUkR vj5R5+o9VuXr8saH6FBo3EfR4nChnIZFSZD3PvUoQqnmOJbmIifAMvJ4uUyvzYMOCMbzGTpIwGA 9f9q3kNXGZB6O3ihbS7WFFpY4zBbsnIM1VM+VXENuo0o7o5sfbjvTNItzx1+TA4LEqw3SkO1mwl GEA/sKh4Axb+FV1RzJGnl2mwGIKdGgUbjm+F4dPQzvZOAyKmwl/pbOCtxjBDxJR4sl/S/jY= X-Google-Smtp-Source: AGHT+IH2RvO3u2jIkhe2BH1+/yJAOhQA0UR42TzWyNNAEDpg/cdMhyD7e03ICGq58jet5YwmI1xsWg== X-Received: by 2002:a05:600c:1d0d:b0:43b:cab3:1fd1 with SMTP id 5b1f17b1804b1-44c934e5f3cmr48727465e9.1.1748428920692; Wed, 28 May 2025 03:42:00 -0700 (PDT) Received: from [192.168.1.29] ([178.197.223.125]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450064add8bsm17331595e9.17.2025.05.28.03.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 03:42:00 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 28 May 2025 12:41:05 +0200 Subject: [PATCH 09/17] pinctrl: bcm: cygnus-ns2: Move fixed assignments to 'pinctrl_desc' definition X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250528-pinctrl-const-desc-v1-9-76fe97899945@linaro.org> References: <20250528-pinctrl-const-desc-v1-0-76fe97899945@linaro.org> In-Reply-To: <20250528-pinctrl-const-desc-v1-0-76fe97899945@linaro.org> To: Linus Walleij , Basavaraj Natikar , Shyam Sundar S K , Andrew Jeffery , Joel Stanley , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , =?utf-8?q?Jonathan_Neusch=C3=A4fer?= , =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= , Broadcom internal kernel review list , Ray Jui , Scott Branden , Geert Uytterhoeven , David Rhodes , Richard Fitzgerald , Charles Keepax , Lorenzo Bianconi , Sean Wang , Jesper Nilsson , Lars Persson , Manivannan Sadhasivam , Damien Le Moal , Vladimir Zapolskiy , Michal Simek , Emil Renner Berthing , Jianlong Huang , Hal Feng , Matthias Brugger , AngeloGioacchino Del Regno , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@axis.com, linux-riscv@lists.infradead.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2013; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=tMPOIoxmSYTBilMSijclMXxtNrW8WzkiypV3oMPeYrw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoNuhQiRFuBZNM/PyHQB2QGJi215mgTKjmtl1J4 6O38EUsvPyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaDboUAAKCRDBN2bmhouD 192rD/98fy4M3wAq2lLrZI16iHbCWibHnzws9NPmcH5NdY6VM7xhLEq++95JNIwB0UKiqe2sWUi nR0jKaZVhxwjwEoHgfW3yXkchrYLT4HtbxPM2wXzHTIMNG7qDtvCJDN6RHCbsGZBoarDEQuCk2H ZSpG5J0mCHYGWzNcuUMYQPg8wInmjwrNaISZ2c3lFPKzal+YJqOE+78XA0oIU0qNoJX6sWXyufV u01win3xK0AMvzXktWiaB//8qOR8se9X8Q/kU83OohrexwKTewmqQGrKCqWvub2qfbqVJs9Lcf1 g9HWX7C88+/pIBcjjWdDmWRa1DCLypL6Nb8lKQXaFrgAs9z63JSXsuobSuuFvtErz4Q4CQSePjF 39ee9zzBsbsjRGSNjGTWVJ1RUoBRJI5WZbDvm8wmDGn6N09uesj2pWwa5OnDuM4Q7JzMKY3byGT d9cfJoT3IffCKay5oTbaTEipX1AxJL5Ka5JKkQdtV9Fd5SGfyFzzGW0zgMhoOLK8L9eaGOZmObm HlL037nJMCk37k2UYML60oXBFFsO5loJChx/GjpfwBoPXLjRPk8PdQnTbwF4gLyNP1zxMSZ/6Yy D7h9V/1hVNWGd0B1G9TGQH5qJt5+Nq9SQUlmoG/jyVioHYfTnjhR4QTiy2kMaZpNlU2URVKqZf5 A3gbDHJkIDwlHMw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Assign 'struct pinctrl_desc' .npins member in definition to make clear that number of pins is fixed and have less code in the probe. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c index 04f4fca854cc05c6ccc75fbcb640b18fcfd37453..23ab3ab064b6f2b0aaa15afd6b9c582f1a1256b2 100644 --- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c @@ -971,6 +971,7 @@ static struct pinctrl_desc ns2_pinctrl_desc = { .pctlops = &ns2_pinctrl_ops, .pmxops = &ns2_pinmux_ops, .confops = &ns2_pinconf_ops, + .npins = ARRAY_SIZE(ns2_pins), }; static int ns2_mux_log_init(struct ns2_pinctrl *pinctrl) @@ -1026,7 +1027,6 @@ static int ns2_pinmux_probe(struct platform_device *pdev) struct resource *res; int i, ret; struct pinctrl_pin_desc *pins; - unsigned int num_pins = ARRAY_SIZE(ns2_pins); pinctrl = devm_kzalloc(&pdev->dev, sizeof(*pinctrl), GFP_KERNEL); if (!pinctrl) @@ -1060,11 +1060,12 @@ static int ns2_pinmux_probe(struct platform_device *pdev) return ret; } - pins = devm_kcalloc(&pdev->dev, num_pins, sizeof(*pins), GFP_KERNEL); + pins = devm_kcalloc(&pdev->dev, ARRAY_SIZE(ns2_pins), sizeof(*pins), + GFP_KERNEL); if (!pins) return -ENOMEM; - for (i = 0; i < num_pins; i++) { + for (i = 0; i < ARRAY_SIZE(ns2_pins); i++) { pins[i].number = ns2_pins[i].pin; pins[i].name = ns2_pins[i].name; pins[i].drv_data = &ns2_pins[i]; @@ -1075,7 +1076,6 @@ static int ns2_pinmux_probe(struct platform_device *pdev) pinctrl->functions = ns2_pin_functions; pinctrl->num_functions = ARRAY_SIZE(ns2_pin_functions); ns2_pinctrl_desc.pins = pins; - ns2_pinctrl_desc.npins = num_pins; pinctrl->pctl = pinctrl_register(&ns2_pinctrl_desc, &pdev->dev, pinctrl); -- 2.45.2