From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: linux-aspeed@lists.ozlabs.org
Cc: Joel Stanley <joel@jms.id.au>,
Henry Martin <bsdhenrymartin@gmail.com>,
Jean Delvare <jdelvare@suse.de>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Andrew Geissler <geissonator@yahoo.com>,
Ninad Palsule <ninad@linux.ibm.com>,
Patrick Venture <venture@google.com>,
Robert Lippert <roblip@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Andrew Jeffery <andrew@codeconstruct.com.au>,
stable@vger.kernel.org
Subject: [PATCH v2 00/10] soc: aspeed: lpc-snoop: Miscellaneous fixes
Date: Mon, 16 Jun 2025 22:43:37 +0930 [thread overview]
Message-ID: <20250616-aspeed-lpc-snoop-fixes-v2-0-3cdd59c934d3@codeconstruct.com.au> (raw)
Henry's bug[1] and fix[2] prompted some further inspection by
Jean.
This series provides fixes for the remaining issues Jean identified, as
well as reworking the channel paths to reduce cleanup required in error
paths. It is based on v6.16-rc1.
Lightly tested under qemu and on an AST2600 EVB. Further testing on
platforms designed around the snoop device appreciated.
[1]: https://bugzilla.kernel.org/show_bug.cgi?id=219934
[2]: https://lore.kernel.org/all/20250401074647.21300-1-bsdhenrymartin@gmail.com/
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
---
Changes in v2:
- Address comments on v1 from Jean
- Implement channel indexing using enums to avoid unnecessary tests
- Switch to devm_clk_get_enabled()
- Use dev_err_probe() where possible
- Link to v1: https://patch.msgid.link/20250411-aspeed-lpc-snoop-fixes-v1-0-64f522e3ad6f@codeconstruct.com.au
---
Andrew Jeffery (10):
soc: aspeed: lpc-snoop: Cleanup resources in stack-order
soc: aspeed: lpc-snoop: Don't disable channels that aren't enabled
soc: aspeed: lpc-snoop: Ensure model_data is valid
soc: aspeed: lpc-snoop: Constrain parameters in channel paths
soc: aspeed: lpc-snoop: Rename 'channel' to 'index' in channel paths
soc: aspeed: lpc-snoop: Rearrange channel paths
soc: aspeed: lpc-snoop: Switch to devm_clk_get_enabled()
soc: aspeed: lpc-snoop: Use dev_err_probe() where possible
soc: aspeed: lpc-snoop: Consolidate channel initialisation
soc: aspeed: lpc-snoop: Lift channel config to const structs
drivers/soc/aspeed/aspeed-lpc-snoop.c | 224 +++++++++++++++++-----------------
1 file changed, 110 insertions(+), 114 deletions(-)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250401-aspeed-lpc-snoop-fixes-e5d2883da3a3
Best regards,
--
Andrew Jeffery <andrew@codeconstruct.com.au>
next reply other threads:[~2025-06-16 13:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 13:13 Andrew Jeffery [this message]
2025-06-16 13:13 ` [PATCH v2 01/10] soc: aspeed: lpc-snoop: Cleanup resources in stack-order Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 02/10] soc: aspeed: lpc-snoop: Don't disable channels that aren't enabled Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 03/10] soc: aspeed: lpc-snoop: Ensure model_data is valid Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 04/10] soc: aspeed: lpc-snoop: Constrain parameters in channel paths Andrew Jeffery
2025-07-04 16:44 ` Jean Delvare
2025-07-08 2:06 ` Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 05/10] soc: aspeed: lpc-snoop: Rename 'channel' to 'index' " Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 06/10] soc: aspeed: lpc-snoop: Rearrange " Andrew Jeffery
2025-07-04 15:34 ` Jean Delvare
2025-07-08 2:06 ` Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 07/10] soc: aspeed: lpc-snoop: Switch to devm_clk_get_enabled() Andrew Jeffery
2025-07-04 14:42 ` Jean Delvare
2025-06-16 13:13 ` [PATCH v2 08/10] soc: aspeed: lpc-snoop: Use dev_err_probe() where possible Andrew Jeffery
2025-07-04 14:46 ` Jean Delvare
2025-06-16 13:13 ` [PATCH v2 09/10] soc: aspeed: lpc-snoop: Consolidate channel initialisation Andrew Jeffery
2025-07-04 15:13 ` Jean Delvare
2025-07-08 2:06 ` Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 10/10] soc: aspeed: lpc-snoop: Lift channel config to const structs Andrew Jeffery
2025-07-04 16:23 ` Jean Delvare
2025-07-08 2:07 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616-aspeed-lpc-snoop-fixes-v2-0-3cdd59c934d3@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=bsdhenrymartin@gmail.com \
--cc=geissonator@yahoo.com \
--cc=jdelvare@suse.de \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ninad@linux.ibm.com \
--cc=patrick.rudolph@9elements.com \
--cc=roblip@gmail.com \
--cc=stable@vger.kernel.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).