linux-aspeed.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: linux-aspeed@lists.ozlabs.org
Cc: devicetree@vger.kernel.org, andrew@codeconstruct.com.au,
	conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
	eajames@linux.ibm.com
Subject: [PATCH v5 6/6] ARM: dts: aspeed: Fix max31785 fan node naming
Date: Wed, 17 Sep 2025 09:42:10 -0500	[thread overview]
Message-ID: <20250917144210.160051-7-eajames@linux.ibm.com> (raw)
In-Reply-To: <20250917144210.160051-1-eajames@linux.ibm.com>

Now that the max31785 is properly documented, fix up the uses of
it in the Aspeed dts.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
 .../arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts |  6 ++----
 .../arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts | 10 ++++------
 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts   |  2 --
 .../arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts | 14 ++++++--------
 arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts | 10 ++++------
 .../boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts |  2 --
 6 files changed, 16 insertions(+), 28 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts
index 2f5d4075a64ad..36e6bbfdeb30a 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dts
@@ -273,16 +273,14 @@ eeprom@51 {
 	max31785@52 {
 		compatible = "maxim,max31785a";
 		reg = <0x52>;
-		#address-cells = <1>;
-		#size-cells = <0>;
 
-		fan0: fan@0 {
+		fan0: fan-0 {
 			compatible = "pmbus-fan";
 			reg = <0>;
 			tach-pulses = <2>;
 		};
 
-		fan1: fan@1 {
+		fan1: fan-1 {
 			compatible = "pmbus-fan";
 			reg = <1>;
 			tach-pulses = <2>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
index 9f144f527f03b..db20a3b740836 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
@@ -2061,29 +2061,27 @@ i2c14mux0chn3: i2c@3 {
 
 			max31785@52 {
 				compatible = "maxim,max31785a";
-				#address-cells = <1>;
-				#size-cells = <0>;
 				reg = <0x52>;
 
-				fan@0 {
+				fan-0 {
 					compatible = "pmbus-fan";
 					reg = <0>;
 					tach-pulses = <2>;
 				};
 
-				fan@1 {
+				fan-1 {
 					compatible = "pmbus-fan";
 					reg = <1>;
 					tach-pulses = <2>;
 				};
 
-				fan@2 {
+				fan-2 {
 					compatible = "pmbus-fan";
 					reg = <2>;
 					tach-pulses = <2>;
 				};
 
-				fan@3 {
+				fan-3 {
 					compatible = "pmbus-fan";
 					reg = <3>;
 					tach-pulses = <2>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts
index 9a43fc7bcebe9..e312bfc2c5bda 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts
@@ -2053,8 +2053,6 @@ i2c14mux0chn3: i2c@3 {
 			pwm@52 {
 				compatible = "maxim,max31785a";
 				reg = <0x52>;
-				#address-cells = <1>;
-				#size-cells = <0>;
 			};
 
 			led-controller@60 {
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
index c5fb5d410001b..8a5f4131787f1 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts
@@ -1076,40 +1076,38 @@ tmp275@48 {
 	max: max31785@52 {
 		compatible = "maxim,max31785a";
 		reg = <0x52>;
-		#address-cells = <1>;
-		#size-cells = <0>;
 
-		fan0: fan@0 {
+		fan0: fan-0 {
 			compatible = "pmbus-fan";
 			reg = <0>;
 			tach-pulses = <2>;
 		};
 
-		fan1: fan@1 {
+		fan1: fan-1 {
 			compatible = "pmbus-fan";
 			reg = <1>;
 			tach-pulses = <2>;
 		};
 
-		fan2: fan@2 {
+		fan2: fan-2 {
 			compatible = "pmbus-fan";
 			reg = <2>;
 			tach-pulses = <2>;
 		};
 
-		fan3: fan@3 {
+		fan3: fan-3 {
 			compatible = "pmbus-fan";
 			reg = <3>;
 			tach-pulses = <2>;
 		};
 
-		fan4: fan@4 {
+		fan4: fan-4 {
 			compatible = "pmbus-fan";
 			reg = <4>;
 			tach-pulses = <2>;
 		};
 
-		fan5: fan@5 {
+		fan5: fan-5 {
 			compatible = "pmbus-fan";
 			reg = <5>;
 			tach-pulses = <2>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts
index b31eb8e58c6b4..bc83605bdf497 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-tacoma.dts
@@ -477,10 +477,8 @@ bmp: bmp280@77 {
 	max31785@52 {
 		compatible = "maxim,max31785a";
 		reg = <0x52>;
-		#address-cells = <1>;
-		#size-cells = <0>;
 
-		fan@0 {
+		fan-0 {
 			compatible = "pmbus-fan";
 			reg = <0>;
 			tach-pulses = <2>;
@@ -493,7 +491,7 @@ fan@0 {
 			maxim,fan-fault-pin-mon;
 		};
 
-		fan@1 {
+		fan-1 {
 			compatible = "pmbus-fan";
 			reg = <1>;
 			tach-pulses = <2>;
@@ -506,7 +504,7 @@ fan@1 {
 			maxim,fan-fault-pin-mon;
 		};
 
-		fan@2 {
+		fan-2 {
 			compatible = "pmbus-fan";
 			reg = <2>;
 			tach-pulses = <2>;
@@ -519,7 +517,7 @@ fan@2 {
 			maxim,fan-fault-pin-mon;
 		};
 
-		fan@3 {
+		fan-3 {
 			compatible = "pmbus-fan";
 			reg = <3>;
 			tach-pulses = <2>;
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
index 89907b628b655..f26df3c8cc261 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-witherspoon.dts
@@ -360,8 +360,6 @@ bmp: bmp280@77 {
 	max31785@52 {
 		compatible = "maxim,max31785a";
 		reg = <0x52>;
-		#address-cells = <1>;
-		#size-cells = <0>;
 	};
 
 	dps: dps310@76 {
-- 
2.51.0



  parent reply	other threads:[~2025-09-17 14:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17 14:42 [PATCH v5 0/6] ARM: dts: aspeed: Add Balcones system Eddie James
2025-09-17 14:42 ` [PATCH v5 1/6] dt-bindings: arm: aspeed: add IBM Balcones board Eddie James
2025-09-17 14:42 ` [PATCH v5 2/6] dt-bindings: arm: aspeed: add IBM Bonnell board Eddie James
2025-09-17 15:46   ` Rob Herring
2025-09-17 14:42 ` [PATCH v5 3/6] dt-bindings: iio: Add Infineon DPS310 sensor documentation Eddie James
2025-09-17 14:42 ` [PATCH v5 4/6] dt-bindings: hwmon: Move max31785 compatibles to max31790 document Eddie James
2025-09-17 14:42 ` [PATCH v5 5/6] ARM: dts: aspeed: Add Balcones system Eddie James
2025-09-17 14:42 ` Eddie James [this message]
2025-09-18  0:39 ` [PATCH v5 0/6] " Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250917144210.160051-7-eajames@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).