* [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC
@ 2025-09-17 18:04 Rebecca Cran
2025-09-17 18:04 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board Rebecca Cran
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Rebecca Cran @ 2025-09-17 18:04 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed,
linux-kernel
Cc: Rebecca Cran
The ASRock Rack ALTRAD8 BMC is an Aspeed AST2500-based BMC for the
ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q boards with an Ampere Altra
processor. The BMC runs OpenBMC.
These patches add a device tree and binding for the BMC.
**Changes between v1 and v2**
- Reordered nodes to be in alphabetical order.
- Removed status lines.
- Fixed naming.
There are still several warnings from
make CHECK_DTBS=y ARCH=arm W=1 aspeed/aspeed-bmc-asrock-altrad8.dtb
I believe the only one which is reporting an issue in my dts file (as opposed
to included files) is the first, and that's because the code partition contains
the TF-A and UEFI areas. I couldn't see a way to suppress it.
aspeed-bmc-asrock-altrad8.dts:578.16-581.6: Warning (unique_unit_address_if_enabled): /ahb/spi@1e630000/flash@0/partitions/code@400000: duplicate unit-address (also used in node /ahb/spi@1e630000/flash@0/partitions/tfa@400000)
aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/memory-controller@1e6e0000: failed to match any schema with compatible: ['aspeed,ast2500-sdram-edac']
aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/syscon@1e6e2000/p2a-control@2c: failed to match any schema with compatible: ['aspeed,ast2500-p2a-ctrl']
aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/display@1e6e6000: failed to match any schema with compatible: ['aspeed,ast2500-gfx', 'syscon']
aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/timer@1e782000: failed to match any schema with compatible: ['aspeed,ast2400-timer']
aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/pwm-tacho-controller@1e786000: failed to match any schema with compatible: ['aspeed,ast2500-pwm-tacho']
aspeed-bmc-asrock-altrad8.dtb: fan@0: aspeed,fan-tach-ch: b'\x00\x08' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
aspeed-bmc-asrock-altrad8.dtb: fan@1: aspeed,fan-tach-ch: b'\x01\t' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
aspeed-bmc-asrock-altrad8.dtb: fan@2: aspeed,fan-tach-ch: b'\x02\n' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
aspeed-bmc-asrock-altrad8.dtb: fan@3: aspeed,fan-tach-ch: b'\x03\x0b' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
aspeed-bmc-asrock-altrad8.dtb: fan@4: aspeed,fan-tach-ch: b'\x04\x0c' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
aspeed-bmc-asrock-altrad8.dtb: fan@5: aspeed,fan-tach-ch: b'\x05\r' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
aspeed-bmc-asrock-altrad8.dtb: fan@6: aspeed,fan-tach-ch: b'\x06\x0e' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
aspeed-bmc-asrock-altrad8.dtb: fan@7: aspeed,fan-tach-ch: b'\x07\x0f' is not of type 'object', 'integer', 'array', 'boolean', 'null'
from schema $id: http://devicetree.org/schemas/dt-core.yaml#
aspeed-bmc-asrock-altrad8.dtb: lpc@1e789000 (aspeed,ast2500-lpc-v2): reg-io-width: 4 is not of type 'object'
from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml#
aspeed-bmc-asrock-altrad8.dtb: lpc@1e789000 (aspeed,ast2500-lpc-v2): lpc-snoop@90: 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml#
aspeed-bmc-asrock-altrad8.dtb: kcs@24 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
aspeed-bmc-asrock-altrad8.dtb: kcs@28 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
aspeed-bmc-asrock-altrad8.dtb: kcs@2c (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
aspeed-bmc-asrock-altrad8.dtb: kcs@114 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/lpc@1e789000/lhc@a0: failed to match any schema with compatible: ['aspeed,ast2500-lhc']
aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/lpc@1e789000/ibt@140: failed to match any schema with compatible: ['aspeed,ast2500-ibt-bmc']
aspeed-bmc-asrock-altrad8.dtb: gpio@1c (nxp,pca9557): '#address-cells', '#size-cells', 'gpio@0', 'gpio@1', 'gpio@2', 'gpio@3', 'gpio@4', 'gpio@5', 'gpio@6', 'gpio@7' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
Rebecca Cran (2):
dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board
ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
arch/arm/boot/dts/aspeed/Makefile | 1 +
arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts | 633 ++++++++++++++++++++
3 files changed, 635 insertions(+)
create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts
base-commit: 5aca7966d2a7255ba92fd5e63268dd767b223aa5
--
2.47.3
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH v2 1/2] dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board 2025-09-17 18:04 [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran @ 2025-09-17 18:04 ` Rebecca Cran 2025-09-17 19:17 ` Conor Dooley 2025-09-17 18:04 ` [PATCH v2 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran ` (2 subsequent siblings) 3 siblings, 1 reply; 12+ messages in thread From: Rebecca Cran @ 2025-09-17 18:04 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Cc: Rebecca Cran Document ASRock Rack ALTRAD8 (ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q) compatibles. Signed-off-by: Rebecca Cran <rebecca@bsdio.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index 456dbf7b5ec8..7d5c6bfaeb97 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -34,6 +34,7 @@ properties: - amd,ethanolx-bmc - ampere,mtjade-bmc - aspeed,ast2500-evb + - asrock,altrad8-bmc - asrock,e3c246d4i-bmc - asrock,e3c256d4i-bmc - asrock,romed8hm3-bmc -- 2.47.3 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board 2025-09-17 18:04 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board Rebecca Cran @ 2025-09-17 19:17 ` Conor Dooley 0 siblings, 0 replies; 12+ messages in thread From: Conor Dooley @ 2025-09-17 19:17 UTC (permalink / raw) To: Rebecca Cran Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel [-- Attachment #1: Type: text/plain, Size: 52 bytes --] Acked-by: Conor Dooley <conor.dooley@microchip.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC 2025-09-17 18:04 [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran 2025-09-17 18:04 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board Rebecca Cran @ 2025-09-17 18:04 ` Rebecca Cran 2025-09-17 21:04 ` Andrew Lunn 2025-09-22 6:29 ` Zev Weiss 2025-09-18 1:14 ` [PATCH v2 0/2] Add " Rob Herring (Arm) 2025-09-22 2:40 ` Andrew Jeffery 3 siblings, 2 replies; 12+ messages in thread From: Rebecca Cran @ 2025-09-17 18:04 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Cc: Rebecca Cran The ALTRAD8 BMC is an Aspeed AST2500-based BMC for the ASRock Rack ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q boards. Signed-off-by: Rebecca Cran <rebecca@bsdio.com> --- arch/arm/boot/dts/aspeed/Makefile | 1 + arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts | 633 ++++++++++++++++++++ 2 files changed, 634 insertions(+) diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile index aba7451ab749..6bffb7130839 100644 --- a/arch/arm/boot/dts/aspeed/Makefile +++ b/arch/arm/boot/dts/aspeed/Makefile @@ -9,6 +9,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-ampere-mtjefferson.dtb \ aspeed-bmc-ampere-mtmitchell.dtb \ aspeed-bmc-arm-stardragon4800-rep2.dtb \ + aspeed-bmc-asrock-altrad8.dtb \ aspeed-bmc-asrock-e3c246d4i.dtb \ aspeed-bmc-asrock-e3c256d4i.dtb \ aspeed-bmc-asrock-romed8hm3.dtb \ diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts new file mode 100644 index 000000000000..ae3ddf5f6eb7 --- /dev/null +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts @@ -0,0 +1,633 @@ +// SPDX-License-Identifier: GPL-2.0+ +/dts-v1/; + +#include "aspeed-g5.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/i2c/i2c.h> + +/ { + model = "ASRock ALTRAD8 BMC"; + compatible = "asrock,altrad8-bmc", "aspeed,ast2500"; + + aliases { + serial4 = &uart5; + i2c50 = &nvme1; + i2c51 = &pcie4; + i2c52 = &pcie5; + i2c53 = &pcie6; + i2c54 = &pcie7; + i2c55 = &nvme3; + i2c56 = &nvme2; + i2c57 = &nvme0; + i2c58 = &nvme4; + i2c59 = &nvme5; + i2c60 = &nvme6; + i2c61 = &nvme7; + i2c62 = &nvme8; + i2c63 = &nvme9; + i2c64 = &nvme10; + i2c65 = &nvme11; + }; + + chosen { + stdout-path = "uart5:115200n8"; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, + <&adc 4> ,<&adc 5>, <&adc 6>, <&adc 7>, + <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>, + <&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>; + }; + + leds { + compatible = "gpio-leds"; + + led-system-fault { + gpios = <&gpio ASPEED_GPIO(G,3) GPIO_ACTIVE_LOW>; + label = "platform:red:fault"; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_FAULT; + }; + + led-enclosure-identify { + gpios = <&gpio ASPEED_GPIO(G,0) GPIO_ACTIVE_LOW>; + label = "platform:green:indicator"; + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_INDICATOR; + }; + + led-fan1-fault { + retain-state-shutdown; + default-state = "off"; + gpios = <&pca0 0 GPIO_ACTIVE_LOW>; + label = "fan1:red:fault"; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_FAULT; + }; + + led-fan2-fault { + retain-state-shutdown; + default-state = "off"; + gpios = <&pca0 1 GPIO_ACTIVE_LOW>; + label = "fan2:red:fault"; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_FAULT; + }; + + led-fan3-fault { + retain-state-shutdown; + default-state = "off"; + gpios = <&pca0 2 GPIO_ACTIVE_LOW>; + label = "fan3:red:fault"; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_FAULT; + }; + + led-fan4-fault { + retain-state-shutdown; + default-state = "off"; + gpios = <&pca0 3 GPIO_ACTIVE_LOW>; + label = "fan4:red:fault"; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_FAULT; + }; + + led-fan5-fault { + retain-state-shutdown; + default-state = "off"; + gpios = <&pca0 4 GPIO_ACTIVE_LOW>; + label = "fan5:red:fault"; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_FAULT; + }; + }; + + memory@80000000 { + reg = <0x80000000 0x20000000>; + }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + gfx_memory: framebuffer { + compatible = "shared-dma-pool"; + size = <0x01000000>; + alignment = <0x01000000>; + reusable; + }; + + vga_memory: framebuffer@9f000000 { + no-map; + reg = <0x9f000000 0x01000000>; /* 16M */ + }; + + video_engine_memory: jpegbuffer { + compatible = "shared-dma-pool"; + size = <0x02000000>; /* 32M */ + alignment = <0x01000000>; + reusable; + }; + }; +}; + +&adc { + status = "okay"; +}; + +&fmc { + flash@0 { + label = "bmc"; + m25p,fast-read; + spi-max-frequency = <50000000>; +#include "openbmc-flash-layout-64.dtsi" + }; +}; + +&gfx { + memory-region = <&gfx_memory>; +}; + +&gpio { + gpio-line-names = + /*A0-A7*/ "","","","BMC_READY","","","","", + /*B0-B7*/ "i2c-backup-sel","","","","","","","host0-shd-ack-n", + /*C0-C7*/ "","","","","","","","", + /*D0-D7*/ "POWER_BUTTON","POWER_OUT","RESET_BUTTON", + "host0-sysreset-n","","","SYS_PWR_GD","", + /*E0-E7*/ "","s0-vrd1-vddq0123-fault-l", + "s0-vrd1-vddq4567-fault-l","s0-vrd0-vddc-fault-l", + "s0-vrd3-p0v75-fault-l","","","", + /*F0-F7*/ "","","SYS_ATX_PSON_L","","","","","", + /*G0-G7*/ "id-led","id-button","","","UBOOT_READY",\ + "BMC_SALT2_L","","", + /*H0-H7*/ "PS_PWROK","uart1-mode1","uart2-mode1","uart3-mode1", + "uart4-mode1","","BMC_HB_LED","", + /*I0-I7*/ "","","","","","","","", + /*J0-J7*/ "s0-hightemp-n","","","","","","","", + /*K0-K7*/ "","","","","","","","", + /*L0-L7*/ "","","","","","","","", + /*M0-M7*/ "","","","","","s0-spi-auth-fail-n","","", + /*N0-N7*/ "","","","","","","","", + /*O0-O7*/ "","","","","","","","", + /*P0-P7*/ "","","CPLD_DISABLE_BMC","","","","","", + /*Q0-Q7*/ "","","ext-hightemp-n","","","","", + "CHASSIS_INTRUSION", + /*R0-R7*/ "","","EXT_HIGHTEMP_L","spi0-program-sel","", + "HWM_BAT_EN","","", + /*S0-S7*/ "s0-vr-hot-n","","","BMC_SYSRESET_L","","","","", + /*T0-T7*/ "","","","","","","","", + /*U0-U7*/ "","","","","","","","", + /*V0-V7*/ "","","","","","","","", + /*W0-W7*/ "","","","","","","","", + /*X0-X7*/ "","","","","","","","", + /*Y0-Y7*/ "SIOS3","SIOS5","SIOPWREQ","SIOONCTRL","","","","", + /*Z0-Z7*/ "","SIOPWRGD","","s0-rtc-lock","","","","", + /*AA0-AA7*/ "RTC_INT","","","","","PMBUS_SEL_N","","", + /*AB0-AB7*/ "host0-reboot-ack-n","s0-sys-auth-failure-n", + "","","","","","", + /*AC0-AC7*/ "s0-fault-alert","host0-ready","s0-overtemp-n", + "","bmc-ok","host0-special-boot","presence-cpu0", + "host0-shd-req-n"; +}; + +&i2c0 { + bus-frequency = <100000>; + + ipmb@10 { + compatible = "ipmb-dev"; + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; + i2c-protocol; + }; + +}; + +&i2c1 { + bus-frequency = <100000>; + + i2c-mux1@73 { + compatible = "nxp,pca9548"; + reg = <0x73>; + #address-cells = <1>; + #size-cells = <0>; + i2c-mux-idle-disconnect; + + nvme1: i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + }; + + pcie4: i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + }; + + pcie5: i2c@2 { + #address-cells = <1>; + #size-cells = <0>; + reg = <2>; + }; + + pcie6: i2c@3 { + #address-cells = <1>; + #size-cells = <0>; + reg = <3>; + }; + + pcie7: i2c@4 { + #address-cells = <1>; + #size-cells = <0>; + reg = <4>; + }; + + nvme3: i2c@5 { + #address-cells = <1>; + #size-cells = <0>; + reg = <5>; + }; + + nvme2: i2c@6 { + #address-cells = <1>; + #size-cells = <0>; + reg = <6>; + }; + + nvme0: i2c@7 { + #address-cells = <1>; + #size-cells = <0>; + reg = <7>; + }; + }; + + i2c-mux2@75 { + compatible = "nxp,pca9548"; + reg = <0x75>; + #address-cells = <1>; + #size-cells = <0>; + i2c-mux-idle-disconnect; + + nvme4: i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + }; + + nvme5: i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + }; + + nvme6: i2c@2 { + #address-cells = <1>; + #size-cells = <0>; + reg = <2>; + }; + + nvme7: i2c@3 { + #address-cells = <1>; + #size-cells = <0>; + reg = <3>; + }; + + nvme8: i2c@4 { + #address-cells = <1>; + #size-cells = <0>; + reg = <4>; + }; + + nvme9: i2c@5 { + #address-cells = <1>; + #size-cells = <0>; + reg = <5>; + }; + + nvme10: i2c@6 { + #address-cells = <1>; + #size-cells = <0>; + reg = <6>; + }; + + nvme11: i2c@7 { + #address-cells = <1>; + #size-cells = <0>; + reg = <7>; + }; + }; +}; + +&i2c2 { + bus-frequency = <100000>; + + smpro@4f { + compatible = "ampere,smpro"; + reg = <0x4f>; + }; +}; + +&i2c3 { + // PSU FRU + eeprom@38 { + compatible = "atmel,24c02"; + reg = <0x38>; + }; +}; + +&i2c4 { + bus-frequency = <100000>; + + hardware-monitor@29 { + compatible = "nuvoton,nct7802"; + reg = <0x29>; + + #address-cells = <1>; + #size-cells = <0>; + + channel@0 { /* LTD */ + reg = <0>; + }; + + channel@1 { /* RTD1 */ + reg = <1>; + sensor-type = "temperature"; + temperature-mode = "thermistor"; + }; + + channel@2 { /* RTD2 */ + reg = <2>; + sensor-type = "temperature"; + temperature-mode = "thermal-diode"; + }; + }; + + temperature-sensor@4c { + compatible = "nuvoton,w83773g"; + reg = <0x4c>; + }; +}; + +&i2c5 { + status = "okay"; +}; + +&i2c6 { + bus-frequency = <100000>; + + rtc@6f { + compatible = "isil,isl1208"; + reg = <0x6f>; + }; +}; + +&i2c7 { + bus-frequency = <100000>; + + // BMC FRU + eeprom@57 { + compatible = "atmel,24c128"; + reg = <0x57>; + + nvmem-layout { + compatible = "fixed-layout"; + #address-cells = <1>; + #size-cells = <1>; + + eth0_macaddress: macaddress@3f88 { + reg = <0x3f88 6>; + }; + + eth1_macaddress: macaddress@3f80 { + reg = <0x3f80 6>; + }; + }; + }; +}; + +&i2c8 { + bus-frequency = <100000>; + + pca0: gpio@1c { + compatible = "nxp,pca9557"; + reg = <0x1c>; + #address-cells = <1>; + #size-cells = <0>; + + gpio-controller; + #gpio-cells = <2>; + + gpio@0 { + reg = <0>; + }; + + gpio@1 { + reg = <1>; + }; + + gpio@2 { + reg = <2>; + }; + + gpio@3 { + reg = <3>; + }; + + gpio@4 { + reg = <4>; + }; + + gpio@5 { + reg = <5>; + }; + + gpio@6 { + reg = <6>; + }; + + gpio@7 { + reg = <7>; + }; + }; +}; + +&i2c9 { + status = "okay"; +}; + +&i2c10 { + status = "okay"; +}; + +&i2c11 { + status = "okay"; +}; + +&i2c12 { + status = "okay"; +}; + +&i2c13 { + bus-frequency = <100000>; + + ssif-bmc@10 { + compatible = "ssif-bmc"; + reg = <0x10>; + }; +}; + +// Connected to host Intel X550 (ALTRAD8UD-1L2T) or +// Broadcom BCM57414 (ALTRAD8UD2-1L2Q) interface +&mac0 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii1_default>; + + clocks = <&syscon ASPEED_CLK_GATE_MAC1CLK>, + <&syscon ASPEED_CLK_MAC1RCLK>; + clock-names = "MACCLK", "RCLK"; + + use-ncsi; + + nvmem-cells = <ð0_macaddress>; + nvmem-cell-names = "mac-address"; +}; + +// Connected to Realtek RTL8211E +&mac1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>; + + nvmem-cells = <ð1_macaddress>; + nvmem-cell-names = "mac-address"; +}; + +&pinctrl { + aspeed,external-nodes = <&gfx &lhc>; +}; + +&pwm_tacho { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pwm0_default + &pinctrl_pwm1_default + &pinctrl_pwm2_default + &pinctrl_pwm3_default + &pinctrl_pwm4_default + &pinctrl_pwm5_default + &pinctrl_pwm6_default + &pinctrl_pwm7_default>; + + fan@0 { + reg = <0x00>; + aspeed,fan-tach-ch = /bits/ 8 <0x00 0x08>; + }; + + fan@1 { + reg = <0x01>; + aspeed,fan-tach-ch = /bits/ 8 <0x01 0x09>; + }; + + fan@2 { + reg = <0x02>; + aspeed,fan-tach-ch = /bits/ 8 <0x02 0x0a>; + }; + + fan@3 { + reg = <0x03>; + aspeed,fan-tach-ch = /bits/ 8 <0x03 0x0b>; + }; + + fan@4 { + reg = <0x04>; + aspeed,fan-tach-ch = /bits/ 8 <0x04 0x0c>; + }; + + fan@5 { + reg = <0x05>; + aspeed,fan-tach-ch = /bits/ 8 <0x05 0x0d>; + }; + + fan@6 { + reg = <0x06>; + aspeed,fan-tach-ch = /bits/ 8 <0x06 0x0e>; + }; + + fan@7 { + reg = <0x07>; + aspeed,fan-tach-ch = /bits/ 8 <0x07 0x0f>; + }; +}; + +&spi1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_spi1_default>; + + flash@0 { + m25p,fast-read; + label = "pnor"; + spi-max-frequency = <100000000>; + + partitions { + compatible = "fixed-partitions"; + #address-cells = <1>; + #size-cells = <1>; + + code@400000 { + reg = <0x400000 0x1C00000>; + label = "pnor-code"; + }; + + tfa@400000 { + reg = <0x400000 0x200000>; + label = "pnor-tfa"; + }; + + uefi@600000 { + reg = <0x600000 0x1A00000>; + label = "pnor-uefi"; + }; + }; + }; +}; + +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_txd1_default + &pinctrl_rxd1_default + &pinctrl_ncts1_default + &pinctrl_nrts1_default>; +}; + +&uart2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_txd2_default + &pinctrl_rxd2_default>; +}; + +&uart3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_txd3_default + &pinctrl_rxd3_default>; +}; + +&uart4 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_txd4_default + &pinctrl_rxd4_default>; +}; + +// The BMC's uart +&uart5 { + status = "okay"; +}; + +&vhub { + status = "okay"; +}; + +&video { + memory-region = <&video_engine_memory>; +}; -- 2.47.3 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC 2025-09-17 18:04 ` [PATCH v2 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran @ 2025-09-17 21:04 ` Andrew Lunn 2025-09-17 22:07 ` Rebecca Cran 2025-09-22 6:29 ` Zev Weiss 1 sibling, 1 reply; 12+ messages in thread From: Andrew Lunn @ 2025-09-17 21:04 UTC (permalink / raw) To: Rebecca Cran Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Hi Rebecca > +// Connected to host Intel X550 (ALTRAD8UD-1L2T) or > +// Broadcom BCM57414 (ALTRAD8UD2-1L2Q) interface > +&mac0 { Thanks for the comments. > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii1_default>; > + > + clocks = <&syscon ASPEED_CLK_GATE_MAC1CLK>, > + <&syscon ASPEED_CLK_MAC1RCLK>; > + clock-names = "MACCLK", "RCLK"; > + > + use-ncsi; > + > + nvmem-cells = <ð0_macaddress>; > + nvmem-cell-names = "mac-address"; > +}; > + > +// Connected to Realtek RTL8211E > +&mac1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>; > + > + nvmem-cells = <ð1_macaddress>; > + nvmem-cell-names = "mac-address"; > +}; I see you did not manage to get phy-handle to work. The problem i have is the lack of phy-mode = "rgmii-id". Aspeed has a long history have getting phy-mode wrong. This has mainly affected 2600, but as far as i understand, this is a 2500? I've been pushing back on any 2600 DT using phy-mode = "rgmii". This is 99% of the time wrong, since it indicates that the PCB has extra long clock lines. https://elixir.bootlin.com/linux/v6.15/source/Documentation/devicetree/bindings/net/ethernet-controller.yaml#L287 What aspeed get wrong is that they configure the MAC to insert 2ns delay. And this is hidden way, in the bootloader. As a result, PHY_INTERFACE_MODE_RGMII gets passed to phy_connect(), when PHY_INTERFACE_MODE_RGMII_ID should be passed. Its a case of two wrongs combine to give a working system. I've been pushing aspeed to clean up this mess. And to do that, i've been rejecting DT with phy-mode = "rgmii". Most submissions has ended up dropping ethernet support, and are now twiddling their thumbs waiting for aspeed to cleanup the mess. Or anybody actually, there is enough public information anybody could fix it, and probably end up with a crate of beer/box of wine, etc. Now, it is slightly different here. You don't have a phy-mode at all. And all the other 2500 i looked at also don't have phy-mode properties. You are relying on /* Default to RGMII. It's a gigabit part after all */ err = of_get_phy_mode(np, &phy_intf); if (err) phy_intf = PHY_INTERFACE_MODE_RGMII; This is equally wrong :-( Now, there was somebody who tried getting around my push back on 2600 by simply deleting the phy-mode, and relying on this fallback code. I said don't do that. Its just going to cause more problems when the code gets cleaned up, and we have to remember there is an oddball platform. At the time, i did not know 2500 was different, and none of the DTs use phy-mode. So, i'm humming and harring. I set a precedent, no phy-mode should get a patch rejected. But this is 2500, not 2600. O.K. I will accept it, for 2500. Since none of the 2500 boards have it, this is not an oddball platform. If the cleanup breaks it, it will break all 2500 and that should get noticed pretty quickly. So, for these two nodes only: Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC 2025-09-17 21:04 ` Andrew Lunn @ 2025-09-17 22:07 ` Rebecca Cran 0 siblings, 0 replies; 12+ messages in thread From: Rebecca Cran @ 2025-09-17 22:07 UTC (permalink / raw) To: Andrew Lunn Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 9/17/25 15:04, Andrew Lunn wrote: > I see you did not manage to get phy-handle to work. No, I didn't. I added a printk and it said the addr is 0, but adding the phy node with a reg value of 0 doesn't work. -- Rebecca Cran ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC 2025-09-17 18:04 ` [PATCH v2 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran 2025-09-17 21:04 ` Andrew Lunn @ 2025-09-22 6:29 ` Zev Weiss 2025-09-22 20:30 ` Rebecca Cran 1 sibling, 1 reply; 12+ messages in thread From: Zev Weiss @ 2025-09-22 6:29 UTC (permalink / raw) To: Rebecca Cran Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Hi Rebecca, Thanks for posting this -- a handful of small comments below... Zev On Wed, Sep 17, 2025 at 11:04:26AM PDT, Rebecca Cran wrote: >The ALTRAD8 BMC is an Aspeed AST2500-based BMC for the ASRock Rack >ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q boards. > >Signed-off-by: Rebecca Cran <rebecca@bsdio.com> >--- > arch/arm/boot/dts/aspeed/Makefile | 1 + > arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts | 633 ++++++++++++++++++++ > 2 files changed, 634 insertions(+) > >diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile >index aba7451ab749..6bffb7130839 100644 >--- a/arch/arm/boot/dts/aspeed/Makefile >+++ b/arch/arm/boot/dts/aspeed/Makefile >@@ -9,6 +9,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-ampere-mtjefferson.dtb \ > aspeed-bmc-ampere-mtmitchell.dtb \ > aspeed-bmc-arm-stardragon4800-rep2.dtb \ >+ aspeed-bmc-asrock-altrad8.dtb \ > aspeed-bmc-asrock-e3c246d4i.dtb \ > aspeed-bmc-asrock-e3c256d4i.dtb \ > aspeed-bmc-asrock-romed8hm3.dtb \ >diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts >new file mode 100644 >index 000000000000..ae3ddf5f6eb7 >--- /dev/null >+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts >@@ -0,0 +1,633 @@ >+// SPDX-License-Identifier: GPL-2.0+ >+/dts-v1/; >+ >+#include "aspeed-g5.dtsi" >+#include <dt-bindings/gpio/aspeed-gpio.h> >+#include <dt-bindings/leds/common.h> >+#include <dt-bindings/i2c/i2c.h> >+ >+/ { >+ model = "ASRock ALTRAD8 BMC"; >+ compatible = "asrock,altrad8-bmc", "aspeed,ast2500"; >+ >+ aliases { >+ serial4 = &uart5; >+ i2c50 = &nvme1; >+ i2c51 = &pcie4; >+ i2c52 = &pcie5; >+ i2c53 = &pcie6; >+ i2c54 = &pcie7; >+ i2c55 = &nvme3; >+ i2c56 = &nvme2; >+ i2c57 = &nvme0; >+ i2c58 = &nvme4; >+ i2c59 = &nvme5; >+ i2c60 = &nvme6; >+ i2c61 = &nvme7; >+ i2c62 = &nvme8; >+ i2c63 = &nvme9; >+ i2c64 = &nvme10; >+ i2c65 = &nvme11; >+ }; >+ >+ chosen { >+ stdout-path = "uart5:115200n8"; >+ }; >+ >+ iio-hwmon { >+ compatible = "iio-hwmon"; >+ io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, >+ <&adc 4> ,<&adc 5>, <&adc 6>, <&adc 7>, >+ <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>, >+ <&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>; >+ }; >+ >+ leds { >+ compatible = "gpio-leds"; >+ >+ led-system-fault { >+ gpios = <&gpio ASPEED_GPIO(G,3) GPIO_ACTIVE_LOW>; >+ label = "platform:red:fault"; >+ color = <LED_COLOR_ID_RED>; >+ function = LED_FUNCTION_FAULT; >+ }; >+ >+ led-enclosure-identify { >+ gpios = <&gpio ASPEED_GPIO(G,0) GPIO_ACTIVE_LOW>; >+ label = "platform:green:indicator"; >+ color = <LED_COLOR_ID_GREEN>; >+ function = LED_FUNCTION_INDICATOR; >+ }; >+ >+ led-fan1-fault { >+ retain-state-shutdown; >+ default-state = "off"; >+ gpios = <&pca0 0 GPIO_ACTIVE_LOW>; >+ label = "fan1:red:fault"; >+ color = <LED_COLOR_ID_RED>; >+ function = LED_FUNCTION_FAULT; >+ }; >+ >+ led-fan2-fault { >+ retain-state-shutdown; >+ default-state = "off"; >+ gpios = <&pca0 1 GPIO_ACTIVE_LOW>; >+ label = "fan2:red:fault"; >+ color = <LED_COLOR_ID_RED>; >+ function = LED_FUNCTION_FAULT; >+ }; >+ >+ led-fan3-fault { >+ retain-state-shutdown; >+ default-state = "off"; >+ gpios = <&pca0 2 GPIO_ACTIVE_LOW>; >+ label = "fan3:red:fault"; >+ color = <LED_COLOR_ID_RED>; >+ function = LED_FUNCTION_FAULT; >+ }; >+ >+ led-fan4-fault { >+ retain-state-shutdown; >+ default-state = "off"; >+ gpios = <&pca0 3 GPIO_ACTIVE_LOW>; >+ label = "fan4:red:fault"; >+ color = <LED_COLOR_ID_RED>; >+ function = LED_FUNCTION_FAULT; >+ }; >+ >+ led-fan5-fault { >+ retain-state-shutdown; >+ default-state = "off"; >+ gpios = <&pca0 4 GPIO_ACTIVE_LOW>; >+ label = "fan5:red:fault"; >+ color = <LED_COLOR_ID_RED>; >+ function = LED_FUNCTION_FAULT; >+ }; >+ }; >+ >+ memory@80000000 { >+ reg = <0x80000000 0x20000000>; >+ }; >+ >+ reserved-memory { >+ #address-cells = <1>; >+ #size-cells = <1>; >+ ranges; >+ >+ gfx_memory: framebuffer { >+ compatible = "shared-dma-pool"; >+ size = <0x01000000>; >+ alignment = <0x01000000>; >+ reusable; >+ }; >+ >+ vga_memory: framebuffer@9f000000 { >+ no-map; >+ reg = <0x9f000000 0x01000000>; /* 16M */ >+ }; >+ >+ video_engine_memory: jpegbuffer { >+ compatible = "shared-dma-pool"; >+ size = <0x02000000>; /* 32M */ >+ alignment = <0x01000000>; >+ reusable; >+ }; >+ }; >+}; >+ >+&adc { >+ status = "okay"; >+}; >+ >+&fmc { >+ flash@0 { >+ label = "bmc"; >+ m25p,fast-read; >+ spi-max-frequency = <50000000>; >+#include "openbmc-flash-layout-64.dtsi" >+ }; >+}; >+ >+&gfx { >+ memory-region = <&gfx_memory>; >+}; >+ >+&gpio { >+ gpio-line-names = >+ /*A0-A7*/ "","","","BMC_READY","","","","", >+ /*B0-B7*/ "i2c-backup-sel","","","","","","","host0-shd-ack-n", >+ /*C0-C7*/ "","","","","","","","", >+ /*D0-D7*/ "POWER_BUTTON","POWER_OUT","RESET_BUTTON", >+ "host0-sysreset-n","","","SYS_PWR_GD","", >+ /*E0-E7*/ "","s0-vrd1-vddq0123-fault-l", >+ "s0-vrd1-vddq4567-fault-l","s0-vrd0-vddc-fault-l", >+ "s0-vrd3-p0v75-fault-l","","","", >+ /*F0-F7*/ "","","SYS_ATX_PSON_L","","","","","", >+ /*G0-G7*/ "id-led","id-button","","","UBOOT_READY",\ >+ "BMC_SALT2_L","","", >+ /*H0-H7*/ "PS_PWROK","uart1-mode1","uart2-mode1","uart3-mode1", >+ "uart4-mode1","","BMC_HB_LED","", >+ /*I0-I7*/ "","","","","","","","", >+ /*J0-J7*/ "s0-hightemp-n","","","","","","","", >+ /*K0-K7*/ "","","","","","","","", >+ /*L0-L7*/ "","","","","","","","", >+ /*M0-M7*/ "","","","","","s0-spi-auth-fail-n","","", >+ /*N0-N7*/ "","","","","","","","", >+ /*O0-O7*/ "","","","","","","","", >+ /*P0-P7*/ "","","CPLD_DISABLE_BMC","","","","","", >+ /*Q0-Q7*/ "","","ext-hightemp-n","","","","", >+ "CHASSIS_INTRUSION", >+ /*R0-R7*/ "","","EXT_HIGHTEMP_L","spi0-program-sel","", >+ "HWM_BAT_EN","","", >+ /*S0-S7*/ "s0-vr-hot-n","","","BMC_SYSRESET_L","","","","", >+ /*T0-T7*/ "","","","","","","","", >+ /*U0-U7*/ "","","","","","","","", >+ /*V0-V7*/ "","","","","","","","", >+ /*W0-W7*/ "","","","","","","","", >+ /*X0-X7*/ "","","","","","","","", >+ /*Y0-Y7*/ "SIOS3","SIOS5","SIOPWREQ","SIOONCTRL","","","","", >+ /*Z0-Z7*/ "","SIOPWRGD","","s0-rtc-lock","","","","", >+ /*AA0-AA7*/ "RTC_INT","","","","","PMBUS_SEL_N","","", >+ /*AB0-AB7*/ "host0-reboot-ack-n","s0-sys-auth-failure-n", >+ "","","","","","", >+ /*AC0-AC7*/ "s0-fault-alert","host0-ready","s0-overtemp-n", >+ "","bmc-ok","host0-special-boot","presence-cpu0", >+ "host0-shd-req-n"; >+}; >+ >+&i2c0 { >+ bus-frequency = <100000>; Here and on most of the other i2c busses, is there a particular reason we want this bus-frequency explicitly specified? 100kHz is the default according to Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml (and the other existing aspeed-bmc-asrock-*.dts files leave it at that implicit default, FWIW). >+ >+ ipmb@10 { >+ compatible = "ipmb-dev"; >+ reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>; >+ i2c-protocol; >+ }; >+ >+}; >+ >+&i2c1 { >+ bus-frequency = <100000>; >+ >+ i2c-mux1@73 { >+ compatible = "nxp,pca9548"; >+ reg = <0x73>; >+ #address-cells = <1>; >+ #size-cells = <0>; >+ i2c-mux-idle-disconnect; >+ >+ nvme1: i2c@0 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <0>; >+ }; >+ >+ pcie4: i2c@1 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <1>; >+ }; >+ >+ pcie5: i2c@2 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <2>; >+ }; >+ >+ pcie6: i2c@3 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <3>; >+ }; >+ >+ pcie7: i2c@4 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <4>; >+ }; >+ >+ nvme3: i2c@5 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <5>; >+ }; >+ >+ nvme2: i2c@6 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <6>; >+ }; >+ >+ nvme0: i2c@7 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <7>; >+ }; >+ }; >+ >+ i2c-mux2@75 { >+ compatible = "nxp,pca9548"; >+ reg = <0x75>; >+ #address-cells = <1>; >+ #size-cells = <0>; >+ i2c-mux-idle-disconnect; >+ >+ nvme4: i2c@0 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <0>; >+ }; >+ >+ nvme5: i2c@1 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <1>; >+ }; >+ >+ nvme6: i2c@2 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <2>; >+ }; >+ >+ nvme7: i2c@3 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <3>; >+ }; >+ >+ nvme8: i2c@4 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <4>; >+ }; >+ >+ nvme9: i2c@5 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <5>; >+ }; >+ >+ nvme10: i2c@6 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <6>; >+ }; >+ >+ nvme11: i2c@7 { >+ #address-cells = <1>; >+ #size-cells = <0>; >+ reg = <7>; >+ }; >+ }; >+}; >+ >+&i2c2 { >+ bus-frequency = <100000>; >+ >+ smpro@4f { >+ compatible = "ampere,smpro"; >+ reg = <0x4f>; >+ }; >+}; >+ >+&i2c3 { >+ // PSU FRU >+ eeprom@38 { >+ compatible = "atmel,24c02"; >+ reg = <0x38>; >+ }; >+}; >+ >+&i2c4 { >+ bus-frequency = <100000>; >+ >+ hardware-monitor@29 { It looks like this device only monitors temperatures? If so, perhaps temperature-sensor@29 would be a slightly more appropriate node name. >+ compatible = "nuvoton,nct7802"; >+ reg = <0x29>; >+ >+ #address-cells = <1>; >+ #size-cells = <0>; >+ >+ channel@0 { /* LTD */ >+ reg = <0>; >+ }; >+ >+ channel@1 { /* RTD1 */ >+ reg = <1>; >+ sensor-type = "temperature"; >+ temperature-mode = "thermistor"; >+ }; >+ >+ channel@2 { /* RTD2 */ >+ reg = <2>; >+ sensor-type = "temperature"; >+ temperature-mode = "thermal-diode"; >+ }; channel@1 and channel@2 block bodies look over-indented by one level here. >+ }; >+ >+ temperature-sensor@4c { >+ compatible = "nuvoton,w83773g"; >+ reg = <0x4c>; >+ }; >+}; >+ >+&i2c5 { >+ status = "okay"; >+}; >+ >+&i2c6 { >+ bus-frequency = <100000>; >+ >+ rtc@6f { >+ compatible = "isil,isl1208"; >+ reg = <0x6f>; >+ }; >+}; >+ >+&i2c7 { >+ bus-frequency = <100000>; >+ >+ // BMC FRU >+ eeprom@57 { >+ compatible = "atmel,24c128"; >+ reg = <0x57>; >+ >+ nvmem-layout { >+ compatible = "fixed-layout"; >+ #address-cells = <1>; >+ #size-cells = <1>; >+ >+ eth0_macaddress: macaddress@3f88 { >+ reg = <0x3f88 6>; >+ }; >+ >+ eth1_macaddress: macaddress@3f80 { >+ reg = <0x3f80 6>; >+ }; Are these correct? On every other ASRock board I've dealt with, the eth0 address is at 0x3f80 and eth1 is at 0x3f88. If so and they are really for some reason swapped on this platform, as a slight nitpick I might suggest swapping the order the nodes are listed in so they go in order of increasing addresses. >+ }; >+ }; >+}; >+ >+&i2c8 { >+ bus-frequency = <100000>; >+ >+ pca0: gpio@1c { >+ compatible = "nxp,pca9557"; >+ reg = <0x1c>; >+ #address-cells = <1>; >+ #size-cells = <0>; >+ >+ gpio-controller; >+ #gpio-cells = <2>; >+ >+ gpio@0 { >+ reg = <0>; >+ }; >+ >+ gpio@1 { >+ reg = <1>; >+ }; >+ >+ gpio@2 { >+ reg = <2>; >+ }; >+ >+ gpio@3 { >+ reg = <3>; >+ }; >+ >+ gpio@4 { >+ reg = <4>; >+ }; >+ >+ gpio@5 { >+ reg = <5>; >+ }; >+ >+ gpio@6 { >+ reg = <6>; >+ }; >+ >+ gpio@7 { >+ reg = <7>; >+ }; >+ }; >+}; >+ >+&i2c9 { >+ status = "okay"; >+}; >+ >+&i2c10 { >+ status = "okay"; >+}; >+ >+&i2c11 { >+ status = "okay"; >+}; >+ >+&i2c12 { >+ status = "okay"; >+}; >+ >+&i2c13 { >+ bus-frequency = <100000>; >+ >+ ssif-bmc@10 { >+ compatible = "ssif-bmc"; >+ reg = <0x10>; >+ }; >+}; >+ >+// Connected to host Intel X550 (ALTRAD8UD-1L2T) or >+// Broadcom BCM57414 (ALTRAD8UD2-1L2Q) interface >+&mac0 { >+ pinctrl-names = "default"; >+ pinctrl-0 = <&pinctrl_rmii1_default>; >+ >+ clocks = <&syscon ASPEED_CLK_GATE_MAC1CLK>, >+ <&syscon ASPEED_CLK_MAC1RCLK>; >+ clock-names = "MACCLK", "RCLK"; >+ >+ use-ncsi; >+ >+ nvmem-cells = <ð0_macaddress>; >+ nvmem-cell-names = "mac-address"; >+}; >+ >+// Connected to Realtek RTL8211E >+&mac1 { >+ pinctrl-names = "default"; >+ pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>; >+ >+ nvmem-cells = <ð1_macaddress>; >+ nvmem-cell-names = "mac-address"; >+}; >+ >+&pinctrl { >+ aspeed,external-nodes = <&gfx &lhc>; >+}; >+ >+&pwm_tacho { >+ pinctrl-names = "default"; >+ pinctrl-0 = <&pinctrl_pwm0_default >+ &pinctrl_pwm1_default >+ &pinctrl_pwm2_default >+ &pinctrl_pwm3_default >+ &pinctrl_pwm4_default >+ &pinctrl_pwm5_default >+ &pinctrl_pwm6_default >+ &pinctrl_pwm7_default>; >+ >+ fan@0 { >+ reg = <0x00>; >+ aspeed,fan-tach-ch = /bits/ 8 <0x00 0x08>; >+ }; >+ >+ fan@1 { >+ reg = <0x01>; >+ aspeed,fan-tach-ch = /bits/ 8 <0x01 0x09>; >+ }; >+ >+ fan@2 { >+ reg = <0x02>; >+ aspeed,fan-tach-ch = /bits/ 8 <0x02 0x0a>; >+ }; >+ >+ fan@3 { >+ reg = <0x03>; >+ aspeed,fan-tach-ch = /bits/ 8 <0x03 0x0b>; >+ }; >+ >+ fan@4 { >+ reg = <0x04>; >+ aspeed,fan-tach-ch = /bits/ 8 <0x04 0x0c>; >+ }; >+ >+ fan@5 { >+ reg = <0x05>; >+ aspeed,fan-tach-ch = /bits/ 8 <0x05 0x0d>; >+ }; >+ >+ fan@6 { >+ reg = <0x06>; >+ aspeed,fan-tach-ch = /bits/ 8 <0x06 0x0e>; >+ }; >+ >+ fan@7 { >+ reg = <0x07>; >+ aspeed,fan-tach-ch = /bits/ 8 <0x07 0x0f>; >+ }; >+}; >+ >+&spi1 { >+ pinctrl-names = "default"; >+ pinctrl-0 = <&pinctrl_spi1_default>; >+ >+ flash@0 { >+ m25p,fast-read; >+ label = "pnor"; >+ spi-max-frequency = <100000000>; >+ >+ partitions { >+ compatible = "fixed-partitions"; >+ #address-cells = <1>; >+ #size-cells = <1>; >+ >+ code@400000 { >+ reg = <0x400000 0x1C00000>; >+ label = "pnor-code"; >+ }; >+ >+ tfa@400000 { >+ reg = <0x400000 0x200000>; >+ label = "pnor-tfa"; >+ }; As the DTBS_CHECK lint reported and Andrew Jeffery commented on, these two partitions overlapping is a bit surprising -- is that intentional? >+ >+ uefi@600000 { >+ reg = <0x600000 0x1A00000>; >+ label = "pnor-uefi"; >+ }; >+ }; >+ }; >+}; >+ >+&uart1 { >+ pinctrl-names = "default"; >+ pinctrl-0 = <&pinctrl_txd1_default >+ &pinctrl_rxd1_default >+ &pinctrl_ncts1_default >+ &pinctrl_nrts1_default>; >+}; >+ >+&uart2 { >+ pinctrl-names = "default"; >+ pinctrl-0 = <&pinctrl_txd2_default >+ &pinctrl_rxd2_default>; >+}; >+ >+&uart3 { >+ pinctrl-names = "default"; >+ pinctrl-0 = <&pinctrl_txd3_default >+ &pinctrl_rxd3_default>; >+}; >+ >+&uart4 { >+ pinctrl-names = "default"; >+ pinctrl-0 = <&pinctrl_txd4_default >+ &pinctrl_rxd4_default>; >+}; >+ >+// The BMC's uart >+&uart5 { >+ status = "okay"; >+}; >+ >+&vhub { >+ status = "okay"; >+}; >+ >+&video { >+ memory-region = <&video_engine_memory>; >+}; >-- >2.47.3 > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC 2025-09-22 6:29 ` Zev Weiss @ 2025-09-22 20:30 ` Rebecca Cran 0 siblings, 0 replies; 12+ messages in thread From: Rebecca Cran @ 2025-09-22 20:30 UTC (permalink / raw) To: Zev Weiss Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 9/22/25 00:29, Zev Weiss wrote: > Here and on most of the other i2c busses, is there a particular reason > we want this bus-frequency explicitly specified? 100kHz is the > default according to > Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml (and the other > existing aspeed-bmc-asrock-*.dts files leave it at that implicit > default, FWIW). There's no particular reason - I've deleted them. > It looks like this device only monitors temperatures? If so, perhaps > temperature-sensor@29 would be a slightly more appropriate node name. The chip can also monitor power supply voltages and fan speeds but on this board it's only used as a temperature sensor, so I'll change the node name. > channel@1 and channel@2 block bodies look over-indented by one level > here. Thanks - fixed. > Are these correct? On every other ASRock board I've dealt with, the > eth0 address is at 0x3f80 and eth1 is at 0x3f88. > > If so and they are really for some reason swapped on this platform, as > a slight nitpick I might suggest swapping the order the nodes are > listed in so they go in order of increasing addresses. After installing the latest 3.06 BMC firmware from the ASRock website, I'm seeing: root@altrad8ud-1l2t:~# ifconfig eth0 Link encap:Ethernet HWaddr 9C:6B:00:43:0B:F7 inet addr:10.0.0.25 Bcast:10.0.0.255 Mask:255.255.255.0 UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:457 errors:0 dropped:0 overruns:0 frame:0 TX packets:240 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:88379 (86.3 KiB) TX bytes:17663 (17.2 KiB) Interrupt:26 eth1 Link encap:Ethernet HWaddr 9C:6B:00:43:0B:BD inet addr:10.0.0.11 Bcast:10.0.0.255 Mask:255.255.255.0 UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:368 errors:0 dropped:0 overruns:0 frame:0 TX packets:26 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:88134 (86.0 KiB) TX bytes:3507 (3.4 KiB) Interrupt:27 lo Link encap:Local Loopback inet addr:127.0.0.1 Mask:255.0.0.0 inet6 addr: ::1/128 Scope:Host UP LOOPBACK RUNNING MTU:65536 Metric:1 RX packets:434 errors:0 dropped:0 overruns:0 frame:0 TX packets:434 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:34479 (33.6 KiB) TX bytes:34479 (33.6 KiB) usb0 Link encap:Ethernet HWaddr 4E:F6:84:8E:63:B9 inet addr:169.254.0.17 Bcast:169.254.255.255 Mask:255.255.0.0 UP BROADCAST MULTICAST MTU:1500 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) root@altrad8ud-1l2t:~# hexdump -C /sys/bus/i2c/devices/7-0057/eeprom ... * 00003f80 9c 6b 00 43 0b bd ff ff 9c 6b 00 43 0b f7 ff ff |.k.C.....k.C....| 00003f90 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................| * 00003fd0 1e 90 db 9a 13 ff cb ff 4e f6 84 8e 63 b9 8e ff |........N...c...| 00003fe0 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................| * 00004000 I don't know why they're swapped, but I think keeping them that way makes sense to avoid people's IP address changing. > As the DTBS_CHECK lint reported and Andrew Jeffery commented on, these > two partitions overlapping is a bit surprising -- is that intentional? It was intentional since I've updated the firmware update script to be able to program the TF-A or UEFI areas separately, or the entire code region (i.e. TF-A _and_ UEFI, excluding the data/configuration areas of the EEPROM). But I'll update the script to not depend on there being a 'code' partition that covers both areas. -- Rebecca Cran ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC 2025-09-17 18:04 [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran 2025-09-17 18:04 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board Rebecca Cran 2025-09-17 18:04 ` [PATCH v2 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran @ 2025-09-18 1:14 ` Rob Herring (Arm) 2025-09-22 2:40 ` Andrew Jeffery 3 siblings, 0 replies; 12+ messages in thread From: Rob Herring (Arm) @ 2025-09-18 1:14 UTC (permalink / raw) To: Rebecca Cran Cc: Andrew Jeffery, Joel Stanley, linux-aspeed, linux-arm-kernel, Krzysztof Kozlowski, Conor Dooley, devicetree, linux-kernel On Wed, 17 Sep 2025 12:04:24 -0600, Rebecca Cran wrote: > The ASRock Rack ALTRAD8 BMC is an Aspeed AST2500-based BMC for the > ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q boards with an Ampere Altra > processor. The BMC runs OpenBMC. > > These patches add a device tree and binding for the BMC. > > **Changes between v1 and v2** > > - Reordered nodes to be in alphabetical order. > - Removed status lines. > - Fixed naming. > > There are still several warnings from > make CHECK_DTBS=y ARCH=arm W=1 aspeed/aspeed-bmc-asrock-altrad8.dtb > I believe the only one which is reporting an issue in my dts file (as opposed > to included files) is the first, and that's because the code partition contains > the TF-A and UEFI areas. I couldn't see a way to suppress it. > > aspeed-bmc-asrock-altrad8.dts:578.16-581.6: Warning (unique_unit_address_if_enabled): /ahb/spi@1e630000/flash@0/partitions/code@400000: duplicate unit-address (also used in node /ahb/spi@1e630000/flash@0/partitions/tfa@400000) > aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/memory-controller@1e6e0000: failed to match any schema with compatible: ['aspeed,ast2500-sdram-edac'] > aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/syscon@1e6e2000/p2a-control@2c: failed to match any schema with compatible: ['aspeed,ast2500-p2a-ctrl'] > aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/display@1e6e6000: failed to match any schema with compatible: ['aspeed,ast2500-gfx', 'syscon'] > aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/timer@1e782000: failed to match any schema with compatible: ['aspeed,ast2400-timer'] > aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/pwm-tacho-controller@1e786000: failed to match any schema with compatible: ['aspeed,ast2500-pwm-tacho'] > aspeed-bmc-asrock-altrad8.dtb: fan@0: aspeed,fan-tach-ch: b'\x00\x08' is not of type 'object', 'integer', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > aspeed-bmc-asrock-altrad8.dtb: fan@1: aspeed,fan-tach-ch: b'\x01\t' is not of type 'object', 'integer', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > aspeed-bmc-asrock-altrad8.dtb: fan@2: aspeed,fan-tach-ch: b'\x02\n' is not of type 'object', 'integer', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > aspeed-bmc-asrock-altrad8.dtb: fan@3: aspeed,fan-tach-ch: b'\x03\x0b' is not of type 'object', 'integer', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > aspeed-bmc-asrock-altrad8.dtb: fan@4: aspeed,fan-tach-ch: b'\x04\x0c' is not of type 'object', 'integer', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > aspeed-bmc-asrock-altrad8.dtb: fan@5: aspeed,fan-tach-ch: b'\x05\r' is not of type 'object', 'integer', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > aspeed-bmc-asrock-altrad8.dtb: fan@6: aspeed,fan-tach-ch: b'\x06\x0e' is not of type 'object', 'integer', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > aspeed-bmc-asrock-altrad8.dtb: fan@7: aspeed,fan-tach-ch: b'\x07\x0f' is not of type 'object', 'integer', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > aspeed-bmc-asrock-altrad8.dtb: lpc@1e789000 (aspeed,ast2500-lpc-v2): reg-io-width: 4 is not of type 'object' > from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# > aspeed-bmc-asrock-altrad8.dtb: lpc@1e789000 (aspeed,ast2500-lpc-v2): lpc-snoop@90: 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# > aspeed-bmc-asrock-altrad8.dtb: kcs@24 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > aspeed-bmc-asrock-altrad8.dtb: kcs@28 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > aspeed-bmc-asrock-altrad8.dtb: kcs@2c (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > aspeed-bmc-asrock-altrad8.dtb: kcs@114 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# > aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/lpc@1e789000/lhc@a0: failed to match any schema with compatible: ['aspeed,ast2500-lhc'] > aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/lpc@1e789000/ibt@140: failed to match any schema with compatible: ['aspeed,ast2500-ibt-bmc'] > aspeed-bmc-asrock-altrad8.dtb: gpio@1c (nxp,pca9557): '#address-cells', '#size-cells', 'gpio@0', 'gpio@1', 'gpio@2', 'gpio@3', 'gpio@4', 'gpio@5', 'gpio@6', 'gpio@7' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml# > > > Rebecca Cran (2): > dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board > ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC > > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > arch/arm/boot/dts/aspeed/Makefile | 1 + > arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts | 633 ++++++++++++++++++++ > 3 files changed, 635 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dts > > > base-commit: 5aca7966d2a7255ba92fd5e63268dd767b223aa5 > -- > 2.47.3 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade This patch series was applied (using b4) to base: Base: using specified base-commit 5aca7966d2a7255ba92fd5e63268dd767b223aa5 If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically) New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/aspeed/' for 20250917180428.810751-1-rebecca@bsdio.com: arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/memory-controller@1e6e0000: failed to match any schema with compatible: ['aspeed,ast2500-sdram-edac'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/syscon@1e6e2000/p2a-control@2c: failed to match any schema with compatible: ['aspeed,ast2500-p2a-ctrl'] arch/arm/boot/dts/aspeed/aspeed-bmc-lenovo-hr630.dtb: /ahb/apb/display@1e6e6000: failed to match any schema with compatible: ['aspeed,ast2500-gfx', 'syscon'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/display@1e6e6000: failed to match any schema with compatible: ['aspeed,ast2500-gfx', 'syscon'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/timer@1e782000: failed to match any schema with compatible: ['aspeed,ast2400-timer'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/pwm-tacho-controller@1e786000: failed to match any schema with compatible: ['aspeed,ast2500-pwm-tacho'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: fan@0: aspeed,fan-tach-ch: b'\x00\x08' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: fan@1: aspeed,fan-tach-ch: b'\x01 ' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: fan@2: aspeed,fan-tach-ch: b'\x02 ' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: fan@3: aspeed,fan-tach-ch: b'\x03\x0b' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: fan@4: aspeed,fan-tach-ch: b'\x04\x0c' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: fan@5: aspeed,fan-tach-ch: b'\x05 ' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: fan@6: aspeed,fan-tach-ch: b'\x06\x0e' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: fan@7: aspeed,fan-tach-ch: b'\x07\x0f' is not of type 'object', 'integer', 'array', 'boolean', 'null' from schema $id: http://devicetree.org/schemas/dt-core.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: lpc@1e789000 (aspeed,ast2500-lpc-v2): reg-io-width: 4 is not of type 'object' from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: lpc@1e789000 (aspeed,ast2500-lpc-v2): lpc-snoop@90: 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: kcs@24 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: kcs@28 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: kcs@2c (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: kcs@114 (aspeed,ast2500-kcs-bmc-v2): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/lpc@1e789000/lhc@a0: failed to match any schema with compatible: ['aspeed,ast2500-lhc'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/lpc@1e789000/ibt@140: failed to match any schema with compatible: ['aspeed,ast2500-ibt-bmc'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-altrad8.dtb: gpio@1c (nxp,pca9557): '#address-cells', '#size-cells', 'gpio@0', 'gpio@1', 'gpio@2', 'gpio@3', 'gpio@4', 'gpio@5', 'gpio@6', 'gpio@7' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml# ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC 2025-09-17 18:04 [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran ` (2 preceding siblings ...) 2025-09-18 1:14 ` [PATCH v2 0/2] Add " Rob Herring (Arm) @ 2025-09-22 2:40 ` Andrew Jeffery 2025-09-22 20:47 ` Rebecca Cran 3 siblings, 1 reply; 12+ messages in thread From: Andrew Jeffery @ 2025-09-22 2:40 UTC (permalink / raw) To: Rebecca Cran, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Hi Rebecca, On Wed, 2025-09-17 at 12:04 -0600, Rebecca Cran wrote: > The ASRock Rack ALTRAD8 BMC is an Aspeed AST2500-based BMC for the > ALTRAD8UD-1L2T and ALTRAD8UD2-1L2Q boards with an Ampere Altra > processor. The BMC runs OpenBMC. > > These patches add a device tree and binding for the BMC. > > **Changes between v1 and v2** > > - Reordered nodes to be in alphabetical order. > - Removed status lines. > - Fixed naming. > > There are still several warnings from > make CHECK_DTBS=y ARCH=arm W=1 aspeed/aspeed-bmc-asrock-altrad8.dtb Thanks for checking! > I believe the only one which is reporting an issue in my dts file (as opposed > to included files) is the first, and that's because the code partition contains > the TF-A and UEFI areas. I couldn't see a way to suppress it. > > aspeed-bmc-asrock-altrad8.dts:578.16-581.6: Warning (unique_unit_address_if_enabled): /ahb/spi@1e630000/flash@0/partitions/code@400000: duplicate unit-address (also used in node /ahb/spi@1e630000/flash@0/partitions/tfa@400000) It seems odd that the partitions intersect. Are the offsets correct? If they are, can you add comments to the DTS discussing what's going on there? > aspeed-bmc-asrock-altrad8.dtb: /ahb/apb/memory-controller@1e6e0000: failed to match any schema with compatible: ['aspeed,ast2500-sdram-edac'] *snip* > aspeed-bmc-asrock-altrad8.dtb: gpio@1c (nxp,pca9557): '#address-cells', '#size-cells', 'gpio@0', 'gpio@1', 'gpio@2', 'gpio@3', 'gpio@4', 'gpio@5', 'gpio@6', 'gpio@7' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml# This one needs fixing. Cheers, Andrew ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC 2025-09-22 2:40 ` Andrew Jeffery @ 2025-09-22 20:47 ` Rebecca Cran 2025-09-24 2:13 ` Andrew Jeffery 0 siblings, 1 reply; 12+ messages in thread From: Rebecca Cran @ 2025-09-22 20:47 UTC (permalink / raw) To: Andrew Jeffery, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 9/21/25 20:40, Andrew Jeffery wrote: > On Wed, 2025-09-17 at 12:04 -0600, Rebecca Cran wrote: >> aspeed-bmc-asrock-altrad8.dts:578.16-581.6: Warning (unique_unit_address_if_enabled): /ahb/spi@1e630000/flash@0/partitions/code@400000: duplicate unit-address (also used in node /ahb/spi@1e630000/flash@0/partitions/tfa@400000) > It seems odd that the partitions intersect. Are the offsets correct? If > they are, can you add comments to the DTS discussing what's going on > there? I'll delete the code partition. I added it to make it easier for my script to flash both TF-A and UEFI areas at once. > >> aspeed-bmc-asrock-altrad8.dtb: gpio@1c (nxp,pca9557): '#address-cells', '#size-cells', 'gpio@0', 'gpio@1', 'gpio@2', 'gpio@3', 'gpio@4', 'gpio@5', 'gpio@6', 'gpio@7' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$' >> from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml# > This one needs fixing. I'm confused, because in the existing device tree files I'm only seeing 'hog' used in the &gpio node, while 'pca[0-9]+' is commonly used as the node names for pca95xx devices. Does the gpio-pca95xx.yaml file need to be updated? -- Rebecca Cran ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC 2025-09-22 20:47 ` Rebecca Cran @ 2025-09-24 2:13 ` Andrew Jeffery 0 siblings, 0 replies; 12+ messages in thread From: Andrew Jeffery @ 2025-09-24 2:13 UTC (permalink / raw) To: Rebecca Cran, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Hi Rebecca, On Mon, 2025-09-22 at 14:47 -0600, Rebecca Cran wrote: > On 9/21/25 20:40, Andrew Jeffery wrote: > > > On Wed, 2025-09-17 at 12:04 -0600, Rebecca Cran wrote: > > > aspeed-bmc-asrock-altrad8.dts:578.16-581.6: Warning (unique_unit_address_if_enabled): /ahb/spi@1e630000/flash@0/partitions/code@400000: duplicate unit-address (also used in node /ahb/spi@1e630000/flash@0/partitions/tfa@400000) > > It seems odd that the partitions intersect. Are the offsets correct? If > > they are, can you add comments to the DTS discussing what's going on > > there? > I'll delete the code partition. I added it to make it easier for my > script to flash both TF-A and UEFI areas at once. Okay, thanks. > > > > > aspeed-bmc-asrock-altrad8.dtb: gpio@1c (nxp,pca9557): '#address-cells', '#size-cells', 'gpio@0', 'gpio@1', 'gpio@2', 'gpio@3', 'gpio@4', 'gpio@5', 'gpio@6', 'gpio@7' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$' > > > from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml# > > This one needs fixing. > > I'm confused, because in the existing device tree files I'm only seeing > 'hog' used in the &gpio node, while 'pca[0-9]+' is commonly used as the > node names for pca95xx devices. The error above is referring to properties and sub-nodes of your nxp,pca9557 compatible node, rather than the name of the node itself. That said, node names are preferred to be generic (e.g. gpio@) rather than specific. > > Does the gpio-pca95xx.yaml file need to be updated? > It depends on what you're trying to achieve. At v6.17-rc1 no other devicetree in the kernel defines an nxp,pca9557 node as you have here with gpio@ subnodes, and neither does the gpio-pca95xx.yaml binding allow them. What caused you to add them? I expect what you need to do is remove those sub-nodes, along with #address-cells and #size-cells. Andrew ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2025-09-24 2:13 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-09-17 18:04 [PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran 2025-09-17 18:04 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: add ASRock Rack ALTRAD8 board Rebecca Cran 2025-09-17 19:17 ` Conor Dooley 2025-09-17 18:04 ` [PATCH v2 2/2] ARM: dts: aspeed: add device tree for ASRock Rack ALTRAD8 BMC Rebecca Cran 2025-09-17 21:04 ` Andrew Lunn 2025-09-17 22:07 ` Rebecca Cran 2025-09-22 6:29 ` Zev Weiss 2025-09-22 20:30 ` Rebecca Cran 2025-09-18 1:14 ` [PATCH v2 0/2] Add " Rob Herring (Arm) 2025-09-22 2:40 ` Andrew Jeffery 2025-09-22 20:47 ` Rebecca Cran 2025-09-24 2:13 ` Andrew Jeffery
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).