From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 3/4] gpio: creg-snps: Simplify with of_device_get_match_data()
Date: Thu, 06 Nov 2025 17:16:27 +0100 [thread overview]
Message-ID: <20251106-gpio-of-match-v1-3-50c7115a045e@linaro.org> (raw)
In-Reply-To: <20251106-gpio-of-match-v1-0-50c7115a045e@linaro.org>
Driver's probe function matches against driver's of_device_id table,
where each entry has non-NULL match data, so of_match_node() can be
simplified with of_device_get_match_data().
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/gpio/gpio-creg-snps.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
index f8ea961fa1de..cdb103b0fae3 100644
--- a/drivers/gpio/gpio-creg-snps.c
+++ b/drivers/gpio/gpio-creg-snps.c
@@ -134,7 +134,6 @@ static const struct of_device_id creg_gpio_ids[] = {
static int creg_gpio_probe(struct platform_device *pdev)
{
- const struct of_device_id *match;
struct device *dev = &pdev->dev;
struct creg_gpio *hcg;
u32 ngpios;
@@ -148,8 +147,7 @@ static int creg_gpio_probe(struct platform_device *pdev)
if (IS_ERR(hcg->regs))
return PTR_ERR(hcg->regs);
- match = of_match_node(creg_gpio_ids, pdev->dev.of_node);
- hcg->layout = match->data;
+ hcg->layout = of_device_get_match_data(dev);
if (!hcg->layout)
return -EINVAL;
--
2.48.1
next prev parent reply other threads:[~2025-11-06 16:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 16:16 [PATCH 0/4] gpio: Simplify with of_device_get_match_data() Krzysztof Kozlowski
2025-11-06 16:16 ` [PATCH 1/4] gpio: tb10x: Drop unused tb10x_set_bits() function Krzysztof Kozlowski
2025-11-06 16:16 ` [PATCH 2/4] gpio: aspeed: Simplify with of_device_get_match_data() Krzysztof Kozlowski
2025-11-06 16:23 ` Bartosz Golaszewski
2025-11-06 19:13 ` Krzysztof Kozlowski
2025-11-07 10:32 ` Bartosz Golaszewski
2025-11-06 16:16 ` Krzysztof Kozlowski [this message]
2025-11-06 16:16 ` [PATCH 4/4] gpio: zynq: " Krzysztof Kozlowski
2025-11-06 17:19 ` (subset) [PATCH 0/4] gpio: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106-gpio-of-match-v1-3-50c7115a045e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=andrew@codeconstruct.com.au \
--cc=brgl@bgdev.pl \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).