Re: [PATCH v23 1/4] dt-bindings: i2c: Split AST2600 binding into a new YAML

Rob Herring (Arm)
2025-11-17T04:32:32Z

On Mon, 17 Nov 2025 10:50:37 +0800, Ryan Chen wrote:
> The AST2600 I2C controller introduces a completely new register
> map and Separate control/target register sets, unlike the mixed
> layout used in AST2400/AST2500.
>
> In addition, at new AST2600 configuration registers and transfer
> modes require new DT properties, which are incompatible with
> existing bindings. Therefore, this creates a dedicated binding
> file for AST2600 to properly describe these new hardware
> capabilities.
>
> A subsequent change will modify this new binding to properly
> describe the AST2600 hardware.
>
> The example section updated to reflect the actual AST2600 SoC
> register layout and interrupt configuration.
> Reference: aspeed-g6.dtsi (lines 885-897)
>
> -I2C bus and buffer register offsets
> - AST2600 I2C controller register base starts from 0x80, and the
> buffer region is located at 0xc00, as defined in AST2600 SOC
> register map.
>
> -Interrupt configuration
> - AST2600 I2C controller are connected to ARM GIC interrupt
> controller rather than the legacy internal interrupt controller.
>
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
> .../bindings/i2c/aspeed,ast2600-i2c.yaml | 66 +++++++++++++++++++
> .../devicetree/bindings/i2c/aspeed,i2c.yaml | 3 +-
> 2 files changed, 67 insertions(+), 2 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,ast2600-i2c.yaml
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/i2c/aspeed,ast2600-i2c.yaml:25:1: [warning] too many blank lines (2 > 1) (empty-lines)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251117025040.3622984-2-ryan_chen@aspeedtech.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.