From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F056D3ABC3 for ; Sat, 6 Dec 2025 00:08:14 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dNT9841vNz2xPL; Sat, 06 Dec 2025 11:08:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1764979692; cv=none; b=K1vgHTm6b1Bv7EJuWcv+POTB0QVZR3sybtL5wyv2/UZELksfpQzgSymqT9UTqV2QPCd6VfKcOxidkSmKgA+IwTLT3+4PD5InIUiLEa6sy3SDr3UDCrtzqlRYAC7pF7ihP1XIgag+fxEdR5rZ7HSiwOi7Ib7H+F+NtQHZOx4PBwhjxJr9/wdi6BaofSLsOMgO7EUbkllTy1FQglVE+Rjn1QqmPgl+MFXh7rx2loPAyjeKc2W60wk0blYOE9BxKyZtrDzfYik9xz2XAKw+60tvrQhAof8Uo0EaJpBD7hVaMM9hcJRwiQ/T8Ha8x+EahQvJURDFsDwwzAtrEtd0vBpWWA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1764979692; c=relaxed/relaxed; bh=VKJK/1vbn3UQHCzqMMe9+PhGMGn7Zr6PCz5ytRZ8gfY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E/k3RZfHpXfv9vuLXK+qsI5lmfoJdgtl9Kgp4uN7/kJbA2PrYcgoyKpH2kPJ2SJP6gKFbmSQjAx8N7tAp0DDVMyE9ZHtAZ4rCL/thyiTB48y5rHgaXaK2bt5dJlKu2/DcSjSSPd+Ohi5hoVkPVGZR3CuEAlrUFeHw1dEFfe8w6av9rSSEP3znD1if12WOKI+sj4Ntc58QAgdWnQP+vrp64aRqN9kCmqY27uD4bvHeYxJiq04ZjGmjk/073KADLidNJXlvEtT/iwMJ/5XrC7DpouELIACKx8XMlG/KuvTRuHoP+QSGtb7eyf2lgkXMgaC8n9+904vgeTbahxXfoC6+Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=jMarMEwP; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=robh@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=jMarMEwP; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=robh@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4dNT971bC7z2xGg; Sat, 06 Dec 2025 11:08:11 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 06D2A40229; Sat, 6 Dec 2025 00:08:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A97FAC4CEF1; Sat, 6 Dec 2025 00:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764979688; bh=R7HsQDGBjcjXJ81DGGnBQnRnfKReTGHiJmsZwWhTh6Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jMarMEwPMDpFmOeAE6CeeAxtIrqgmlAO3jdHip31Ld+9XQox+jFZKJmkWBNUFYhOY J7S6GEyYhVsXristA3lxrwkN/2idujDP6kV1nOLtAPb/yVsXB+hI7ec0g2XB08s9HP 61xlxNiWckbr4jPP0TM7nN3xlBE0ccvt6NqM548uJdtzfUzxt4sC+lYJzO+Plmk3tr cbS1t+wmnVO6UKA+13SyT//0y2nxOD0zykoPZHAz8bDGvix8dC/AWUMJKbXLkPUMJG qBMq3HaR7ezCM9BRmfIFxBKSnzNziHti3mhlf0Yv2u8M0IRsIym/CMdG+GKtb+9VS8 h2IQo5Tgu0UdQ== Date: Fri, 5 Dec 2025 18:08:06 -0600 From: Rob Herring To: Jacky Chou Cc: Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Linus Walleij , Philipp Zabel , "linux-aspeed@lists.ozlabs.org" , "linux-pci@vger.kernel.org" , "linux-phy@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Andrew Jeffery , "openbmc@lists.ozlabs.org" , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH v6 0/7] Add ASPEED PCIe Root Complex support Message-ID: <20251206000806.GA969079-robh@kernel.org> References: <20251201-upstream_pcie_rc-v6-0-8c8800c56b16@aspeedtech.com> <20251204195355.GA1975043-robh@kernel.org> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 05, 2025 at 12:12:35AM +0000, Jacky Chou wrote: > Hi Rob, > > Thanks for your comments. > > > > Changes in v6: > > > - Refer to pci-cpi-bridge.yaml to update aspeed,ast2600-pcie.yaml and > > > the pcie node of aspeed-g6.dtsi. > > > > Where is this? You don't describe the root port and its properties at all now. > > > > May I confirm whether the pcie@8,0 in aspeed-g6.dtsi is not considered the > root port? From my understanding, that node represents the root port, so I > want to make sure I'm aligning with your expectation before updating the binding. I believe you told me it was the root port. > Could you help clarify how you would like the root port and its properties to > be described in the schema? properties: pcie@8,0: $ref: /schemas/pci/pci-pci-bridge.yaml# unevaluatedProperties: false properties: And then add all the properties you have which are not defined in pci-pci-bridge.yaml (and pci-device.yaml by reference) (i.e. clocks, resets, phys, etc.). Rob