* [PATCH v2 1/5] ARM: dts: aspeed: bletchley: Use generic node names
2025-12-17 2:39 [PATCH v2 0/5] ARM: dts: aspeed: bletchley: Fix dt-schema warnings Cosmo Chou
@ 2025-12-17 2:39 ` Cosmo Chou
2025-12-17 2:39 ` [PATCH v2 2/5] ARM: dts: aspeed: bletchley: Fix SPI GPIO property names Cosmo Chou
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Cosmo Chou @ 2025-12-17 2:39 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, joel, andrew
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
cosmo.chou, Cosmo Chou
Use generic node names to fix dt-schema warnings:
- spi1_gpio: rename to generic "spi" node name
- LED nodes: rename to led-N and move names to label properties
- GPIO key nodes: add "-switch" suffix to node names
Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
---
.../aspeed/aspeed-bmc-facebook-bletchley.dts | 77 ++++++++++++-------
1 file changed, 49 insertions(+), 28 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
index abdb1562115a..9cb01381e482 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
@@ -34,7 +34,7 @@ iio-hwmon {
<&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
};
- spi1_gpio: spi1-gpio {
+ spi1_gpio: spi {
compatible = "spi-gpio";
#address-cells = <1>;
#size-cells = <0>;
@@ -54,7 +54,8 @@ tpm@0 {
front_gpio_leds {
compatible = "gpio-leds";
- sys_log_id {
+ led-0 {
+ label = "sys_log_id";
default-state = "off";
gpios = <&front_leds 0 GPIO_ACTIVE_LOW>;
};
@@ -62,42 +63,50 @@ sys_log_id {
fan_gpio_leds {
compatible = "gpio-leds";
- fan0_blue {
+ led-0 {
+ label = "fan0_blue";
retain-state-shutdown;
default-state = "on";
gpios = <&fan_leds 8 GPIO_ACTIVE_HIGH>;
};
- fan1_blue {
+ led-1 {
+ label = "fan1_blue";
retain-state-shutdown;
default-state = "on";
gpios = <&fan_leds 9 GPIO_ACTIVE_HIGH>;
};
- fan2_blue {
+ led-2 {
+ label = "fan2_blue";
retain-state-shutdown;
default-state = "on";
gpios = <&fan_leds 10 GPIO_ACTIVE_HIGH>;
};
- fan3_blue {
+ led-3 {
+ label = "fan3_blue";
retain-state-shutdown;
default-state = "on";
gpios = <&fan_leds 11 GPIO_ACTIVE_HIGH>;
};
- fan0_amber {
+ led-4 {
+ label = "fan0_amber";
retain-state-shutdown;
default-state = "off";
gpios = <&fan_leds 12 GPIO_ACTIVE_HIGH>;
};
- fan1_amber {
+ led-5 {
+ label = "fan1_amber";
retain-state-shutdown;
default-state = "off";
gpios = <&fan_leds 13 GPIO_ACTIVE_HIGH>;
};
- fan2_amber {
+ led-6 {
+ label = "fan2_amber";
retain-state-shutdown;
default-state = "off";
gpios = <&fan_leds 14 GPIO_ACTIVE_HIGH>;
};
- fan3_amber {
+ led-7 {
+ label = "fan3_amber";
retain-state-shutdown;
default-state = "off";
gpios = <&fan_leds 15 GPIO_ACTIVE_HIGH>;
@@ -106,12 +115,14 @@ fan3_amber {
sled1_gpio_leds {
compatible = "gpio-leds";
- sled1_amber {
+ led-0 {
+ label = "sled1_amber";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled1_leds 0 GPIO_ACTIVE_LOW>;
};
- sled1_blue {
+ led-1 {
+ label = "sled1_blue";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled1_leds 1 GPIO_ACTIVE_LOW>;
@@ -120,12 +131,14 @@ sled1_blue {
sled2_gpio_leds {
compatible = "gpio-leds";
- sled2_amber {
+ led-0 {
+ label = "sled2_amber";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled2_leds 0 GPIO_ACTIVE_LOW>;
};
- sled2_blue {
+ led-1 {
+ label = "sled2_blue";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled2_leds 1 GPIO_ACTIVE_LOW>;
@@ -134,12 +147,14 @@ sled2_blue {
sled3_gpio_leds {
compatible = "gpio-leds";
- sled3_amber {
+ led-0 {
+ label = "sled3_amber";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled3_leds 0 GPIO_ACTIVE_LOW>;
};
- sled3_blue {
+ led-1 {
+ label = "sled3_blue";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled3_leds 1 GPIO_ACTIVE_LOW>;
@@ -148,12 +163,14 @@ sled3_blue {
sled4_gpio_leds {
compatible = "gpio-leds";
- sled4_amber {
+ led-0 {
+ label = "sled4_amber";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled4_leds 0 GPIO_ACTIVE_LOW>;
};
- sled4_blue {
+ led-1 {
+ label = "sled4_blue";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled4_leds 1 GPIO_ACTIVE_LOW>;
@@ -162,12 +179,14 @@ sled4_blue {
sled5_gpio_leds {
compatible = "gpio-leds";
- sled5_amber {
+ led-0 {
+ label = "sled5_amber";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled5_leds 0 GPIO_ACTIVE_LOW>;
};
- sled5_blue {
+ led-1 {
+ label = "sled5_blue";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled5_leds 1 GPIO_ACTIVE_LOW>;
@@ -176,12 +195,14 @@ sled5_blue {
sled6_gpio_leds {
compatible = "gpio-leds";
- sled6_amber {
+ led-0 {
+ label = "sled6_amber";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled6_leds 0 GPIO_ACTIVE_LOW>;
};
- sled6_blue {
+ led-1 {
+ label = "sled6_blue";
retain-state-shutdown;
default-state = "keep";
gpios = <&sled6_leds 1 GPIO_ACTIVE_LOW>;
@@ -191,32 +212,32 @@ sled6_blue {
gpio-keys {
compatible = "gpio-keys";
- presence-sled1 {
+ presence-sled1-switch {
label = "presence-sled1";
gpios = <&gpio0 ASPEED_GPIO(H, 2) GPIO_ACTIVE_LOW>;
linux,code = <ASPEED_GPIO(H, 2)>;
};
- presence-sled2 {
+ presence-sled2-switch {
label = "presence-sled2";
gpios = <&gpio0 ASPEED_GPIO(H, 3) GPIO_ACTIVE_LOW>;
linux,code = <ASPEED_GPIO(H, 3)>;
};
- presence-sled3 {
+ presence-sled3-switch {
label = "presence-sled3";
gpios = <&gpio0 ASPEED_GPIO(H, 4) GPIO_ACTIVE_LOW>;
linux,code = <ASPEED_GPIO(H, 4)>;
};
- presence-sled4 {
+ presence-sled4-switch {
label = "presence-sled4";
gpios = <&gpio0 ASPEED_GPIO(H, 5) GPIO_ACTIVE_LOW>;
linux,code = <ASPEED_GPIO(H, 5)>;
};
- presence-sled5 {
+ presence-sled5-switch {
label = "presence-sled5";
gpios = <&gpio0 ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>;
linux,code = <ASPEED_GPIO(H, 6)>;
};
- presence-sled6 {
+ presence-sled6-switch {
label = "presence-sled6";
gpios = <&gpio0 ASPEED_GPIO(H, 7) GPIO_ACTIVE_LOW>;
linux,code = <ASPEED_GPIO(H, 7)>;
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 2/5] ARM: dts: aspeed: bletchley: Fix SPI GPIO property names
2025-12-17 2:39 [PATCH v2 0/5] ARM: dts: aspeed: bletchley: Fix dt-schema warnings Cosmo Chou
2025-12-17 2:39 ` [PATCH v2 1/5] ARM: dts: aspeed: bletchley: Use generic node names Cosmo Chou
@ 2025-12-17 2:39 ` Cosmo Chou
2025-12-17 2:39 ` [PATCH v2 3/5] ARM: dts: aspeed: bletchley: Remove unused pca9539 properties Cosmo Chou
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Cosmo Chou @ 2025-12-17 2:39 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, joel, andrew
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
cosmo.chou, Cosmo Chou
Update SPI GPIO properties to use "-gpios" suffix:
- gpio-sck -> sck-gpios
- gpio-mosi -> mosi-gpios
- gpio-miso -> miso-gpios
Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
index 9cb01381e482..5919a5046078 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
@@ -39,9 +39,9 @@ spi1_gpio: spi {
#address-cells = <1>;
#size-cells = <0>;
- gpio-sck = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
- gpio-mosi = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
- gpio-miso = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
+ sck-gpios = <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
+ mosi-gpios = <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
+ miso-gpios = <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
num-chipselects = <1>;
cs-gpios = <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_LOW>;
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 3/5] ARM: dts: aspeed: bletchley: Remove unused pca9539 properties
2025-12-17 2:39 [PATCH v2 0/5] ARM: dts: aspeed: bletchley: Fix dt-schema warnings Cosmo Chou
2025-12-17 2:39 ` [PATCH v2 1/5] ARM: dts: aspeed: bletchley: Use generic node names Cosmo Chou
2025-12-17 2:39 ` [PATCH v2 2/5] ARM: dts: aspeed: bletchley: Fix SPI GPIO property names Cosmo Chou
@ 2025-12-17 2:39 ` Cosmo Chou
2025-12-17 2:39 ` [PATCH v2 4/5] ARM: dts: aspeed: bletchley: Remove unused i2c13 property Cosmo Chou
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Cosmo Chou @ 2025-12-17 2:39 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, joel, andrew
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
cosmo.chou, Cosmo Chou
Remove unused #address-cells and #size-cells properties from
pca9539 nodes to fix dt-schema warnings.
Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
---
.../dts/aspeed/aspeed-bmc-facebook-bletchley.dts | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
index 5919a5046078..8df145d2bcfd 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
@@ -373,8 +373,6 @@ sled1_ioexp41: pca9536@41 {
sled1_ioexp: pca9539@76 {
compatible = "nxp,pca9539";
reg = <0x76>;
- #address-cells = <1>;
- #size-cells = <0>;
gpio-controller;
#gpio-cells = <2>;
@@ -462,8 +460,6 @@ sled2_ioexp41: pca9536@41 {
sled2_ioexp: pca9539@76 {
compatible = "nxp,pca9539";
reg = <0x76>;
- #address-cells = <1>;
- #size-cells = <0>;
gpio-controller;
#gpio-cells = <2>;
@@ -551,8 +547,6 @@ sled3_ioexp41: pca9536@41 {
sled3_ioexp: pca9539@76 {
compatible = "nxp,pca9539";
reg = <0x76>;
- #address-cells = <1>;
- #size-cells = <0>;
gpio-controller;
#gpio-cells = <2>;
@@ -640,8 +634,6 @@ sled4_ioexp41: pca9536@41 {
sled4_ioexp: pca9539@76 {
compatible = "nxp,pca9539";
reg = <0x76>;
- #address-cells = <1>;
- #size-cells = <0>;
gpio-controller;
#gpio-cells = <2>;
@@ -729,8 +721,6 @@ sled5_ioexp41: pca9536@41 {
sled5_ioexp: pca9539@76 {
compatible = "nxp,pca9539";
reg = <0x76>;
- #address-cells = <1>;
- #size-cells = <0>;
gpio-controller;
#gpio-cells = <2>;
@@ -818,8 +808,6 @@ sled6_ioexp41: pca9536@41 {
sled6_ioexp: pca9539@76 {
compatible = "nxp,pca9539";
reg = <0x76>;
- #address-cells = <1>;
- #size-cells = <0>;
gpio-controller;
#gpio-cells = <2>;
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 4/5] ARM: dts: aspeed: bletchley: Remove unused i2c13 property
2025-12-17 2:39 [PATCH v2 0/5] ARM: dts: aspeed: bletchley: Fix dt-schema warnings Cosmo Chou
` (2 preceding siblings ...)
2025-12-17 2:39 ` [PATCH v2 3/5] ARM: dts: aspeed: bletchley: Remove unused pca9539 properties Cosmo Chou
@ 2025-12-17 2:39 ` Cosmo Chou
2025-12-17 2:39 ` [PATCH v2 5/5] ARM: dts: aspeed: bletchley: Fix ADC vref property names Cosmo Chou
2025-12-17 8:31 ` [PATCH v2 0/5] ARM: dts: aspeed: bletchley: Fix dt-schema warnings Andrew Jeffery
5 siblings, 0 replies; 7+ messages in thread
From: Cosmo Chou @ 2025-12-17 2:39 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, joel, andrew
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
cosmo.chou, Cosmo Chou
Remove 'aspeed,hw-timeout-ms' property which is not supported by
the driver and causes dt-schema warnings.
Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
index 8df145d2bcfd..123e2d1891f6 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
@@ -962,7 +962,6 @@ fan_leds: pca9552@67 {
&i2c13 {
multi-master;
- aspeed,hw-timeout-ms = <1000>;
status = "okay";
//USB Debug Connector
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2 5/5] ARM: dts: aspeed: bletchley: Fix ADC vref property names
2025-12-17 2:39 [PATCH v2 0/5] ARM: dts: aspeed: bletchley: Fix dt-schema warnings Cosmo Chou
` (3 preceding siblings ...)
2025-12-17 2:39 ` [PATCH v2 4/5] ARM: dts: aspeed: bletchley: Remove unused i2c13 property Cosmo Chou
@ 2025-12-17 2:39 ` Cosmo Chou
2025-12-17 8:31 ` [PATCH v2 0/5] ARM: dts: aspeed: bletchley: Fix dt-schema warnings Andrew Jeffery
5 siblings, 0 replies; 7+ messages in thread
From: Cosmo Chou @ 2025-12-17 2:39 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, joel, andrew
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
cosmo.chou, Cosmo Chou
Replace non-functional 'vref' with 'aspeed,int-vref-microvolt'
using the default 2.5V that the driver was already applying.
Signed-off-by: Cosmo Chou <chou.cosmo@gmail.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
index 123e2d1891f6..7c27bf6bb51d 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts
@@ -1032,7 +1032,7 @@ &gpio0 {
};
&adc0 {
- vref = <1800>;
+ aspeed,int-vref-microvolt = <2500000>;
status = "okay";
pinctrl-names = "default";
@@ -1043,7 +1043,7 @@ &pinctrl_adc4_default &pinctrl_adc5_default
};
&adc1 {
- vref = <2500>;
+ aspeed,int-vref-microvolt = <2500000>;
status = "okay";
pinctrl-names = "default";
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 0/5] ARM: dts: aspeed: bletchley: Fix dt-schema warnings
2025-12-17 2:39 [PATCH v2 0/5] ARM: dts: aspeed: bletchley: Fix dt-schema warnings Cosmo Chou
` (4 preceding siblings ...)
2025-12-17 2:39 ` [PATCH v2 5/5] ARM: dts: aspeed: bletchley: Fix ADC vref property names Cosmo Chou
@ 2025-12-17 8:31 ` Andrew Jeffery
5 siblings, 0 replies; 7+ messages in thread
From: Andrew Jeffery @ 2025-12-17 8:31 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, joel, Cosmo Chou
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
cosmo.chou
On Wed, 17 Dec 2025 10:39:33 +0800, Cosmo Chou wrote:
> This series fixes dt-schema validation warnings by using generic node
> names, correcting GPIO property suffixes, and removing unsupported
> properties. No functional changes.
>
> Changes in v2:
> - Split single patch into 5 separate patches by change type
>
> [...]
Thanks, I've applied this to the BMC tree.
--
Andrew Jeffery <andrew@codeconstruct.com.au>
^ permalink raw reply [flat|nested] 7+ messages in thread