From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67A5CCF45C8 for ; Mon, 12 Jan 2026 20:35:59 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dqkfj56Y6z2xKx; Tue, 13 Jan 2026 07:35:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768250157; cv=none; b=hLohQR/b5q5ccmoMjSmSupQzYkkVlIbrlMrw0SgpKIPmat4Ox3kkWTX8V2Huk52yg5GrW+TOxT+ZYQJSE1XARftyIrArof23fcyoDyXXwwOvdsUCTIUWkP4xWHImbO+vY/ObOIaJOb1rznXjHxQZMTgi3FpiHFjlEeSGyniHpuuhUqnkZ37pyWSHhjFOSo75vOxMUerFYjsiPkeOgbIGZx7Pb9YDZQCjPqHIjdFMyR6Z5A6rrKEyCUS8ttLEk9wyoSVb6lXLCSrUFpWimTEBiUf4eq2l2YNzD8aKk/tGZAw0glCL8QUOOyvnlhg7I7THxRVyj9bkzk3DfPyriT0TiA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768250157; c=relaxed/relaxed; bh=00R2igio6P+jh+vcf3sk1ZVoHu5ik6TDusL7U/wd1cI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H/wd6IQx3Vzxcr8tcjXMrTqTQlzzJFfnrAfjGo/TyhJyIiveZ+doFiNxhZErcJYOArX/jo4JnO2+gVaivTv1I4Fg7L/qMagWZntN63noQdbIjxGFoKjx2eW0oRU1GVxJRoXUKx+eyfEDBqLkzQp3WGaeAcyBydF0CzL4d+tLZj/NWzW5cVdPEwhABmvHoyjVSyUy8NxlBmY83z2mX7ZucmTKj9GzH7LVZf4gIApXjQkG8d9JaZWOlBpj9sCHT3vk0yjWoHxPnr22isML0eFU+C6nxcAXUdAxppD8NDMuW2FJNPPDVGWPfIbfhy/gzUIJgTQrcPMBKQoraSO+D1hZsA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=n0JUJJ29; dkim-atps=neutral; spf=pass (client-ip=198.175.65.17; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=n0JUJJ29; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.intel.com (client-ip=198.175.65.17; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4dqkff5H0sz2xKh; Tue, 13 Jan 2026 07:35:52 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768250156; x=1799786156; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dzIlNxBLNcrWr8IC/y57DQTFAbop0n5nPnrevzaacBI=; b=n0JUJJ29Ed8BdgSqtIRtMveHWBwZiOOPb3Hmc25HxEilwTCEno0O5WCw LvLs6d58ajxM5WBcbFrxjWT8U/f0XkrELbroPxCDVbEW35VEuqzGpt82U lnswd8OueXtZYe7NEMQ+c7MVF/HEviK8AZNNP7CXVtOihqP9cGio5MVMh vnwSrsdkuz+lU6kQSfa5PNG37HcPDxUeLhAvkoOcZdSrbhNMg1J6eQ5Al JeQabYBqJhDoXxdVKMZylhP4PdsAPIJZTXjKx7I7sRe4AR1D/8qgx/ge3 x7wtLelIAjD2yx5SeGgFjU2Tu3r84tAFxo7Z6NcGRbP/lez/8+MxXSl23 A==; X-CSE-ConnectionGUID: Ot/F80u1RZG42UcLjXCVHg== X-CSE-MsgGUID: 9tYcqoz6QeKQGdUDM1Y5dA== X-IronPort-AV: E=McAfee;i="6800,10657,11669"; a="69515890" X-IronPort-AV: E=Sophos;i="6.21,221,1763452800"; d="scan'208";a="69515890" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2026 12:35:51 -0800 X-CSE-ConnectionGUID: Wd9Pd5v0RsaC3tx7hFm2fQ== X-CSE-MsgGUID: aPk0SsUFTRe0eIv2P2Fwzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,221,1763452800"; d="scan'208";a="209262083" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa005.jf.intel.com with ESMTP; 12 Jan 2026 12:35:40 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 6FF4698; Mon, 12 Jan 2026 21:35:37 +0100 (CET) From: Andy Shevchenko To: Mark Brown , Varshini Rajendran , Mikhail Kshevetskiy , AngeloGioacchino Del Regno , Haotian Zhang , Sunny Luo , Janne Grunau , Andy Shevchenko , Martin Blumenstingl , Geert Uytterhoeven , Chen-Yu Tsai , Amelie Delaunay , Chin-Ting Kuo , CL Wang , Patrice Chotard , Heiko Stuebner , William Zhang , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Manikandan Muralidharan , David Lechner , Florian Fainelli , Jonas Gorski , Hang Zhou <929513338@qq.com>, Jun Guo , Philipp Stanner , Charles Keepax , Bartosz Golaszewski , =?UTF-8?q?Beno=C3=AEt=20Monin?= , Shiji Yang , James Clark , Jonathan Marek , Carlos Song , Sakari Ailus , Huacai Chen , Xianwei Zhao , Prajna Rajendra Kumar , Sergio Perez Gonzalez , Qianfeng Rong , Haibo Chen , Gabor Juhos , Md Sadre Alam , Rosen Penev , Marek Szyprowski , Luis de Arquer , Cosmin Tanislav , Tudor Ambarus , Krzysztof Kozlowski , Longbin Li , Kunihiko Hayashi , =?UTF-8?q?Cl=C3=A9ment=20Le=20Goffic?= , Alessandro Grassi , Darshan R , Aaron Kling , Vishwaroop A , Haixu Cui , Darshan Rathod , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev Cc: Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Lorenzo Bianconi , Ray Liu , Sven Peter , Neal Gompa , Joel Stanley , Andrew Jeffery , Ryan Wanner , Michael Hennerich , =?UTF-8?q?Nuno=20S=C3=A1?= , Kamal Dasu , Broadcom internal kernel review list , Ray Jui , Scott Branden , Kursad Oney , Anand Gore , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , David Rhodes , Richard Fitzgerald , Vladimir Oltean , Frank Li , Jean-Marie Verdun , Nick Hawkins , Yang Shen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Lixu Zhang , Yinbo Zhu , Neil Armstrong , Kevin Hilman , Jerome Brunet , Conor Dooley , Daire McNamara , Matthias Brugger , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Han Xu , Yogesh Gaur , Linus Walleij , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Chris Packham , Fabrizio Castro , Andi Shyti , Alim Akhtar , Paul Walmsley , Samuel Holland , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Alain Volmat , Jernej Skrabec , Li-hao Kuo , Masahisa Kojima , Jassi Brar , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Masami Hiramatsu , =?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= , Michal Simek , Max Filippov Subject: [PATCH v2 1/4] spi: Propagate default fwnode to the SPI controller device Date: Mon, 12 Jan 2026 21:21:23 +0100 Message-ID: <20260112203534.4186261-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260112203534.4186261-1-andriy.shevchenko@linux.intel.com> References: <20260112203534.4186261-1-andriy.shevchenko@linux.intel.com> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Most of the SPI controller drivers share the parent's fwnode by explicit assignment. Propagate the default by SPI core, so they may drop that in the code. Only corner cases may require a special treatment and we simply (re)assign the controller's fwnode explicitly (as it's done right now, no changes required for that). Reviewed-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Andy Shevchenko --- drivers/spi/spi-cs42l43.c | 8 ++++++++ drivers/spi/spi.c | 3 +++ 2 files changed, 11 insertions(+) diff --git a/drivers/spi/spi-cs42l43.c b/drivers/spi/spi-cs42l43.c index 4b6b65f450a8..a4a650c8d740 100644 --- a/drivers/spi/spi-cs42l43.c +++ b/drivers/spi/spi-cs42l43.c @@ -371,6 +371,14 @@ static int cs42l43_spi_probe(struct platform_device *pdev) fwnode_property_read_u32(xu_fwnode, "01fa-sidecar-instances", &nsidecars); + /* + * Depending on the value of nsidecars we either create a software node + * or assign an fwnode. We don't want software node to be attached to + * the default one. That's why we need to clear the SPI controller fwnode + * first. + */ + device_set_node(&priv->ctlr->dev, NULL); + if (nsidecars) { struct software_node_ref_args args[] = { SOFTWARE_NODE_REFERENCE(fwnode, 0, GPIO_ACTIVE_LOW), diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index f077ea74e299..b773c297f8b1 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -3072,6 +3072,9 @@ struct spi_controller *__spi_alloc_controller(struct device *dev, else ctlr->dev.class = &spi_controller_class; ctlr->dev.parent = dev; + + device_set_node(&ctlr->dev, dev_fwnode(dev)); + pm_suspend_ignore_children(&ctlr->dev, true); spi_controller_set_devdata(ctlr, (void *)ctlr + ctlr_size); -- 2.50.1