[PATCH v2 1/2] dt-bindings: clock: ast2600: Add reset definition for video

[PATCH v2 1/2] dt-bindings: clock: ast2600: Add reset definition for video

[Haiyue Wang]

Add ASPEED_RESET_VIDEO reset definition to the ast2600-clock binding
header. It is required for proper reset control of the video on the
AST2600 SoC for aspeed-video driver.

Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
Signed-off-by: Haiyue Wang <haiyuewa@163.com>
---
v2:
  - Fix checkpatch.pl warning, and send dt-bindings as single patch as
    the submitting-patches guide.
v1: https://lore.kernel.org/all/20260227123837.70079-1-haiyuewa@163.com/
---
 include/dt-bindings/clock/ast2600-clock.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
index f60fff261130..7b9b80c38a8b 100644
--- a/include/dt-bindings/clock/ast2600-clock.h
+++ b/include/dt-bindings/clock/ast2600-clock.h
@@ -124,6 +124,7 @@
 #define ASPEED_RESET_PCIE_RC_OEN	18
 #define ASPEED_RESET_MAC2		12
 #define ASPEED_RESET_MAC1		11
+#define ASPEED_RESET_VIDEO		6
 #define ASPEED_RESET_PCI_DP		5
 #define ASPEED_RESET_HACE		4
 #define ASPEED_RESET_AHB		1
-- 
2.53.0

[PATCH v2 2/2] ARM: dts: aspeed: add 'resets' to video node

[Haiyue Wang]

The aspeed video (be compatible for ast2400, ast2500, ast2600) now needs
the reset DTS handle specified, otherwise it will fail to load:

[    4.809494] aspeed-video 1e700000.video: irq 57
[    4.809977] aspeed-video 1e700000.video: Unable to get reset
[    4.810341] aspeed-video 1e700000.video: probe with driver aspeed-video failed with error -2

Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
Signed-off-by: Haiyue Wang <haiyuewa@163.com>
---
 arch/arm/boot/dts/aspeed/aspeed-g4.dtsi | 1 +
 arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 1 +
 arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 1 +
 3 files changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g4.dtsi
index c3d4d916c69b..1547e28d77e2 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed/aspeed-g4.dtsi
@@ -242,6 +242,7 @@ video: video@1e700000 {
 					 <&syscon ASPEED_CLK_GATE_ECLK>;
 				clock-names = "vclk", "eclk";
 				interrupts = <7>;
+				resets = <&syscon ASPEED_RESET_VIDEO>;
 				status = "disabled";
 			};
 
diff --git a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
index 39500bdb4747..793570ca2518 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
@@ -296,6 +296,7 @@ video: video@1e700000 {
 					 <&syscon ASPEED_CLK_GATE_ECLK>;
 				clock-names = "vclk", "eclk";
 				interrupts = <7>;
+				resets = <&syscon ASPEED_RESET_VIDEO>;
 				status = "disabled";
 			};
 
diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
index 189bc3bbb47c..3adf48987a17 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
@@ -428,6 +428,7 @@ video: video@1e700000 {
 					 <&syscon ASPEED_CLK_GATE_ECLK>;
 				clock-names = "vclk", "eclk";
 				interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+				resets = <&syscon ASPEED_RESET_VIDEO>;
 				status = "disabled";
 			};
 
-- 
2.53.0

Re: [PATCH v2 1/2] dt-bindings: clock: ast2600: Add reset definition for video

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

On Fri, Feb 27, 2026 at 11:13:14PM +0800, Haiyue Wang wrote:
> Add ASPEED_RESET_VIDEO reset definition to the ast2600-clock binding
> header. It is required for proper reset control of the video on the
> AST2600 SoC for aspeed-video driver.
> 
> Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")

How can a binding change be a fix for a driver one?

> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
> ---
> v2:
>   - Fix checkpatch.pl warning, and send dt-bindings as single patch as
>     the submitting-patches guide.
> v1: https://lore.kernel.org/all/20260227123837.70079-1-haiyuewa@163.com/
> ---
>  include/dt-bindings/clock/ast2600-clock.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> index f60fff261130..7b9b80c38a8b 100644
> --- a/include/dt-bindings/clock/ast2600-clock.h
> +++ b/include/dt-bindings/clock/ast2600-clock.h
> @@ -124,6 +124,7 @@
>  #define ASPEED_RESET_PCIE_RC_OEN	18
>  #define ASPEED_RESET_MAC2		12
>  #define ASPEED_RESET_MAC1		11
> +#define ASPEED_RESET_VIDEO		6
>  #define ASPEED_RESET_PCI_DP		5
>  #define ASPEED_RESET_HACE		4
>  #define ASPEED_RESET_AHB		1
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] dt-bindings: clock: ast2600: Add reset definition for video

[Haiyue Wang]

On 2/28/2026 1:33 AM, Conor Dooley wrote:
> On Fri, Feb 27, 2026 at 11:13:14PM +0800, Haiyue Wang wrote:
>> Add ASPEED_RESET_VIDEO reset definition to the ast2600-clock binding
>> header. It is required for proper reset control of the video on the
>> AST2600 SoC for aspeed-video driver.
>>
>> Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
> 
> How can a binding change be a fix for a driver one?
> 

https://git.kernel.org/torvalds/c/9897831de614

If squashed into one patch as v1 does, it will have patch format warning:
./scripts/checkpatch.pl ...patch
WARNING: DT binding docs and includes should be a separate patch. See: 
Documentation/devicetree/bindings/submitting-patches.rst

>> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
>> ---
>> v2:
>>    - Fix checkpatch.pl warning, and send dt-bindings as single patch as
>>      the submitting-patches guide.
>> v1: https://lore.kernel.org/all/20260227123837.70079-1-haiyuewa@163.com/
>> ---
>>   include/dt-bindings/clock/ast2600-clock.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
>> index f60fff261130..7b9b80c38a8b 100644
>> --- a/include/dt-bindings/clock/ast2600-clock.h
>> +++ b/include/dt-bindings/clock/ast2600-clock.h
>> @@ -124,6 +124,7 @@
>>   #define ASPEED_RESET_PCIE_RC_OEN	18
>>   #define ASPEED_RESET_MAC2		12
>>   #define ASPEED_RESET_MAC1		11
>> +#define ASPEED_RESET_VIDEO		6
>>   #define ASPEED_RESET_PCI_DP		5
>>   #define ASPEED_RESET_HACE		4
>>   #define ASPEED_RESET_AHB		1
>> -- 
>> 2.53.0
>>

Re: [PATCH v2 1/2] dt-bindings: clock: ast2600: Add reset definition for video

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2130 bytes --]

On Sat, Feb 28, 2026 at 09:20:56AM +0800, Haiyue Wang wrote:
> 
> 
> On 2/28/2026 1:33 AM, Conor Dooley wrote:
> > On Fri, Feb 27, 2026 at 11:13:14PM +0800, Haiyue Wang wrote:
> > > Add ASPEED_RESET_VIDEO reset definition to the ast2600-clock binding
> > > header. It is required for proper reset control of the video on the
> > > AST2600 SoC for aspeed-video driver.
> > > 
> > > Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
> > 
> > How can a binding change be a fix for a driver one?
> > 
> 
> https://git.kernel.org/torvalds/c/9897831de614
> 
> If squashed into one patch as v1 does, it will have patch format warning:
> ./scripts/checkpatch.pl ...patch
> WARNING: DT binding docs and includes should be a separate patch. See:
> Documentation/devicetree/bindings/submitting-patches.rst

Adding a fixes tag implies that the change you have here should have
been done in the patch you're citing. If you had done it in that patch,
you would get a checkpatch warning there too. This is a separate change
that is needed for your dts changes, but is not a fix for the driver
change.

> 
> > > Signed-off-by: Haiyue Wang <haiyuewa@163.com>
> > > ---
> > > v2:
> > >    - Fix checkpatch.pl warning, and send dt-bindings as single patch as
> > >      the submitting-patches guide.
> > > v1: https://lore.kernel.org/all/20260227123837.70079-1-haiyuewa@163.com/
> > > ---
> > >   include/dt-bindings/clock/ast2600-clock.h | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> > > index f60fff261130..7b9b80c38a8b 100644
> > > --- a/include/dt-bindings/clock/ast2600-clock.h
> > > +++ b/include/dt-bindings/clock/ast2600-clock.h
> > > @@ -124,6 +124,7 @@
> > >   #define ASPEED_RESET_PCIE_RC_OEN	18
> > >   #define ASPEED_RESET_MAC2		12
> > >   #define ASPEED_RESET_MAC1		11
> > > +#define ASPEED_RESET_VIDEO		6
> > >   #define ASPEED_RESET_PCI_DP		5
> > >   #define ASPEED_RESET_HACE		4
> > >   #define ASPEED_RESET_AHB		1
> > > -- 
> > > 2.53.0
> > > 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] dt-bindings: clock: ast2600: Add reset definition for video

[Haiyue Wang]

On 2/28/2026 8:16 PM, Conor Dooley wrote:
> On Sat, Feb 28, 2026 at 09:20:56AM +0800, Haiyue Wang wrote:
>>
>>
>> On 2/28/2026 1:33 AM, Conor Dooley wrote:
>>> On Fri, Feb 27, 2026 at 11:13:14PM +0800, Haiyue Wang wrote:
>>>> Add ASPEED_RESET_VIDEO reset definition to the ast2600-clock binding
>>>> header. It is required for proper reset control of the video on the
>>>> AST2600 SoC for aspeed-video driver.
>>>>
>>>> Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
>>>
>>> How can a binding change be a fix for a driver one?
>>>
>>
>> https://git.kernel.org/torvalds/c/9897831de614
>>
>> If squashed into one patch as v1 does, it will have patch format warning:
>> ./scripts/checkpatch.pl ...patch
>> WARNING: DT binding docs and includes should be a separate patch. See:
>> Documentation/devicetree/bindings/submitting-patches.rst
> 
> Adding a fixes tag implies that the change you have here should have
> been done in the patch you're citing. If you had done it in that patch,
> you would get a checkpatch warning there too. This is a separate change
> that is needed for your dts changes, but is not a fix for the driver
> change.
> 

 From this point of view, yes, a little strange to add "Fixes".

Drop this tag in V3, please review.

>>
>>>> Signed-off-by: Haiyue Wang <haiyuewa@163.com>
>>>> ---
>>>> v2:
>>>>     - Fix checkpatch.pl warning, and send dt-bindings as single patch as
>>>>       the submitting-patches guide.
>>>> v1: https://lore.kernel.org/all/20260227123837.70079-1-haiyuewa@163.com/
>>>> ---
>>>>    include/dt-bindings/clock/ast2600-clock.h | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
>>>> index f60fff261130..7b9b80c38a8b 100644
>>>> --- a/include/dt-bindings/clock/ast2600-clock.h
>>>> +++ b/include/dt-bindings/clock/ast2600-clock.h
>>>> @@ -124,6 +124,7 @@
>>>>    #define ASPEED_RESET_PCIE_RC_OEN	18
>>>>    #define ASPEED_RESET_MAC2		12
>>>>    #define ASPEED_RESET_MAC1		11
>>>> +#define ASPEED_RESET_VIDEO		6
>>>>    #define ASPEED_RESET_PCI_DP		5
>>>>    #define ASPEED_RESET_HACE		4
>>>>    #define ASPEED_RESET_AHB		1
>>>> -- 
>>>> 2.53.0
>>>>
>>