* [PATCH v3] iio: adc: aspeed: clear reference voltage bits before configuring vref
@ 2026-03-03 2:38 Billy Tsai
2026-03-07 13:28 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Billy Tsai @ 2026-03-03 2:38 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Joel Stanley, Andrew Jeffery
Cc: Jonathan Cameron, linux-iio, linux-arm-kernel, linux-aspeed,
linux-kernel, Billy Tsai
Ensures the reference voltage bits are cleared in the ADC engine
control register before configuring the voltage reference. This
avoids potential misconfigurations caused by residual bits.
Fixes: 1b5ceb55fec2 ("iio: adc: aspeed: Support ast2600 adc.")
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
Changes in v3:
- Added the missing Fixes: tag
Changes in v2:
- Remove Gerrit Change-Id's
---
drivers/iio/adc/aspeed_adc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
index 4be44c524b4d..83a9885b9ae4 100644
--- a/drivers/iio/adc/aspeed_adc.c
+++ b/drivers/iio/adc/aspeed_adc.c
@@ -415,6 +415,7 @@ static int aspeed_adc_vref_config(struct iio_dev *indio_dev)
}
adc_engine_control_reg_val =
readl(data->base + ASPEED_REG_ENGINE_CONTROL);
+ adc_engine_control_reg_val &= ~ASPEED_ADC_REF_VOLTAGE;
ret = devm_regulator_get_enable_read_voltage(data->dev, "vref");
if (ret < 0 && ret != -ENODEV)
---
base-commit: af4e9ef3d78420feb8fe58cd9a1ab80c501b3c08
change-id: 20260303-adc-47e5bfdf89c9
Best regards,
--
Billy Tsai <billy_tsai@aspeedtech.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v3] iio: adc: aspeed: clear reference voltage bits before configuring vref
2026-03-03 2:38 [PATCH v3] iio: adc: aspeed: clear reference voltage bits before configuring vref Billy Tsai
@ 2026-03-07 13:28 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2026-03-07 13:28 UTC (permalink / raw)
To: Billy Tsai
Cc: David Lechner, Nuno Sá, Andy Shevchenko, Joel Stanley,
Andrew Jeffery, Jonathan Cameron, linux-iio, linux-arm-kernel,
linux-aspeed, linux-kernel
On Tue, 3 Mar 2026 10:38:26 +0800
Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> Ensures the reference voltage bits are cleared in the ADC engine
> control register before configuring the voltage reference. This
> avoids potential misconfigurations caused by residual bits.
>
> Fixes: 1b5ceb55fec2 ("iio: adc: aspeed: Support ast2600 adc.")
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> ---
> Changes in v3:
> - Added the missing Fixes: tag
>
> Changes in v2:
> - Remove Gerrit Change-Id's
> ---
> drivers/iio/adc/aspeed_adc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
> index 4be44c524b4d..83a9885b9ae4 100644
> --- a/drivers/iio/adc/aspeed_adc.c
> +++ b/drivers/iio/adc/aspeed_adc.c
> @@ -415,6 +415,7 @@ static int aspeed_adc_vref_config(struct iio_dev *indio_dev)
> }
> adc_engine_control_reg_val =
> readl(data->base + ASPEED_REG_ENGINE_CONTROL);
> + adc_engine_control_reg_val &= ~ASPEED_ADC_REF_VOLTAGE;
>
> ret = devm_regulator_get_enable_read_voltage(data->dev, "vref");
> if (ret < 0 && ret != -ENODEV)
>
> ---
> base-commit: af4e9ef3d78420feb8fe58cd9a1ab80c501b3c08
> change-id: 20260303-adc-47e5bfdf89c9
>
> Best regards,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-07 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-03 2:38 [PATCH v3] iio: adc: aspeed: clear reference voltage bits before configuring vref Billy Tsai
2026-03-07 13:28 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox