* [PATCH] ARM: dts: aspeed: yosemite5: Add MP5998 power monitor
@ 2026-03-05 8:46 Daniel Hsu
2026-03-26 5:35 ` Andrew Jeffery
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Hsu @ 2026-03-05 8:46 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, joel, andrew
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
Daniel Hsu
Add the MP5998 power monitor device on I2C bus with address 0x46
for the Yosemite5 platform.
This allows the hwmon driver to probe the device and expose the
power monitoring telemetry to userspace.
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
index 2486981f3d6b..6287f80d70d9 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
@@ -422,6 +422,11 @@ power-sensor@45 {
shunt-resistor = <1000>;
};
+ power-monitor@46 {
+ compatible = "mps,mp5998";
+ reg = <0x46>;
+ };
+
power-monitor@47 {
compatible = "ti,tps25990";
reg = <0x47>;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: dts: aspeed: yosemite5: Add MP5998 power monitor
2026-03-05 8:46 [PATCH] ARM: dts: aspeed: yosemite5: Add MP5998 power monitor Daniel Hsu
@ 2026-03-26 5:35 ` Andrew Jeffery
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jeffery @ 2026-03-26 5:35 UTC (permalink / raw)
To: Daniel Hsu, robh, krzk+dt, conor+dt, joel
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel,
Daniel Hsu
Hi Daniel,
On Thu, 2026-03-05 at 16:46 +0800, Daniel Hsu wrote:
> Add the MP5998 power monitor device on I2C bus with address 0x46
> for the Yosemite5 platform.
I would rather you describe the purpose of the power monitoring. Why is
this instance of an MP5998 necessary in the system design? The address
of the sensor is evident from the details in the patch and isn't
necessary to describe here.
>
> This allows the hwmon driver to probe the device and expose the
> power monitoring telemetry to userspace.
I would prefer you reword or remove this sentence. The purpose of the
devicetree is to describe the hardware. What the firmware/kernel
chooses to do with that information is a separate problem.
Andrew
>
> Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-
> yosemite5.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-
> yosemite5.dts
> index 2486981f3d6b..6287f80d70d9 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite5.dts
> @@ -422,6 +422,11 @@ power-sensor@45 {
> shunt-resistor = <1000>;
> };
>
> + power-monitor@46 {
> + compatible = "mps,mp5998";
> + reg = <0x46>;
> + };
> +
> power-monitor@47 {
> compatible = "ti,tps25990";
> reg = <0x47>;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-26 5:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-05 8:46 [PATCH] ARM: dts: aspeed: yosemite5: Add MP5998 power monitor Daniel Hsu
2026-03-26 5:35 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox