From: Billy Tsai <billy_tsai@aspeedtech.com>
To: Guenter Roeck <linux@roeck-us.net>, Joel Stanley <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>
Cc: <linux-hwmon@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
Billy Tsai <billy_tsai@aspeedtech.com>
Subject: [PATCH] hwmon: (aspeed-g6-pwm-tach): fix driver data handling in probe/remove
Date: Fri, 6 Mar 2026 14:44:31 +0800 [thread overview]
Message-ID: <20260306-pwm_fixes-v1-1-e8ede6fbaf47@aspeedtech.com> (raw)
Ensure proper association of driver data by setting and retrieving
the platform device's driver data during probe and remove.
Fixes: 7e1449cd15d1 ("hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED g6 PWM/Fan tach")
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
drivers/hwmon/aspeed-g6-pwm-tach.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/aspeed-g6-pwm-tach.c b/drivers/hwmon/aspeed-g6-pwm-tach.c
index 44e1ecba205d..0c03d272279a 100644
--- a/drivers/hwmon/aspeed-g6-pwm-tach.c
+++ b/drivers/hwmon/aspeed-g6-pwm-tach.c
@@ -490,6 +490,7 @@ static int aspeed_pwm_tach_probe(struct platform_device *pdev)
if (IS_ERR(chip))
return PTR_ERR(chip);
+ platform_set_drvdata(pdev, chip);
pwmchip_set_drvdata(chip, priv);
chip->ops = &aspeed_pwm_ops;
@@ -519,7 +520,8 @@ static int aspeed_pwm_tach_probe(struct platform_device *pdev)
static void aspeed_pwm_tach_remove(struct platform_device *pdev)
{
- struct aspeed_pwm_tach_data *priv = platform_get_drvdata(pdev);
+ struct pwm_chip *chip = platform_get_drvdata(pdev);
+ struct aspeed_pwm_tach_data *priv = aspeed_pwm_chip_to_data(chip);
reset_control_assert(priv->reset);
}
---
base-commit: af4e9ef3d78420feb8fe58cd9a1ab80c501b3c08
change-id: 20260306-pwm_fixes-7982ad548f07
Best regards,
--
Billy Tsai <billy_tsai@aspeedtech.com>
next reply other threads:[~2026-03-06 6:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 6:44 Billy Tsai [this message]
2026-03-06 15:22 ` [PATCH] hwmon: (aspeed-g6-pwm-tach): fix driver data handling in probe/remove Guenter Roeck
2026-03-06 16:13 ` Guenter Roeck
2026-03-09 1:40 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306-pwm_fixes-v1-1-e8ede6fbaf47@aspeedtech.com \
--to=billy_tsai@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox