[PATCH v2 0/2] Add AST2700 support for aspeed sdhci

[PATCH v2 0/2] Add AST2700 support for aspeed sdhci

[Ryan Chen]

This series add aspeed sdhci support for AST2700. The AST2700 sdhci
requires an reset. This series updates the binding and driver to
support reset requirements.

Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
---
Changes in v2:
- 1/2 use items for ast2700 compatible.
- 2/2 use devm_reset_control_get_optional_exclusive_deasserted for
  reset.
- Link to v1: https://lore.kernel.org/r/20260313-sdhci-v1-0-91cea19c8a67@aspeedtech.com

---
Ryan Chen (2):
      mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles
      mmc: sdhci-of-aspeed: Handle optional controller reset

 .../devicetree/bindings/mmc/aspeed,sdhci.yaml      | 39 +++++++++++++++++-----
 drivers/mmc/host/sdhci-of-aspeed.c                 |  6 ++++
 2 files changed, 37 insertions(+), 8 deletions(-)
---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260313-sdhci-269d319fdbde

Best regards,
-- 
Ryan Chen <ryan_chen@aspeedtech.com>

[PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles

[Ryan Chen]

Describe AST2700 as compatible with the existing AST2600 SD controller
and SDHCI bindings by requiring fallback compatibles in the device tree.

Also require `resets` on the AST2700 SD controller node.

Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
---
Changes in v2:
- add missing blank line
- modify ast2700 compatible items const
---
 .../devicetree/bindings/mmc/aspeed,sdhci.yaml      | 39 +++++++++++++++++-----
 1 file changed, 31 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
index d24950ccea95..9c8e068964a1 100644
--- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
@@ -22,10 +22,14 @@ description: |+
 
 properties:
   compatible:
-    enum:
-      - aspeed,ast2400-sd-controller
-      - aspeed,ast2500-sd-controller
-      - aspeed,ast2600-sd-controller
+    oneOf:
+      - const: aspeed,ast2400-sd-controller
+      - const: aspeed,ast2500-sd-controller
+      - const: aspeed,ast2600-sd-controller
+      - items:
+          - const: aspeed,ast2700-sd-controller
+          - const: aspeed,ast2600-sd-controller
+
   reg:
     maxItems: 1
     description: Common configuration registers
@@ -38,6 +42,21 @@ properties:
     maxItems: 1
     description: The SD/SDIO controller clock gate
 
+  resets:
+    maxItems: 1
+
+if:
+  properties:
+    compatible:
+      contains:
+        const: aspeed,ast2700-sd-controller
+then:
+  required:
+    - resets
+else:
+  properties:
+    resets: false
+
 patternProperties:
   "^sdhci@[0-9a-f]+$":
     type: object
@@ -46,10 +65,14 @@ patternProperties:
 
     properties:
       compatible:
-        enum:
-          - aspeed,ast2400-sdhci
-          - aspeed,ast2500-sdhci
-          - aspeed,ast2600-sdhci
+        oneOf:
+          - const: aspeed,ast2400-sdhci
+          - const: aspeed,ast2500-sdhci
+          - const: aspeed,ast2600-sdhci
+          - items:
+              - const: aspeed,ast2700-sdhci
+              - const: aspeed,ast2600-sdhci
+
       reg:
         maxItems: 1
         description: The SDHCI registers

-- 
2.34.1

Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles

[Krzysztof Kozlowski]

On Tue, Mar 17, 2026 at 01:56:42PM +0800, Ryan Chen wrote:
> Describe AST2700 as compatible with the existing AST2600 SD controller
> and SDHCI bindings by requiring fallback compatibles in the device tree.
> 
> Also require `resets` on the AST2700 SD controller node.
> 
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
> Changes in v2:
> - add missing blank line
> - modify ast2700 compatible items const

Why?

> ---
>  .../devicetree/bindings/mmc/aspeed,sdhci.yaml      | 39 +++++++++++++++++-----
>  1 file changed, 31 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> index d24950ccea95..9c8e068964a1 100644
> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> @@ -22,10 +22,14 @@ description: |+
>  
>  properties:
>    compatible:
> -    enum:
> -      - aspeed,ast2400-sd-controller
> -      - aspeed,ast2500-sd-controller
> -      - aspeed,ast2600-sd-controller
> +    oneOf:
> +      - const: aspeed,ast2400-sd-controller
> +      - const: aspeed,ast2500-sd-controller
> +      - const: aspeed,ast2600-sd-controller

No, previous code was correct.

Is this some microslop LLM product? I questioned style last time and now
we got random changes without explanation.

Please confirm - did you use any LLM microslop tools to create this
patch? Please also confirm - who internally reviewed this patch before
posting?

Best regards,
Krzysztof

RE: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles

[Ryan Chen]

> Subject: Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700
> fallback compatibles
> 
> On Tue, Mar 17, 2026 at 01:56:42PM +0800, Ryan Chen wrote:
> > Describe AST2700 as compatible with the existing AST2600 SD controller
> > and SDHCI bindings by requiring fallback compatibles in the device tree.
> >
> > Also require `resets` on the AST2700 SD controller node.
> >
> > Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> > ---
> > Changes in v2:
> > - add missing blank line
> > - modify ast2700 compatible items const
> 
> Why?
> 
> > ---
> >  .../devicetree/bindings/mmc/aspeed,sdhci.yaml      | 39
> +++++++++++++++++-----
> >  1 file changed, 31 insertions(+), 8 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > index d24950ccea95..9c8e068964a1 100644
> > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > @@ -22,10 +22,14 @@ description: |+
> >
> >  properties:
> >    compatible:
> > -    enum:
> > -      - aspeed,ast2400-sd-controller
> > -      - aspeed,ast2500-sd-controller
> > -      - aspeed,ast2600-sd-controller
> > +    oneOf:
> > +      - const: aspeed,ast2400-sd-controller
> > +      - const: aspeed,ast2500-sd-controller
> > +      - const: aspeed,ast2600-sd-controller
> 
> No, previous code was correct.
> 
> Is this some microslop LLM product? I questioned style last time and now we
> got random changes without explanation.
> 
> Please confirm - did you use any LLM microslop tools to create this patch?
No I create it with B4. And commit each by each, I don't use LLM to porting this.

> Please also confirm - who internally reviewed this patch before posting?
I port this and do test in my side and confirm it.


In https://lore.kernel.org/all/20260314-flat-topaz-peacock-440a9c@quoll/#t 
You request drop driver compatible; 
Base on your instruction, So I do my study in Linux.
Use following to do compatible. Not add driver compatible string.
https://lore.kernel.org/all/TY2PPF5CB9A1BE642DFDE4862B40BBAA1DBF240A@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com/
That is my follow up porting, not use LLM.

Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles

[Krzysztof Kozlowski]

On 18/03/2026 09:09, Ryan Chen wrote:
>> Subject: Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700
>> fallback compatibles
>>
>> On Tue, Mar 17, 2026 at 01:56:42PM +0800, Ryan Chen wrote:
>>> Describe AST2700 as compatible with the existing AST2600 SD controller
>>> and SDHCI bindings by requiring fallback compatibles in the device tree.
>>>
>>> Also require `resets` on the AST2700 SD controller node.
>>>
>>> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
>>> ---
>>> Changes in v2:
>>> - add missing blank line
>>> - modify ast2700 compatible items const
>>
>> Why?
>>
>>> ---
>>>  .../devicetree/bindings/mmc/aspeed,sdhci.yaml      | 39
>> +++++++++++++++++-----
>>>  1 file changed, 31 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
>>> b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
>>> index d24950ccea95..9c8e068964a1 100644
>>> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
>>> @@ -22,10 +22,14 @@ description: |+
>>>
>>>  properties:
>>>    compatible:
>>> -    enum:
>>> -      - aspeed,ast2400-sd-controller
>>> -      - aspeed,ast2500-sd-controller
>>> -      - aspeed,ast2600-sd-controller
>>> +    oneOf:
>>> +      - const: aspeed,ast2400-sd-controller
>>> +      - const: aspeed,ast2500-sd-controller
>>> +      - const: aspeed,ast2600-sd-controller
>>
>> No, previous code was correct.
>>
>> Is this some microslop LLM product? I questioned style last time and now we
>> got random changes without explanation.
>>
>> Please confirm - did you use any LLM microslop tools to create this patch?
> No I create it with B4. And commit each by each, I don't use LLM to porting this.
> 
>> Please also confirm - who internally reviewed this patch before posting?
> I port this and do test in my side and confirm it.
> 
> 
> In https://lore.kernel.org/all/20260314-flat-topaz-peacock-440a9c@quoll/#t 
> You request drop driver compatible; 
> Base on your instruction, So I do my study in Linux.
> Use following to do compatible. Not add driver compatible string.

Replacing enum into list of const is not related/relevant to what you
wanted to achieve.

Best regards,
Krzysztof

RE: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles

[Ryan Chen]

> Subject: Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700
> fallback compatibles
> 
> On 18/03/2026 09:09, Ryan Chen wrote:
> >> Subject: Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add
> >> AST2700 fallback compatibles
> >>
> >> On Tue, Mar 17, 2026 at 01:56:42PM +0800, Ryan Chen wrote:
> >>> Describe AST2700 as compatible with the existing AST2600 SD
> >>> controller and SDHCI bindings by requiring fallback compatibles in the
> device tree.
> >>>
> >>> Also require `resets` on the AST2700 SD controller node.
> >>>
> >>> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> >>> ---
> >>> Changes in v2:
> >>> - add missing blank line
> >>> - modify ast2700 compatible items const
> >>
> >> Why?
> >>
> >>> ---
> >>>  .../devicetree/bindings/mmc/aspeed,sdhci.yaml      | 39
> >> +++++++++++++++++-----
> >>>  1 file changed, 31 insertions(+), 8 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> >>> b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> >>> index d24950ccea95..9c8e068964a1 100644
> >>> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> >>> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> >>> @@ -22,10 +22,14 @@ description: |+
> >>>
> >>>  properties:
> >>>    compatible:
> >>> -    enum:
> >>> -      - aspeed,ast2400-sd-controller
> >>> -      - aspeed,ast2500-sd-controller
> >>> -      - aspeed,ast2600-sd-controller
> >>> +    oneOf:
> >>> +      - const: aspeed,ast2400-sd-controller
> >>> +      - const: aspeed,ast2500-sd-controller
> >>> +      - const: aspeed,ast2600-sd-controller
> >>
> >> No, previous code was correct.
> >>
> >> Is this some microslop LLM product? I questioned style last time and
> >> now we got random changes without explanation.
> >>
> >> Please confirm - did you use any LLM microslop tools to create this patch?
> > No I create it with B4. And commit each by each, I don't use LLM to porting
> this.
> >
> >> Please also confirm - who internally reviewed this patch before posting?
> > I port this and do test in my side and confirm it.
> >
> >
> > In
> > https://lore.kernel.org/all/20260314-flat-topaz-peacock-440a9c@quoll/#
> > t
> > You request drop driver compatible;
> > Base on your instruction, So I do my study in Linux.
> > Use following to do compatible. Not add driver compatible string.
> 
> Replacing enum into list of const is not related/relevant to what you wanted to
> achieve.
Thanks your feedback, I do my homework. Do you mean following modify ?

properties:
  compatible:
    oneOf:
add oneOf Keep following enum 
      - enum:
          - aspeed,ast2400-sdhci
          - aspeed,ast2500-sdhci
          - aspeed,ast2600-sdhci
And add following items 
      - items:
          - const: aspeed,ast2700-sdhci
          - const: aspeed,ast2600-sdhci

RE: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles

[Ryan Chen]

> Subject: RE: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700
> fallback compatibles
> 
> > Subject: Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add
> > AST2700 fallback compatibles
> >
> > On 18/03/2026 09:09, Ryan Chen wrote:
> > >> Subject: Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add
> > >> AST2700 fallback compatibles
> > >>
> > >> On Tue, Mar 17, 2026 at 01:56:42PM +0800, Ryan Chen wrote:
> > >>> Describe AST2700 as compatible with the existing AST2600 SD
> > >>> controller and SDHCI bindings by requiring fallback compatibles in
> > >>> the
> > device tree.
> > >>>
> > >>> Also require `resets` on the AST2700 SD controller node.
> > >>>
> > >>> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> > >>> ---
> > >>> Changes in v2:
> > >>> - add missing blank line
> > >>> - modify ast2700 compatible items const
> > >>
> > >> Why?
> > >>
> > >>> ---
> > >>>  .../devicetree/bindings/mmc/aspeed,sdhci.yaml      | 39
> > >> +++++++++++++++++-----
> > >>>  1 file changed, 31 insertions(+), 8 deletions(-)
> > >>>
> > >>> diff --git
> > >>> a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > >>> b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > >>> index d24950ccea95..9c8e068964a1 100644
> > >>> --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > >>> +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
> > >>> @@ -22,10 +22,14 @@ description: |+
> > >>>
> > >>>  properties:
> > >>>    compatible:
> > >>> -    enum:
> > >>> -      - aspeed,ast2400-sd-controller
> > >>> -      - aspeed,ast2500-sd-controller
> > >>> -      - aspeed,ast2600-sd-controller
> > >>> +    oneOf:
> > >>> +      - const: aspeed,ast2400-sd-controller
> > >>> +      - const: aspeed,ast2500-sd-controller
> > >>> +      - const: aspeed,ast2600-sd-controller
> > >>
> > >> No, previous code was correct.
> > >>
> > >> Is this some microslop LLM product? I questioned style last time
> > >> and now we got random changes without explanation.
> > >>
> > >> Please confirm - did you use any LLM microslop tools to create this patch?
> > > No I create it with B4. And commit each by each, I don't use LLM to
> > > porting
> > this.
> > >
> > >> Please also confirm - who internally reviewed this patch before posting?
> > > I port this and do test in my side and confirm it.
> > >
> > >
> > > In
> > > https://lore.kernel.org/all/20260314-flat-topaz-peacock-440a9c@quoll
> > > /#
> > > t
> > > You request drop driver compatible;
> > > Base on your instruction, So I do my study in Linux.
> > > Use following to do compatible. Not add driver compatible string.
> >
> > Replacing enum into list of const is not related/relevant to what you
> > wanted to achieve.
> Thanks your feedback, I do my homework. Do you mean following modify ?
> 
> properties:
>   compatible:
>     oneOf:
> add oneOf Keep following enum
>       - enum:
>           - aspeed,ast2400-sdhci
>           - aspeed,ast2500-sdhci
>           - aspeed,ast2600-sdhci
> And add following items
>       - items:
>           - const: aspeed,ast2700-sdhci
>           - const: aspeed,ast2600-sdhci
Hello Krzysztof,
I review https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/example-schema.yaml?h=v7.0-rc1
I will do following modify
-    enum:
-      - aspeed,ast2400-sd-controller
-      - aspeed,ast2500-sd-controller
-      - aspeed,ast2600-sd-controller
+    oneOf:
+      - items:
+          - enum:
+              - aspeed,ast2400-sd-controller
+              - aspeed,ast2500-sd-controller
+              - aspeed,ast2600-sd-controller
+      - items:
+          - const: aspeed,ast2700-sd-controller
+          - const: aspeed,ast2600-sd-controller
+
Thanks the review. 

Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles

[Krzysztof Kozlowski]

On 20/03/2026 09:46, Ryan Chen wrote:
> Hello Krzysztof,
> I review https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/example-schema.yaml?h=v7.0-rc1
> I will do following modify
> -    enum:
> -      - aspeed,ast2400-sd-controller
> -      - aspeed,ast2500-sd-controller
> -      - aspeed,ast2600-sd-controller
> +    oneOf:
> +      - items:

Don't add items here. Was it in original code? No.


> +          - enum:
> +              - aspeed,ast2400-sd-controller
> +              - aspeed,ast2500-sd-controller
> +              - aspeed,ast2600-sd-controller
> +      - items:
> +          - const: aspeed,ast2700-sd-controller
> +          - const: aspeed,ast2600-sd-controller
> +
> Thanks the review. 


Best regards,
Krzysztof

[PATCH v2 2/2] mmc: sdhci-of-aspeed: Handle optional controller reset

[Ryan Chen]

Get the optional reset line for the ASPEED SD controller during probe by
using devm_reset_control_get_optional_exclusive_deasserted().

This allows platforms such as AST2700, which require the SD controller
to be taken out of reset before use, to work with the existing driver.

Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
---
Changes in v2:
- use devm_reset_control_get_optional_exclusive_deasserted replace
  reset_control_get_optional_exclusive.
- add include reset.h
---
 drivers/mmc/host/sdhci-of-aspeed.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c
index ca97b01996b1..8f638ffb55ae 100644
--- a/drivers/mmc/host/sdhci-of-aspeed.c
+++ b/drivers/mmc/host/sdhci-of-aspeed.c
@@ -13,6 +13,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
+#include <linux/reset.h>
 #include <linux/spinlock.h>
 
 #include "sdhci-pltfm.h"
@@ -520,6 +521,7 @@ static int aspeed_sdc_probe(struct platform_device *pdev)
 
 {
 	struct device_node *parent, *child;
+	struct reset_control *reset;
 	struct aspeed_sdc *sdc;
 	int ret;
 
@@ -529,6 +531,10 @@ static int aspeed_sdc_probe(struct platform_device *pdev)
 
 	spin_lock_init(&sdc->lock);
 
+	reset = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev, NULL);
+	if (IS_ERR(reset))
+		return dev_err_probe(&pdev->dev, PTR_ERR(reset), "unable to acquire reset\n");
+
 	sdc->clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(sdc->clk))
 		return PTR_ERR(sdc->clk);

-- 
2.34.1