Re: [PATCH v2 1/2] mmc: dt-bindings: sdhci-of-aspeed: Add AST2700 fallback compatibles

Krzysztof Kozlowski
2026-03-22T09:51:37Z

On 20/03/2026 09:46, Ryan Chen wrote:
> Hello Krzysztof,
> I review https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/example-schema.yaml?h=v7.0-rc1
> I will do following modify
> - enum:
> - - aspeed,ast2400-sd-controller
> - - aspeed,ast2500-sd-controller
> - - aspeed,ast2600-sd-controller
> + oneOf:
> + - items:

Don't add items here. Was it in original code? No.

> + - enum:
> + - aspeed,ast2400-sd-controller
> + - aspeed,ast2500-sd-controller
> + - aspeed,ast2600-sd-controller
> + - items:
> + - const: aspeed,ast2700-sd-controller
> + - const: aspeed,ast2600-sd-controller
> +
> Thanks the review.

Best regards,
Krzysztof