From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DF6D1093179 for ; Fri, 20 Mar 2026 04:21:08 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fcTrz1yKkz2xm5; Fri, 20 Mar 2026 15:21:07 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773980467; cv=none; b=hiUItNaj5zKzWRnU/ECENh7O/mL47EnGQWk5MKLKDBTRXBEPVJjhhV/ZPTB9RlyZltkO/CJsANsWEGY1onsBrwteSNXd7hi1NrtA6UnUetOqb7VivND0+UYlh+sEQ2BdHDLnmRGrXeYBL64Wu/6Oz3UXPgYAh+NrxGChCgedCTpaOPG2ylQvXG0VXEyDJOP6/k6h9SMjJRNblK60kXnbHzpeQYBMg85CzafqQ+n8SZRuYoFBVgBFh4LFEUfRY0xA1kiJT+ihdg76SzuavVrSdEfqzyu8JepwnNAiz4hYIN9aTZ7tkYXF3CFWqmKxfjuYcwsatm/bg484wo5QJL1eKQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1773980467; c=relaxed/relaxed; bh=NJMOvmuyxnPDgD6UKl/Wo25LJql6LgrNjqbSF6tqdFA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HvpFHbeXYuHsutpoOZnWQfcLFdHuOnA7Sn4Ds2GIWuxyAUdJeNGR8kIDt3Qw2py/PuzeD20DRxTTHIcM/8E8UaL7A74XuECH0hco0vY0aXPZTFWyW/tZQmmmfWDG+X0pk9wvSrbyPbbbz6ZyjRcux7uZOTbbMncbKVqPZ63FEn2IqidryrLGcc8AIfkitm+exTFdEqx0XSZhRWfMLY1JMy0v85YbjXEkqDq2KD7MLVfnv+LgxOP8FlkXUQuY2Ne9ONJLvTmOJVbohwMyGEHJXCc3eoq23ITsrdkaJ+z1ABQ9OPRKIeL+q1BM6MH6zR4zeLi3qGBjCd1RCDhY8TQNpw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WNG0Q9tN; dkim-atps=neutral; spf=pass (client-ip=192.198.163.13; helo=mgamail.intel.com; envelope-from=lkp@intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=WNG0Q9tN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.198.163.13; helo=mgamail.intel.com; envelope-from=lkp@intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fcTrs0ctqz2xm3; Fri, 20 Mar 2026 15:20:59 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773980461; x=1805516461; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OHnX7uZBV92R01nqYlUueQh+SwiiSpGawFPFVc+X9Ac=; b=WNG0Q9tNEI9GeOmoHyH7yn3z0gBNT/8e5+CbA2C7RD+ZlB+vdRvkMXDf dEIAcMUlsffmQ3NIePVSzPvP/u7KdoWUZIiZgQ2QDIE6+o9OOki6Fkc/d emKLPrtGXssj9QCYBGeIRCDU1JQGPCUZ98QwV36T5yJ2btvG9Er6mTh73 rKUUu5ohjrbYRqsNaPZItveuJ7A6uIrWftvaeLmP3VUVMXN/KcoFOw0Po SvC5HdGKKLThkf7X6aFQQBr46V8wt3qLxtC2sq+tW9SE3l1pWYWfUP2e8 UxqBqfitU2wHWfj2T3SzDCIDrkx5MbjEXiIpZYcYqyCTu9qQqpY9j6IgV w==; X-CSE-ConnectionGUID: QB1v7JO6Q/ik/uYkGYfZJA== X-CSE-MsgGUID: oTC5VwwJTXS74GH1T5EQUg== X-IronPort-AV: E=McAfee;i="6800,10657,11734"; a="77670265" X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="77670265" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2026 21:20:56 -0700 X-CSE-ConnectionGUID: f2vicg65TU+omWmZ32VWkg== X-CSE-MsgGUID: Kgb03j0VRrWGSeCxQZ27jw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="220549657" Received: from lkp-server02.sh.intel.com (HELO a51c2a36b9df) ([10.239.97.151]) by fmviesa008.fm.intel.com with ESMTP; 19 Mar 2026 21:20:53 -0700 Received: from kbuild by a51c2a36b9df with local (Exim 4.98.2) (envelope-from ) id 1w3RLn-000000001wf-2k5k; Fri, 20 Mar 2026 04:20:45 +0000 Date: Fri, 20 Mar 2026 12:19:52 +0800 From: kernel test robot To: aspeedyh , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Ryan Chen , Philipp Zabel Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, maciej.lawniczak@intel.com, aspeedyh Subject: Re: [PATCH 5/7] soc: aspeed: Add eSPI flash channel support Message-ID: <202603201234.n0spXcAN-lkp@intel.com> References: <20260313-upstream_espi-v1-5-9504428e1f43@aspeedtech.com> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260313-upstream_espi-v1-5-9504428e1f43@aspeedtech.com> Hi aspeedyh, kernel test robot noticed the following build errors: [auto build test ERROR on 0257f64bdac7fdca30fa3cae0df8b9ecbec7733a] url: https://github.com/intel-lab-lkp/linux/commits/aspeedyh/dt-bindings-soc-aspeed-Add-AST2600-eSPI-controller/20260315-101647 base: 0257f64bdac7fdca30fa3cae0df8b9ecbec7733a patch link: https://lore.kernel.org/r/20260313-upstream_espi-v1-5-9504428e1f43%40aspeedtech.com patch subject: [PATCH 5/7] soc: aspeed: Add eSPI flash channel support config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20260320/202603201234.n0spXcAN-lkp@intel.com/config) compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260320/202603201234.n0spXcAN-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202603201234.n0spXcAN-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/soc/aspeed/espi/ast2600-espi.c:137:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] reg |= FIELD_PREP(ESPI_CTRL_FLASH_TAFS_MODE, flash->tafs.mode); ^ drivers/soc/aspeed/espi/ast2600-espi.c:172:28: warning: variable 'flash' set but not used [-Wunused-but-set-variable] struct aspeed_espi_flash *flash; ^ >> drivers/soc/aspeed/espi/ast2600-espi.c:194:13: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] hdr->cyc = FIELD_GET(ESPI_FLASH_RX_CTRL_CYC, reg); ^ drivers/soc/aspeed/espi/ast2600-espi.c:243:8: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] reg = FIELD_PREP(ESPI_FLASH_TX_CTRL_CYC, cyc) | ^ 1 warning and 3 errors generated. vim +/FIELD_PREP +137 drivers/soc/aspeed/espi/ast2600-espi.c 111 112 static void ast2600_espi_flash_reset(struct aspeed_espi *espi) 113 { 114 struct aspeed_espi_flash *flash; 115 u32 reg; 116 117 flash = &espi->flash; 118 119 writel(ESPI_INT_EN_FLASH, espi->regs + ESPI_INT_EN_CLR); 120 writel(ESPI_INT_STS_FLASH, espi->regs + ESPI_INT_STS); 121 122 reg = readl(espi->regs + ESPI_CTRL); 123 reg &= ~(ESPI_CTRL_FLASH_TX_SW_RST 124 | ESPI_CTRL_FLASH_RX_SW_RST 125 | ESPI_CTRL_FLASH_TX_DMA_EN 126 | ESPI_CTRL_FLASH_RX_DMA_EN 127 | ESPI_CTRL_FLASH_SW_RDY); 128 writel(reg, espi->regs + ESPI_CTRL); 129 130 udelay(1); 131 132 reg |= (ESPI_CTRL_FLASH_TX_SW_RST | ESPI_CTRL_FLASH_RX_SW_RST); 133 writel(reg, espi->regs + ESPI_CTRL); 134 135 flash->tafs.mode = TAFS_MODE_SW; 136 reg = readl(espi->regs + ESPI_CTRL) & ~ESPI_CTRL_FLASH_TAFS_MODE; > 137 reg |= FIELD_PREP(ESPI_CTRL_FLASH_TAFS_MODE, flash->tafs.mode); 138 writel(reg, espi->regs + ESPI_CTRL); 139 140 if (flash->dma.enable) { 141 writel(flash->dma.tx_addr, espi->regs + ESPI_FLASH_TX_DMA); 142 writel(flash->dma.rx_addr, espi->regs + ESPI_FLASH_RX_DMA); 143 144 reg = readl(espi->regs + ESPI_CTRL) 145 | ESPI_CTRL_FLASH_TX_DMA_EN 146 | ESPI_CTRL_FLASH_RX_DMA_EN; 147 writel(reg, espi->regs + ESPI_CTRL); 148 } 149 150 writel(ESPI_INT_EN_FLASH_RX_CMPLT, espi->regs + ESPI_INT_EN); 151 152 reg = readl(espi->regs + ESPI_CTRL) | ESPI_CTRL_FLASH_SW_RDY; 153 writel(reg, espi->regs + ESPI_CTRL); 154 } 155 156 int ast2600_espi_flash_probe(struct aspeed_espi *espi) 157 { 158 u32 regs; 159 160 regs = readl(espi->regs + ESPI_STS); 161 if (regs & (ESPI_STS_FLASH_TX_BUSY | ESPI_STS_FLASH_RX_BUSY)) { 162 dev_warn(espi->dev, "eSPI flash channel is busy, deferring...\n"); 163 return -EPROBE_DEFER; 164 } 165 166 ast2600_espi_flash_reset(espi); 167 return 0; 168 } 169 170 int ast2600_espi_flash_remove(struct aspeed_espi *espi) 171 { 172 struct aspeed_espi_flash *flash; 173 u32 reg; 174 175 flash = &espi->flash; 176 177 writel(ESPI_INT_EN_FLASH, espi->regs + ESPI_INT_EN_CLR); 178 179 reg = readl(espi->regs + ESPI_CTRL); 180 reg &= ~(ESPI_CTRL_FLASH_TX_DMA_EN 181 | ESPI_CTRL_FLASH_RX_DMA_EN 182 | ESPI_CTRL_FLASH_SW_RDY); 183 writel(reg, espi->regs + ESPI_CTRL); 184 185 return 0; 186 } 187 188 int ast2600_espi_flash_get_hdr(struct aspeed_espi *espi, 189 struct espi_comm_hdr *hdr) 190 { 191 u32 reg, len; 192 193 reg = readl(espi->regs + ESPI_FLASH_RX_CTRL); > 194 hdr->cyc = FIELD_GET(ESPI_FLASH_RX_CTRL_CYC, reg); 195 hdr->tag = FIELD_GET(ESPI_FLASH_RX_CTRL_TAG, reg); 196 len = FIELD_GET(ESPI_FLASH_RX_CTRL_LEN, reg); 197 hdr->len_h = (len >> 8) & 0xff; 198 hdr->len_l = len & 0xff; 199 200 return 0; 201 } 202 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki