From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CC841094486 for ; Sat, 21 Mar 2026 15:50:06 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fdP5S595Vz2yds; Sun, 22 Mar 2026 02:50:04 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774108204; cv=none; b=auBJhBRqTZ8QPk7NDXnQTNovBhTrlQZ8GXE/weux/v2HuLOolSKuW5y9WnGNdp1HqUgIswOpDaic64HK/C8LwTwe9zRQxT48vOrRc3Iy3JoTe16Qgb1MT9jclrnmRiVS3RwqUBNC9VI0xuxRTCIPZO10KagpKXJmyY5z5bu+dRm0yxlmCQVWtDTdtQvSzHgzI5bPK6LYp5cLAkGILIH02krCHVcd1fIa8Iy3jdQs5AN2T06j39COLSxp5sGfs+V/h3604DXM+q7mxPoEm/hEKiLo9Bjei0UCaJ5rwCx0/YKB8coyo8n1b6F4GJ4WzTsl0ug9Nd07HA3h9tFOUFW4ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774108204; c=relaxed/relaxed; bh=BztVlr52jyDB/PMooczhe78cc61qz4qlqThyVP3NYvo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RzpPy/kyVqLJKZHS9T236ItqVu9odcNrZ3qW8E/PDnMSFlyMJFWo60QoAmQZWohQgEL/M1puG/JeuAhctb5cCRQdu4aUsrvCqIAm6Fz9QEyNlFOJpCwzCl8sOUsNCQB8qHP+FdmfWEDVOxfWj+vV4MBw8AOLzZI06wVLYjP2R+XQpPxHKTrAQu44PVCd2aF5JrnzeKfjVcJjcmdNb0QY1i3J2Ww6KQduRhJO7dt+i111kXDYhsBXj6c/eFXp3D7JWgdRc6pGaFuQ2r8KZxuqvuRUKkHgc5P7nvRiHFZoIjexd+uvWYwq90BCUqqP0tEOHe/ePa4fUMGoGLjNdHN88Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=e9dAXYUD; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=jic23@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=e9dAXYUD; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=jic23@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fdP5S09d7z2yZN for ; Sun, 22 Mar 2026 02:50:03 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 16AAE442F7; Sat, 21 Mar 2026 15:50:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49918C19421; Sat, 21 Mar 2026 15:49:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774108200; bh=kbn1WK1P0CLV3g9NxTzimggMcG6TtSf4XHKsAXdiH8c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e9dAXYUDAsN9v4x1AadURqYSlSWa9Y7mxzZIDz25fB/CvA9Fyj7XD1b8lCM9cyKMb F9rKRu8DkNZUirh+lv4LOJ/xxoxthjOn0mXZRo49DpIcI7mldLM7DvvygCk8RztYhv d3Koaq1whNjtTUgG2lFGA6rfl0j3AqAiIQlxwwZeM2itrO1aQEDY6rdQayBSLFY4jV KdQ+p/bWaAKz5+B1wT6Oz/LcZIZlM+DgBADkf6carn+i0Ct0isAYEjuwIxZYfTnf7C +juQM6z2gUQ+iqOOkPzxxjzQnqohMQvNin2+WXg7FyqqK5FABtdD8feGRyz7b+oEYL f89WoEbIKQ/Zw== Date: Sat, 21 Mar 2026 15:49:51 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: Billy Tsai , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, morris_mao@aspeedtech.com Subject: Re: [PATCH v3 3/4] iio: adc: aspeed: Replace mdelay() with fsleep() for ADC stabilization delay Message-ID: <20260321154951.632ef7d9@jic23-huawei> In-Reply-To: References: <20260320-adc-v3-0-bc0eac04ef7c@aspeedtech.com> <20260320-adc-v3-3-bc0eac04ef7c@aspeedtech.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-pc-linux-gnu) X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 20 Mar 2026 12:31:41 +0200 Andy Shevchenko wrote: > On Fri, Mar 20, 2026 at 01:46:37PM +0800, Billy Tsai wrote: > > The ADC stabilization delays in compensation mode and battery sensing > > mode do not require atomic context. Using mdelay() here results in > > unnecessary busy waiting. > > > > Replace mdelay(1) with fsleep(1000) to allow the scheduler to run other > > tasks while waiting for the ADC to stabilize. > > > > Also fix a minor typo in the comment ("adc" -> "ADC"). > > > Suggested-by: Andy Shevchenko > > I haven't suggested the idea, I only suggested to use fsleep() for the purpose. Dropped the tag. >