From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54F831094489 for ; Sat, 21 Mar 2026 15:51:42 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fdP7J6Hcsz2yfs; Sun, 22 Mar 2026 02:51:40 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.105.4.254 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774108300; cv=none; b=QKVT/AyK4wOGQvSwyPvgZVlEgT8GWAMLkjIPf78HZ5tBmYizfTaLrat0Ex2ZL/nufstFSuVmHXcGb2gc9gKJYNfKXK26ZWwUwgyXjFSqgifp6QDE92yTIzLexlzAhbcjP4vxI0SP/rFzMw79Y51ZXkKE7lz0TwcSk70G2hnsp5SW9TNIaKOdO50bM4JtkjfDiGUZNpfvwNAPPQ0APK67HjDzLvyz5WKMG7lq2Arl3F6HSJtAE8jLkYNYhqcQmJ1SWPiLElLN7lgpLX0AFRZfFu6bgUHigblrpqqRlTnq0Dj9FS5h+EJ+YqgqFh9vZGuPzpi/PnFuIMn0Ga4UOQNxRg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774108300; c=relaxed/relaxed; bh=sG4XhuqDJEdIQMND5WpkEc5bLbq0ERYW/OUxAG8RzSw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HvudB9po0lrOv9oCJRSjpHybMutFKzKiAn1lBOGFfYtHYxj/TdA+zuDWrF9f3IfZzyXiGvU0RPyu1PQSDZta6wW7UbDT9052vGQPJzoE3m5TwbUhHow5ozLAiRlRc54Nje+3h5/V9j4vu4YABk15nuWIjJ4BCs5tfAywln/Sg5LxUJauDlRI2TU1lur40443px/oBgNYN1lg46SzfPt00N6uGtf2x/WEwklvVNrDU4/0VX2k43VeDyPbPAy1hj8AuE1n5yV+SSqjedGEwwHkAuDWxS6m6PwvuLZPYIMiZV2g8vZ2AMzQKO1PKjp0tgA6W7DFoUDEptnZtVOz+fDw8Q== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=S615ZWhJ; dkim-atps=neutral; spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=jic23@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=S615ZWhJ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=jic23@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fdP7J1rL5z2yfl for ; Sun, 22 Mar 2026 02:51:40 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4F1EA60097; Sat, 21 Mar 2026 15:51:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C045C19421; Sat, 21 Mar 2026 15:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774108297; bh=iJK6gXRLy8snWp9xWdLSHDh/M81apV4w9OBDnP6so3c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S615ZWhJmxbdpU+bgacRtU8dgRb16UnPmsyiRB3L6XZW+D+RcW/f/dzvmE92oVsXX do7A2ayfRyx3Gx2wPKf31th8IWvMlFRWxVAhgzm8t2cYvWYEg1Pe5kQZVY3Sfd4Iuq 9fwlxfE9ycpiUsNH2c4xej/TemgNxyF+fctZdo35/e8YaGAbKOCobDHUymeNrfykPc SJ5ZD23GsrUVCNhXe7K1tVkg7HrXSmETfmXQWi1eTU/ZLBxoSLPYxPjQH5iAZjT/JC mAHEQOoLvWi07QJYHamGlARrG2vRz6P0MP6FVjMLXL68o8a+fiJGHB3t7n5nChdg4o 6RHej1iQmb4dg== Date: Sat, 21 Mar 2026 15:51:27 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: Billy Tsai , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, morris_mao@aspeedtech.com Subject: Re: [PATCH v3 4/4] iio: adc: aspeed: Reserve battery sensing channel for on-demand use Message-ID: <20260321155127.3e63fa47@jic23-huawei> In-Reply-To: References: <20260320-adc-v3-0-bc0eac04ef7c@aspeedtech.com> <20260320-adc-v3-4-bc0eac04ef7c@aspeedtech.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-pc-linux-gnu) X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 20 Mar 2026 12:33:32 +0200 Andy Shevchenko wrote: > On Fri, Mar 20, 2026 at 01:46:38PM +0800, Billy Tsai wrote: > > For controllers with battery sensing capability (AST2600/AST2700), the > > last channel uses a different circuit design optimized for battery > > voltage measurement. This channel should not be enabled by default > > along with other channels to avoid potential interference and power > > efficiency issues. > > This ensures optimal power efficiency for normal ADC operations while > > maintaining full functionality when battery sensing is needed. > > > ... > > > + /* > > + * After enable a new channel need to wait some time for ADC stable > > Missed period at the end. And you probably wanted to say > "...for ADC to stabilize." Tweaked and tidied up line wrap. Series applied to the togreg branch of iio.git. thanks, Jonathan > > > + * Experiment result is 1ms. > > + */ > > + fsleep(1000); > > + } >