From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BECCFC43458 for ; Sun, 5 Jul 2026 05:46:41 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gtGgp4p7Fz2yqs; Sun, 05 Jul 2026 15:46:14 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1783107761; cv=none; b=gIdJeHIxpC2GTviMGfZThvwKF5a7QVqHNlAD28x6ER2uF8gW49IV+eVid9kqH2UnJnDaBO3PGWyPqlDwOcCYrISw5W7vsVmQAEP+qbYc+0XW7n/Od+PB3sB0d/chtw3VwJiZGwWxva9VPJqxAVftg160jQ4VRu61rD43VOsh6RpqAfRCohdvE5Z2aDMcvpYix9stU9Ypnvb0ouGsd+4IpG3N9cDnAL65kp7kMdlf+HXFpqurxtPSjLOjaxSLle3yUcM19+/y6u/6PQ91LbY+s0o16BGOPc5Z4GAysfOqbuXEQL8uuD00faQyb+bVTClZL49LxqyUZ+IvS9Wkr5oKEg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1783107761; c=relaxed/relaxed; bh=BM7jtgPz5puXtMgobfAPTx0DKFPGBIZQqDVHqsjFOZI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kmRWH95bDGNPNnlTgttlWb4Auop6ffNgL+nyVxtWI3WfM/SzMhyohhRtFnjHZauOryGz1BcBS4Bb1cZaso7ovQ8o8Dnujbf3XxsOvxPC3rZMYEaMTIq76f2AAlfCxIRIOKm9d7ToF0KJ02MX6JFjvuXnI49Kfht5wZmmtxeH8bAtd8gtHkuY+lppTjm5rTw2CmvLDD/jcbFO52GbARrQDLgInqGNLUTDUuLRbO5OGpdEzGaopWkWZGi1C683uWYsWN6fck6aFKnJUXytptKm587x9yM+GMNOfOC1dqtSOcKGEuVJD4NNrPx6OZbBC6cR8pelV59GYZJpixLcOxe3Pg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=jKWf2GSY; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Zt5HZhZt; dkim-atps=neutral; spf=pass (client-ip=205.220.168.131; helo=mx0a-0031df01.pphosted.com; envelope-from=mukesh.ojha@oss.qualcomm.com; receiver=lists.ozlabs.org) smtp.mailfrom=oss.qualcomm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=jKWf2GSY; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Zt5HZhZt; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=oss.qualcomm.com (client-ip=205.220.168.131; helo=mx0a-0031df01.pphosted.com; envelope-from=mukesh.ojha@oss.qualcomm.com; receiver=lists.ozlabs.org) Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gsPKs1sWTz2xC3 for ; Sat, 04 Jul 2026 05:42:40 +1000 (AEST) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663HieUm494926 for ; Fri, 3 Jul 2026 19:42:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=BM7jtgPz5pu XtMgobfAPTx0DKFPGBIZQqDVHqsjFOZI=; b=jKWf2GSYBWt0WCeSTarF/ZyxiwK ySviO6bqYuR7hXocJXWdOzctBTkhr9x7EBJtne4ZOFmY2TQnOa/Gh839O06jG1Z7 dooiFHxttTiabG9BCsQjg42O4/YG3Njl/KqjnIDTpKtWlrEa7Oz6uExs+CjZECUi xjJD6IMEajr2OkDLA3WKBxxOfzl0dQqBxjqVSPjOoU9RaH/p2EFT7u56Y4OH0mzN ZRdyYM3r4dJMbR3VmiLwRyPjjK7ZwaTZ5+BWp14AX1vqD6b0N/1+keNALbhSW6GJ 73bXzhYTiDhE7iSf9SrCIj4lzRwnt5YUmTfWTl/y5PQ/BXjK1zfMPAEFh9Q== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f68jytksu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 19:42:39 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-36d97955899so1305488a91.0 for ; Fri, 03 Jul 2026 12:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783107758; x=1783712558; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BM7jtgPz5puXtMgobfAPTx0DKFPGBIZQqDVHqsjFOZI=; b=Zt5HZhZtyvh4KuuAPyB0XkbkfdHIppAY+9QGqjCVYuwGw+tdNwBiFVW6aUxYF+hYN5 HL/pKnppNEtaw+WOe3yEpGCNAyQN2CgghnK58SCAlUdxFeZdrmEhkw/AYGPWxp9yNdWm Opr4R5RbmJRRVzyHlvCmc3kmb5y8pSmsvlCheU770ZM6nfdX5ENJZ6cSxgFW/B+K/PSa 5yqgGVW+cC+EuA4rEAuBVJBtioQkg1p/IFmo+ZiCbzj9+/oUBiNSPQdtEsVWv9aAMs32 IVZpJD8iyzABI1bjF9/sPAEje3Ap79LQA6Ov0suY7ZDGnMYUzZfEy7gJcS+UUT6JMlHQ GJtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783107758; x=1783712558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BM7jtgPz5puXtMgobfAPTx0DKFPGBIZQqDVHqsjFOZI=; b=P9rlqukmaSa1G5HcR0NhnJeQt47UhVFn0vdMfy8honwCllX4V8OvHeiahj5ywOqWes kiyGuFgjhKTIH9UXxDmjVM/idKUoFg23IaEiNFwhTkFy+Ovy0QvptbfjFZ+7ohN3QrsG SyjtPf2LEiw3KaDt16LU/Cv/1ySy3HwrjgR4E5SFH5RxD4ByzPs5CdWcHNwn6FuRaf0F Zn+/TY+P/4mLxmufjUxGHi9QKX4fC853UXVeCDy7QuJ6nlyLxhDrWqVdug5GWktQ6v3W Dlhuyo6Z4DmbHTEAtXpSOdaKU/WJbwMoLQWgbE/baPyt+hWvfM1DRXajnCvzIBp8G50O 9SGg== X-Forwarded-Encrypted: i=1; AHgh+RoLYOu71JgTnlSVAa/7HqgqrF+H5LcF2SvmuffsvX1yvrcHM5lIbo/NgN+6DdXXRJRdURzoiEKHptJLWFA=@lists.ozlabs.org X-Gm-Message-State: AOJu0YzTPFm3kavNcezNdj8+J7kn2ktc011JLwERyJAQEwJKDm3c8eLD o/vjr2VO96+UuHxIhqaztZVtVINYoq2+8zN8Nq/vP9LmKynmlJ+l8jc2uZmUfJs3x8LohP9WctV OTAuJKpor6ubfBVLSKWP9uqvda3fEVrCKVjyKzNUe8Q0l2jX42q3aEib2nhW7MvLNAz0E X-Gm-Gg: AfdE7cm9zhIqe3O1kxP+/78ZRv1+8MPpXpeAbkmwK9wjC0mqlft/FtPM3HxE/Zbrhzz E87AvA1X/aVFvomN7Aectv4ENgCB4itMznL6cm5MSd3YgCS/JM51msGGMbFOINNxpfDzbYF83qb ukoXDMqgLGKhqcKLcGnT8PtNQBocl2VqXiN4VtKn5wXZRK5IKl9jh2iFhRuKWFkNBfrcVCNd/IZ piHA+AYiosB/S9CcRuqDFj3bWmW49lsGB1PQ9+TlQabT2UjRO/W1VLyGzouYeUqzRdayfaKzC6I SFd/XhysS/B7IQDWSRyolxsqTUjikvZ7Ft7rUcpxlcQAsOfS3pmyS4vmHu+l+NsO2f21+krWDdy l7+YA8NpT1mYOhD+1DhFU7w7Tokbfw1U/a2iqAw== X-Received: by 2002:a17:90a:e708:b0:37e:a09:2640 with SMTP id 98e67ed59e1d1-382807ae330mr703133a91.7.1783107758432; Fri, 03 Jul 2026 12:42:38 -0700 (PDT) X-Received: by 2002:a17:90a:e708:b0:37e:a09:2640 with SMTP id 98e67ed59e1d1-382807ae330mr703088a91.7.1783107757826; Fri, 03 Jul 2026 12:42:37 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f290b6bc2sm10065845eec.27.2026.07.03.12.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 12:42:37 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Joel Stanley , Andrew Jeffery , Paul Cercueil , Anitha Chrisanthus , Paul Kocialkowski , Linus Walleij , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexey Brodkin , Laurent Pinchart , Tomi Valkeinen , Michal Simek , Daniel Scally , Jacopo Mondi , Mauro Carvalho Chehab , Eddie James , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Minghsiu Tsai , Houlong Wei , Matthias Brugger , AngeloGioacchino Del Regno , Joseph Liu , Marvin Lin , Dmitry Osipenko , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Srinivas Kandagatla , Arnd Bergmann , Greg Kroah-Hartman , Ge Gordon , Adrian Hunter , Ulf Hansson , Rob Herring , Saravana Kannan , Mathieu Poirier , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Liam Girdwood , Mark Brown , Frank Li , Sascha Hauer , Peter Ujfalusi , Bard Liao , Daniel Baluta , Orson Zhai , Baolin Wang , Peter Chen , Fugang Duan Cc: Ekansh Gupta , BST Linux Kernel Upstream Group , Fabio Estevam , Nicolin Chen , Pengutronix Kernel Team , Kai Vehmanen , Pierre-Louis Bossart , Vijendar Mukunda , Chunyan Zhang , CIX Linux Kernel Upstream Group , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, linux-tegra@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-staging@lists.linux.dev, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, sound-open-firmware@alsa-project.org, Mukesh Ojha Subject: [PATCH 08/42] drm: logicvc: Use devm_of_reserved_mem_device_init() Date: Sat, 4 Jul 2026 01:08:21 +0530 Message-ID: <20260703193855.110619-9-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703193855.110619-1-mukesh.ojha@oss.qualcomm.com> References: <20260703193855.110619-1-mukesh.ojha@oss.qualcomm.com> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE5OCBTYWx0ZWRfX+KZ/2ZOnniST 8gX53tQulWpaUhNuL4C0XQ2wjfQjbLfEl0VhcWq32twss6sfvlAFuBVgG/P2/wcRWyomL1SOY6T DWqJKsmbKhIuV3+wqbzw7ha4Ti3t9yfLEbAWq41pl/4NZK+2n6GG/w+pXFStogk44Hfkz3jveGm 3Ht+Yv65ba6Ba1zQTqFs3XgPNg8pc1OkGicOQFqTury1/8XdpKVSaviG8JHiaxXA205rKdg5fwB HdR80ZhYdwKSJyYE+5hlE2VwvpU1jHKG728nkAumhclu33qbYb9dp+MvlaC96zZkA0Oie3K3AKh pXuxkylcV7mEODbe/fd1r83JM8Tihw9onPHmM8DMJCKyNF+Ta399PH/z4B3kodCOhjjlJjoqTVi ORGc9UolGcAMWAsVmlcWIm4FgH9m6e1ALXpMSuKvlu4jn75dRrOSbqLbIekbGt4seq6ONsX4eNP ZDty9wKDFn4oZ4+ln8g== X-Proofpoint-GUID: u79vSicrADqJH-IfIEwTu2qb0cV630Go X-Authority-Analysis: v=2.4 cv=QbFWeMbv c=1 sm=1 tr=0 ts=6a4810af cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=ReI0EElcLHst8dYcsfAA:9 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: u79vSicrADqJH-IfIEwTu2qb0cV630Go X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE5OCBTYWx0ZWRfX7F8wZC3tDLDI dXnvkbQ1b3ghsqu1RRAw5Cod7+E3aHc461YvJhSqGJZZjzXeHl3aTol+OgeBdb01Mhms8EC503T xMbEuDRtmR8DtZZ8PsDscsHDMTxaEZ4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 clxscore=1015 bulkscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030198 Switch to devm_of_reserved_mem_device_init() so the reserved memory region is released automatically on probe failure or device unbind. Replace all error paths that jumped to error_reserved_mem: with error_early: since the manual cleanup label is no longer needed, and remove the explicit of_reserved_mem_device_release() call in the remove function. Signed-off-by: Mukesh Ojha --- drivers/gpu/drm/logicvc/logicvc_drm.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c index bbebf4fc7f51..d6dbe52ff0a9 100644 --- a/drivers/gpu/drm/logicvc/logicvc_drm.c +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c @@ -306,7 +306,7 @@ static int logicvc_drm_probe(struct platform_device *pdev) int irq; int ret; - ret = of_reserved_mem_device_init(dev); + ret = devm_of_reserved_mem_device_init(dev); if (ret && ret != -ENODEV) { dev_err(dev, "Failed to init memory region\n"); goto error_early; @@ -327,14 +327,14 @@ static int logicvc_drm_probe(struct platform_device *pdev) ret = of_address_to_resource(of_node, 0, &res); if (ret) { dev_err(dev, "Failed to get resource from address\n"); - goto error_reserved_mem; + goto error_early; } base = devm_ioremap_resource(dev, &res); if (IS_ERR(base)) { dev_err(dev, "Failed to map I/O base\n"); ret = PTR_ERR(base); - goto error_reserved_mem; + goto error_early; } logicvc_drm_regmap_config.max_register = resource_size(&res) - @@ -345,21 +345,21 @@ static int logicvc_drm_probe(struct platform_device *pdev) if (IS_ERR(regmap)) { dev_err(dev, "Failed to create regmap for I/O\n"); ret = PTR_ERR(regmap); - goto error_reserved_mem; + goto error_early; } } irq = platform_get_irq(pdev, 0); if (irq < 0) { ret = -ENODEV; - goto error_reserved_mem; + goto error_early; } logicvc = devm_drm_dev_alloc(dev, &logicvc_drm_driver, struct logicvc_drm, drm_dev); if (IS_ERR(logicvc)) { ret = PTR_ERR(logicvc); - goto error_reserved_mem; + goto error_early; } platform_set_drvdata(pdev, logicvc); @@ -371,7 +371,7 @@ static int logicvc_drm_probe(struct platform_device *pdev) caps = logicvc_drm_caps_match(logicvc); if (!caps) { ret = -EINVAL; - goto error_reserved_mem; + goto error_early; } logicvc->caps = caps; @@ -382,7 +382,7 @@ static int logicvc_drm_probe(struct platform_device *pdev) ret = logicvc_clocks_prepare(logicvc); if (ret) { drm_err(drm_dev, "Failed to prepare clocks\n"); - goto error_reserved_mem; + goto error_early; } ret = devm_request_irq(dev, irq, logicvc_drm_irq_handler, 0, @@ -450,9 +450,6 @@ static int logicvc_drm_probe(struct platform_device *pdev) error_clocks: logicvc_clocks_unprepare(logicvc); -error_reserved_mem: - of_reserved_mem_device_release(dev); - error_early: return ret; } @@ -469,8 +466,6 @@ static void logicvc_drm_remove(struct platform_device *pdev) logicvc_mode_fini(logicvc); logicvc_clocks_unprepare(logicvc); - - of_reserved_mem_device_release(dev); } static void logicvc_drm_shutdown(struct platform_device *pdev) -- 2.53.0