From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Cosmo Chou <chou.cosmo@gmail.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
joel@jms.id.au
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
cosmo.chou@quantatw.com
Subject: Re: [PATCH 0/2] ARM: dts: aspeed: bletchley: Add second source devices
Date: Wed, 22 Jul 2026 16:44:41 +0930 [thread overview]
Message-ID: <27318e19dee124898b95a10f9cad28f456835da4.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260714120816.1504058-1-chou.cosmo@gmail.com>
Hi Cosmo,
On Tue, 2026-07-14 at 20:08 +0800, Cosmo Chou wrote:
> Add second source RTC (ISL1208) and LED controllers (PCA9532) for the
> Bletchley platform.
>
> Cosmo Chou (2):
> ARM: dts: aspeed: bletchley: Add second source ISL1208 RTC
> ARM: dts: aspeed: bletchley: Add second source PCA9532 LED controllers
>
> .../aspeed/aspeed-bmc-facebook-bletchley.dts | 294 ++++++++++++++++++
> 1 file changed, 294 insertions(+)
A quick inspection of both patches suggests the nodes aren't ordered by
ascending address. Can you please style-check your work?
We now have scripts/dtc/dt-check-style. I would appreciate further
patches for bletchley cleaning up the rest of the issues it identifies
in strict mode.
Andrew
prev parent reply other threads:[~2026-07-22 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 12:08 [PATCH 0/2] ARM: dts: aspeed: bletchley: Add second source devices Cosmo Chou
2026-07-14 12:08 ` [PATCH 1/2] ARM: dts: aspeed: bletchley: Add second source ISL1208 RTC Cosmo Chou
2026-07-14 12:08 ` [PATCH 2/2] ARM: dts: aspeed: bletchley: Add second source PCA9532 LED controllers Cosmo Chou
2026-07-22 7:14 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27318e19dee124898b95a10f9cad28f456835da4.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=chou.cosmo@gmail.com \
--cc=conor+dt@kernel.org \
--cc=cosmo.chou@quantatw.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox