From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F352CF45D5 for ; Mon, 12 Jan 2026 22:41:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4dqnRH3sBhz2yK7; Tue, 13 Jan 2026 09:41:15 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=185.246.85.4 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768227611; cv=none; b=ON/kKmDi6UTrgU1KhwPJ4s/LwszRTAYjCr4t4mPpJivG87vAhLgwUUgG+qNhcpMI+oB4Cq/TJ+Un3vagQutzGtba/q0+b3ho7qrVW0WwqdB/oNi34wOIp6SeHgneDJX/qdHQmpYpRKRPyb2u+PvQxfo7mMcmNI0XfrXgSCmMu1Wiy0Ok7nPuSFBSJIT0vDQ1ymYaRHfAQC0mSDGqpq0GiXuKpmrRO/r/b+UMCQMID61sTDDBmCwstpWUEA4xipjuzfyD8uZghKckQv/p+KMB01WbowQVwyKrGUzbHittlY/abpQtgAYbrEPNqyO7sYwhq7MKrbgEYcsijM2/W5CLig== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768227611; c=relaxed/relaxed; bh=S8c2ARP9HcnV+reUeOF4Vcg2quHBkPmCAqYrhfyr6c0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Gzw84Kep/HgM5xv/5PUc2Q+oAmjpPm72sICytexfuz8ZqtNpTii2AekYU9n01PyM3dD6xEQPzV9IAgKcGg3NhCrGO2omBM35sie53Kt86ngd/vgjZACcsgITAmL6kfjX67qDB8J1hJBWE3ZoeYIDDd0OrUCge6BWNGKSPkBBnLjaNmZCJjfrvc+oyLm1eW/TKCxClHw1FTNBZQl8jYcqJGs40ZHke7igdGoVmUUorNx3Fg95ZuEd/G6TSnzCedt7oqc6XU8oUcDLTATDOYDEih9012BaQCssjyRAHbGGz0xXhZnXTeRk1J72zUN3bBnOpsBDzEcb/XkNh3VNLO2fyA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=CakAumhF; dkim-atps=neutral; spf=pass (client-ip=185.246.85.4; helo=smtpout-03.galae.net; envelope-from=benoit.monin@bootlin.com; receiver=lists.ozlabs.org) smtp.mailfrom=bootlin.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=CakAumhF; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=185.246.85.4; helo=smtpout-03.galae.net; envelope-from=benoit.monin@bootlin.com; receiver=lists.ozlabs.org) X-Greylist: delayed 503 seconds by postgrey-1.37 at boromir; Tue, 13 Jan 2026 01:20:06 AEDT Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4dqZK26kqfz2xHW for ; Tue, 13 Jan 2026 01:20:05 +1100 (AEDT) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 3609A4E42085; Mon, 12 Jan 2026 14:11:37 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DEFBC60732; Mon, 12 Jan 2026 14:11:36 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 736BF103C8C61; Mon, 12 Jan 2026 15:10:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1768227090; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=S8c2ARP9HcnV+reUeOF4Vcg2quHBkPmCAqYrhfyr6c0=; b=CakAumhFpasu+3ZI3BaB812kdRiuu+v1Tg/Sp3TTEi8pdVKDZEtVO84AoLEgEc1xrnFluT i+SAwVNTU/VK298rD4GgfOlbL1x1IRBq+LMtmjrslvr8iNw/wqHBq7SowNZ+1bxrqAdaPR ziVMPo032s+fSJqG9mpYJmDIazpKyi53yb/qGj1zj4VwwbAj77lJfzPnCy7GfnRvSCaoiG VLNhV0T9IC//MbbHQG1tnGAF03XNmqvN+K3xG6/Renyw+hJ5Ia+fO3n6d7mTvuZI7e4oUm CIup66ln9btW8iWglHRpKXcMS5I6EydGAat63GN0yLYYuyDF497mBLdXxOQ06g== From: =?UTF-8?B?QmVub8OudA==?= Monin To: Mark Brown , Varshini Rajendran , Mikhail Kshevetskiy , AngeloGioacchino Del Regno , Sunny Luo , Janne Grunau , Andy Shevchenko , Chin-Ting Kuo , CL Wang , Manikandan Muralidharan , David Lechner , Florian Fainelli , Jonas Gorski , Hang Zhou <929513338@qq.com>, Jun Guo , Philipp Stanner , Charles Keepax , Bartosz Golaszewski , Shiji Yang , James Clark , Jonathan Marek , Carlos Song , Sakari Ailus , Huacai Chen , Xianwei Zhao , Prajna Rajendra Kumar , Sergio Perez Gonzalez , Miquel Raynal , Qianfeng Rong , Haibo Chen , Gabor Juhos , Md Sadre Alam , Rosen Penev , Luis de Arquer , Geert Uytterhoeven , Cosmin Tanislav , Tudor Ambarus , Krzysztof Kozlowski , Longbin Li , Patrice Chotard , =?UTF-8?B?Q2zDqW1lbnQ=?= Le Goffic , Alessandro Grassi , Chen-Yu Tsai , Darshan R , Aaron Kling , Vishwaroop A , Haixu Cui , Darshan Rathod , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, Andy Shevchenko Cc: Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Lorenzo Bianconi , Ray Liu , Sven Peter , Neal Gompa , =?UTF-8?B?Q8OpZHJpYw==?= Le Goater , Joel Stanley , Andrew Jeffery , Ryan Wanner , Michael Hennerich , Nuno =?UTF-8?B?U8Oh?= , Kamal Dasu , Broadcom internal kernel review list , Ray Jui , Scott Branden , William Zhang , Kursad Oney , Anand Gore , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , David Rhodes , Richard Fitzgerald , Vladimir Oltean , Frank Li , Jean-Marie Verdun , Nick Hawkins , Yang Shen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Lixu Zhang , Yinbo Zhu , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Conor Dooley , Daire McNamara , Matthias Brugger , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Han Xu , Yogesh Gaur , Linus Walleij , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Chris Packham , Heiko Stuebner , Fabrizio Castro , Andi Shyti , Alim Akhtar , Paul Walmsley , Samuel Holland , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Alain Volmat , Jernej Skrabec , Li-hao Kuo , Masahisa Kojima , Jassi Brar , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Kunihiko Hayashi , Masami Hiramatsu , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Michal Simek , Max Filippov Subject: Re: [PATCH v1 4/4] spi: Drop duplicate device_set_node() call Date: Mon, 12 Jan 2026 15:10:36 +0100 Message-ID: <2776743.vuYhMxLoTh@benoit.monin> In-Reply-To: <20260108203004.3538449-5-andriy.shevchenko@linux.intel.com> References: <20260108203004.3538449-1-andriy.shevchenko@linux.intel.com> <20260108203004.3538449-5-andriy.shevchenko@linux.intel.com> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Last-TLS-Session-Version: TLSv1.3 On Thursday, 8 January 2026 at 21:23:41 CET, Andy Shevchenko wrote: > The SPI core provides the default fwnode for the controller, > assigned by device_set_node(). No need to repeat it in the driver. >=20 > Signed-off-by: Andy Shevchenko > drivers/spi/spi-dw-core.c | 2 -- >=20 Works fine on Mobileye EyeQ6Lplus SoC in both host and target mode. Tested-by: Beno=C3=AEt Monin # dw mobileye Thanks, =2D-=20 Beno=C3=AEt Monin, Bootlin Embedded Linux and Kernel engineering https://bootlin.com