From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 3/3] ARM: dts: aspeed: Add device tree for Ufispace NCPLite BMC
Date: Wed, 1 Feb 2023 11:14:04 +0100 [thread overview]
Message-ID: <307017b7-2ecf-2ce5-4031-27bb6f09feb1@linaro.org> (raw)
In-Reply-To: <CAJ3czeT1O3iw2S_SK3z0C6dMiJ+-fUrWXPox4LJpJkMy_rVsJA@mail.gmail.com>
On 01/02/2023 11:06, Jordan Chang wrote:
>>> + gpio-keys {
>>> + compatible = "gpio-keys";
>>> +
>>> + fan-status-int-l {
>>
>> Does not look like you tested the DTS against bindings. Please run `make
>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>> for instructions).
>>
>> These will bring warnings. Missing generic name,
>>
> I have run the `make dtbs_check` command, and did not notice the warning
> message 'Missing generic name'. It shows lots of compatible failed messages.
> - /ahb/ftgmac at 1e670000: failed to match any schema with compatible:
You can run it with DT_SCHEMA_FILES=gpio-keys
>
>>> + label = "fan-status-int-l";
>>> + gpios = <&gpio0 ASPEED_GPIO(M, 2) GPIO_ACTIVE_LOW>;
>>> + linux,code = <ASPEED_GPIO(M, 2)>;
>>> + };
>>> +
(...)
>>> +
>>> +&i2c4 {
>>> + status = "okay";
>>> +
>>> + psu at 58 {
>>> + compatible = "pmbus";
>>
>> Where is this compatible documented?
> Can not find the corresponding document.
>>
>> Did you run checkpatch? Did it pass without warnings?
> Yes, I did run the ./scripts/checkpatch.pl and there were two warnings left.
> - WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> - WARNING: line length of 104 exceeds 100 columns
> I just ignore those warnings that Joel has informed me in the previous
> mail loop.
>
Hm, is it then correct compatible?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-01 10:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 10:20 [PATCH 0/3] Add Ufispace NCPLite platform device tree Jordan Chang
2023-01-19 10:21 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add prefix for Ufi Space Jordan Chang
2023-01-19 10:57 ` Krzysztof Kozlowski
2023-02-01 7:25 ` Jordan Chang
2023-01-19 10:21 ` [PATCH 2/3] dt-bindings: arm: aspeed: document Ufispace NCPLite BMC Jordan Chang
2023-01-19 10:57 ` Krzysztof Kozlowski
2023-01-19 10:21 ` [PATCH 3/3] ARM: dts: aspeed: Add device tree for " Jordan Chang
2023-01-19 11:00 ` Krzysztof Kozlowski
2023-02-01 10:06 ` Jordan Chang
2023-02-01 10:14 ` Krzysztof Kozlowski [this message]
2023-02-01 10:37 ` Jordan Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=307017b7-2ecf-2ce5-4031-27bb6f09feb1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox