From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timothy Pearson Date: Wed, 1 May 2019 22:34:16 -0500 (CDT) Subject: [PATCH 2/3] aspeed/pinctrl: Fix simultaneous RS-232 / PWM and DVO outputs on AST2500 devices In-Reply-To: References: <1890791123.3393899.1556750986902.JavaMail.zimbra@raptorengineeringinc.com> Message-ID: <313461427.3426138.1556768056285.JavaMail.zimbra@raptorengineeringinc.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- > From: "Ryan Chen" > To: "Andrew Jeffery" , "Timothy Pearson" , "linux-aspeed" > > Cc: "Morris Mao" > Sent: Wednesday, May 1, 2019 10:06:25 PM > Subject: RE: [PATCH 2/3] aspeed/pinctrl: Fix simultaneous RS-232 / PWM and DVO outputs on AST2500 devices >>On Thu, 2 May 2019, at 08:20, Timothy Pearson wrote: >> There appears to be a small error in the pinmux table on pages 130 and >> 131 of the AST2500 datasheet v1.6. Specifically, the COND2 >> requirement used to mux the surrounding pins to DVI was inadvertently >> replicated to pins V1, W1, V2, and W2 in the table, which do not >> incorporate DVI functionality. >> >> As a result of this error, both serial TX lines and the PWM 0/1 >> outputs were overriding the VPO pinmux settings when VPO was enabled >> in the pinmux hogs. >> >> This patch has been verified to function on Blackbird hardware. Both >> serial TXD pins and PWM0/PWM1 were functionally tested with SCU94[1:0] >> set to 0x1. > > Hello Tim. > > The AST2500 pwm0/1 configure need following condition, the SCU94[1:0] is 0x1, it > should not work. > Could you help confirm it? > > v2 : pwm 0 : scu88[0] = 1 & scu 94[1:0] = 0 & scu90[5] = 0 > w2 : pwm 1 : scu88[1] = 1 & scu 94[1:0] = 0 & scu90[5] = 0 I can confirm that with SCU94[1:0] == 0x1 the PWM0 and PWM1 outputs work correctly -- this was tested on our Blackbird hardware. If you are reading from the datasheet, I suspect there are a few errors in it relating to the relatively rarely used DVO mux settings.