From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v5 7/7] dt-bindings: usb: add documentation for aspeed usb-vhub
Date: Fri, 28 Feb 2020 10:30:02 +1100 [thread overview]
Message-ID: <3150424b9e9f5856c747a0fbf44647919f49209d.camel@kernel.crashing.org> (raw)
In-Reply-To: <20200227230507.8682-8-rentao.bupt@gmail.com>
On Thu, 2020-02-27 at 15:05 -0800, rentao.bupt at gmail.com wrote:
.../...
You haven't fixed the problem spotted by Rob which is that the example
is now out of sync, it's missing the required properties.
Also long run I think best is going to have a child node per downstream
port, so we create a matching linux struct device. This will make it
easier to deal with the other device-controller in the ast2600 which is
basically one of these without a vhub above it.
> +required:
> + - compatible
> + - reg
> + - clocks
> + - interrupts
> + - aspeed,vhub-downstream-ports
> + - aspeed,vhub-generic-endpoints
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/aspeed-clock.h>
> + vhub: usb-vhub at 1e6a0000 {
> + compatible = "aspeed,ast2500-usb-vhub";
> + reg = <0x1e6a0000 0x300>;
> + interrupts = <5>;
> + clocks = <&syscon ASPEED_CLK_GATE_USBPORT1CLK>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb2ad_default>;
> + };
> --
next prev parent reply other threads:[~2020-02-27 23:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 23:05 [PATCH v5 0/7] aspeed-g6: enable usb support rentao.bupt
2020-02-27 23:05 ` [PATCH v5 1/7] usb: gadget: aspeed: support per-vhub usb descriptors rentao.bupt
2020-02-27 23:05 ` [PATCH v5 2/7] usb: gadget: aspeed: read vhub properties from device tree rentao.bupt
2020-02-27 23:05 ` [PATCH v5 3/7] usb: gadget: aspeed: add ast2600 vhub support rentao.bupt
2020-02-27 23:05 ` [PATCH v5 4/7] ARM: dts: aspeed-g6: add usb functions rentao.bupt
2020-02-27 23:05 ` [PATCH v5 5/7] ARM: dts: aspeed-g5: add vhub port and endpoint properties rentao.bupt
2020-02-27 23:05 ` [PATCH v5 6/7] ARM: dts: aspeed-g4: " rentao.bupt
2020-02-27 23:05 ` [PATCH v5 7/7] dt-bindings: usb: add documentation for aspeed usb-vhub rentao.bupt
2020-02-27 23:30 ` Benjamin Herrenschmidt [this message]
2020-02-28 1:05 ` Tao Ren
2020-02-28 3:02 ` Benjamin Herrenschmidt
2020-02-28 8:13 ` Tao Ren
2020-03-02 4:49 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3150424b9e9f5856c747a0fbf44647919f49209d.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox