public inbox for linux-aspeed@lists.ozlabs.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Andrew Jeffery <andrew@aj.id.au>,
	Conor Dooley <conor+dt@kernel.org>,
	 Joel Stanley <joel@jms.id.au>, Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	 Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org,  linux-kernel@vger.kernel.org,
	openbmc@lists.ozlabs.org,  linux-gpio@vger.kernel.org,
	bmc-sw@aspeedtech.com
Subject: Re: [PATCH v3 1/3] Add compatible strings for AST2700 pinctrl to the SCU binding.
Date: Wed, 11 Feb 2026 17:36:57 +1030	[thread overview]
Message-ID: <31a3283787df06b7b44796ef78cca3fd380ee18d.camel@codeconstruct.com.au> (raw)
In-Reply-To: <459f84c56a5010910ecbf8b445c092674f060691.camel@codeconstruct.com.au>

On Fri, 2026-01-23 at 17:03 +1030, Andrew Jeffery wrote:
> 
> Going down this path for pinctrl to fix the SCU situation will require
> some rework of what's already merged for the AST2700. However, we've
> not yet merged either a DTS or DTSI using the compatibles (and by
> extension, aren't using the AST2700 support from the drivers), so I
> hope that allows us to do a course-correction without too much
> collateral damage.
> 
> A possible path forward is to:
> 
>  * Move AST2700 definitions out of mfd/aspeed,ast2x00-scu.yaml into one
>    of:
>     - soc/aspeed/aspeed,ast2700-scu.yaml: Follow the example of
>       mobileye,eyeq5-olb?
>     - arm/aspeed/aspeed,ast2700-scu.yaml: We already have e.g. the secure
>       boot controller documented under arm/aspeed
>  * Retain compatible strings but require simple-mfd is not specified
>  * Rework AST2700 support introduced in:
>     - drivers/irqchip/irq-aspeed-scu-ic.c
>     - drivers/soc/aspeed/aspeed-socinfo.c
> 

... but perhaps that is too much churn for this stage.

Krzysztof: If you think the rework is worthwhile, let me know and we
can look at that design, otherwise I think Billy can proceed by
incorporating your current feedback for a v4.

Andrew


  reply	other threads:[~2026-02-11  7:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 11:43 [PATCH v3 0/3] Add pinctrl support for AST2700 SoC Billy Tsai
2026-01-20 11:43 ` [PATCH v3 1/3] Add compatible strings for AST2700 pinctrl to the SCU binding Billy Tsai
2026-01-20 12:12   ` Krzysztof Kozlowski
2026-01-23  6:33   ` Andrew Jeffery
2026-02-11  7:06     ` Andrew Jeffery [this message]
2026-01-20 11:43 ` [PATCH v3 2/3] dt-bindings: pinctrl: aspeed: Add support for AST27xx Billy Tsai
2026-01-20 12:24   ` Krzysztof Kozlowski
2026-01-20 12:27   ` Rob Herring (Arm)
2026-01-20 11:43 ` [PATCH v3 3/3] pinctrl: aspeed: add G7(AST2700) SoC0 pinctrl support Billy Tsai
2026-01-20 12:27   ` Krzysztof Kozlowski
2026-01-29  6:43     ` Billy Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31a3283787df06b7b44796ef78cca3fd380ee18d.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=andrew@aj.id.au \
    --cc=billy_tsai@aspeedtech.com \
    --cc=bmc-sw@aspeedtech.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox