From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Kevin Chen <kevin_chen@aspeedtech.com>,
lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, joel@jms.id.au, derek.kiernan@amd.com,
dragan.cvetic@amd.com, arnd@arndb.de,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] soc: aspeed: lpc-pcc: Add PCC controller support
Date: Tue, 18 Mar 2025 11:12:09 +1030 [thread overview]
Message-ID: <3270a7ea55fa28253b435da0b0bbce3adfdc00eb.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250314112113.953238-4-kevin_chen@aspeedtech.com>
On Fri, 2025-03-14 at 19:21 +0800, Kevin Chen wrote:
> + pcc->mdev.parent = dev;
> + pcc->mdev.minor = MISC_DYNAMIC_MINOR;
> + pcc->mdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s%d",
> DEVICE_NAME,
> + pcc->mdev_id);
> + pcc->mdev.fops = &pcc_fops;
> + rc = misc_register(&pcc->mdev);
> + if (rc) {
> + dev_err(dev, "Couldn't register misc device\n");
> + goto err_free_ida;
> + }
Just a note that this still isn't accounting for discussion on the
previous posting of the series putting the driver under
drivers/soc/aspeed:
https://lore.kernel.org/all/f7369d6205e05c7aac3f3de7cbd08c3b08960d75.camel@codeconstruct.com.au/
If we're not going to try make a common userspace behaviour over the
Aspeed snoop and PCC functions and the Nuvoton BPC function then I
think the behaviour of the chardev should at least be documented. But I
would rather that it were common to avoid headaches in userspace.
Andrew
prev parent reply other threads:[~2025-03-18 0:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 11:21 [PATCH v4 0/3] Add AST2600 LPC PCC support Kevin Chen
2025-03-14 11:21 ` [PATCH v4 1/3] dt-binding: aspeed: Add LPC PCC controller Kevin Chen
2025-03-17 9:12 ` Krzysztof Kozlowski
2025-03-14 11:21 ` [PATCH v4 2/3] ARM: dts: aspeed-g6: Add AST2600 LPC PCC support Kevin Chen
2025-03-17 9:13 ` Krzysztof Kozlowski
2025-03-14 11:21 ` [PATCH v4 3/3] soc: aspeed: lpc-pcc: Add PCC controller support Kevin Chen
2025-03-18 0:42 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3270a7ea55fa28253b435da0b0bbce3adfdc00eb.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=kevin_chen@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).