From: Andrew Lunn <andrew@lunn.ch>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Simon Horman" <horms@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Po-Yu Chuang" <ratbert@faraday-tech.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"taoren@meta.com" <taoren@meta.com>
Subject: Re: 回覆: [net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100
Date: Wed, 20 Aug 2025 04:43:34 +0200 [thread overview]
Message-ID: <3966765c-876e-4433-9c82-8d89c6910490@lunn.ch> (raw)
In-Reply-To: <SEYPR06MB513431EE31303E834E05704B9D33A@SEYPR06MB5134.apcprd06.prod.outlook.com>
On Wed, Aug 20, 2025 at 12:40:02AM +0000, Jacky Chou wrote:
> Hi Andrew,
>
> Thank you for your reply.
>
> > > This patch series adds support for configuring RGMII internal delays
> > > for the Aspeed AST2600 FTGMAC100 Ethernet MACs.
> >
> > So i think you are doing things in the wrong order. You first need to sort out the
> > mess of most, if not all, AST2600 have the wrong phy-mode, because the
> > RGMII delay configuration is hidden, and set wrongly.
> >
> > Please fix that first.
> >
>
> The RGMII delay is configured in U-boot stage, and it is not changed when booting to
> Linux. I want to know whether the first thing to correct here is whether the phy-mode
> in aspeed-ast2600-evb.dts is rgmii-id. Our AST2600 EVB, there is no delay on board,
> so, I need to change the phy-mode to "rgmii-id" to meet the RGMII usage first?
If there is no delay on the PCB, then phy-mode is "rgmii-id".
Andrew
next prev parent reply other threads:[~2025-08-20 2:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 6:32 [net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100 Jacky Chou
2025-08-13 6:32 ` [net-next v2 1/4] dt-bindings: net: ftgmac100: Restrict phy-mode and delay properties for AST2600 Jacky Chou
2025-08-15 18:12 ` Andrew Lunn
2025-08-13 6:32 ` [net-next v2 2/4] ARM: dts: aspeed-g6: Add ethernet alise and update MAC compatible Jacky Chou
2025-08-13 6:33 ` [net-next v2 3/4] ARM: dts: aspeed: ast2600evb: Add delay setting for MAC Jacky Chou
2025-08-15 18:17 ` Andrew Lunn
2025-08-13 6:33 ` [net-next v2 4/4] net: ftgmac100: Add RGMII delay configuration for AST2600 Jacky Chou
2025-08-15 18:23 ` Andrew Lunn
2025-08-15 0:44 ` [net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100 Jakub Kicinski
2025-08-15 18:42 ` Andrew Lunn
2025-08-20 0:40 ` 回覆: " Jacky Chou
2025-08-20 2:43 ` Andrew Lunn [this message]
2025-08-20 6:09 ` 回覆: " Jacky Chou
2025-08-26 1:41 ` Jacky Chou
2025-08-26 3:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3966765c-876e-4433-9c82-8d89c6910490@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jacky_chou@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ratbert@faraday-tech.com \
--cc=robh@kernel.org \
--cc=taoren@meta.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).