From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14E7606A31C for ; Wed, 28 Oct 2026 11:35:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=VVuRdcbr Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4jF4z86Kd0z2y8p; Wed, 28 Oct 2026 22:35:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=192.198.163.11 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793187300; cv=none; b=XUycrg3EU7xtjwZbTMxbgiGlyfFzAaWtW1uYpNcnBvJDxA4NjpISHQiP8I7yaSdZbGozP5xJNTM7i2GHjZB1oqyH7qDBSil8P00ZKshF0Ywai+Dm9bgB3sQjIsTnVCin3LD8IxGBEHS1R0LBR2w9zQa1SNlv3xPJyeRwcPZ+8zG/A9+d6cKNptSovx6mmsMAuX1Z2x/+7Bk0NNESSR4xFpD0g/hYi0P30lteaEix2ef940ir2zNGQ7Pob0kO7hdMxPUC2MMB6uwzIKNlV3LY/MRXyTimx7BLqTcmg0hRTLOOasEfWjAcw7F9OWYR5KOo5FcTozzeLRtHeNKiAhURZw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1793187300; c=relaxed/relaxed; bh=jLuXcsrhYze/uot6RAritgtezmvs46B7suAi1iRl0v0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=jSFAiKTpePqZFhtHYJXgZlcGvn96SjMp0NPpt04P/aASTR4K6UPBqMVCtwzS3wCcZno3FsvsTOBD4kql7DB6EGslZmzluPZkIvKX+ynj7srSLtWOtZlNfc6fALt0pQ7aUKXgAIYmMBrpaePyQQWrir4LWIgJIG6Q04Lg9MNC7DutoB3nH3HkYZ1nk3n/ETvmWpVUfrD5Czodftg80ko7Ogte0JBxTM8A6HNjUt5X4awUCKjoxg0plO+o9dwNwcnsZO6rWnB2TxX8KlRM895yvsmwIv7pswuF7Yg+TTF24YYo9es4Or9igDKHSLhYqyAqeXWxfhHPiRmMGPwQ+KHDAw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=VVuRdcbr; dkim-atps=neutral; spf=pass (client-ip=192.198.163.11; helo=mgamail.intel.com; envelope-from=jani.nikula@intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=VVuRdcbr; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.198.163.11; helo=mgamail.intel.com; envelope-from=jani.nikula@intel.com; receiver=lists.ozlabs.org) X-Greylist: delayed 63 seconds by postgrey-1.37 at boromir; Wed, 28 Oct 2026 22:34:57 AEDT Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4jF4z56RNdz2xlj for ; Wed, 28 Oct 2026 22:34:57 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793187298; x=1824723298; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=z8y8XV24bROqh0zonAMNAjIZyMJbY12xpb+/fK8m0AI=; b=VVuRdcbrvUXZIEk1P8RS6yhICTZKZbbW1vdVmuCwsicQoJ/tZQiPb0yC OJODpTSo4KmY21ixZ6siE5lMF6Y1GbBOZ1bkj/gTOFFEh2AIUF/55Ion/ QrI9bFWHSnlt/tRazBAKYR8hqBA0GRLMhgHQA+0VxeewRvt4ZtyZNWQZf jFdVnYoYiVH+58q7jhN5X8gDvdJ1VVbEAdePn/12FvICldNEJIlGBXIQI fu6ted+24FZ/vDpu4Z1anP8k3GevSEegZJMkH2Qiu1V19uxhRyhxebxaI dq7QOIyiYnK2PHTsmJOClHFE6DDuqKLbGxQnI1N8ul/XXyIHmfn9tyOl6 g==; X-CSE-ConnectionGUID: YGiQVC1RRrintVegiXjL0A== X-CSE-MsgGUID: rfE7/xxwRsGqJLrLSXnDKg== X-IronPort-AV: E=McAfee;i="6800,10657,11948"; a="1813643" X-IronPort-AV: E=Sophos;i="6.27,182,1787036400"; d="scan'208";a="1813643" Received: from fmviesa013.fm.intel.com ([10.60.135.153]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2026 04:33:48 -0700 X-CSE-ConnectionGUID: F9mrBK1+QXS8jOjCv8P8bQ== X-CSE-MsgGUID: KJ1QgI6jS6ey2L/RLS17LQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,182,1787036400"; d="scan'208";a="6633584" Received: from rvuia-mobl.ger.corp.intel.com (HELO localhost) ([10.245.244.146]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2026 04:33:40 -0700 From: Jani Nikula To: Dmitry Ilvokhin , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , David Airlie , Simona Vetter , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Lee Jones , Pavel Machek , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Kees Cook , Andy Shevchenko , Matthew Wilcox , Andrew Morton , Andy Whitcroft , Joe Perches , Jonathan Corbet , Shuah Khan , Randy Dunlap Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, Miguel Ojeda , Dmitry Ilvokhin Subject: Re: [PATCH 05/10] drm/i915: switch to __nonnull_args() macro In-Reply-To: <33ec8080594f9f4ef1d50e36497339c9a6897393.1793027261.git.d@ilvokhin.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <33ec8080594f9f4ef1d50e36497339c9a6897393.1793027261.git.d@ilvokhin.com> Date: Wed, 28 Oct 2026 13:33:37 +0200 Message-ID: <3b839373c03f6b8aeafa8e4801a486ece68b0815@intel.com> X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , Precedence: list X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, 28 Oct 2026, Dmitry Ilvokhin wrote: > Commit 22302af28d3f ("cleanup: Annotate guard constructors with > nonnull") added the macro __nonnull_args() to wrap raw compiler > attribute. > > Replace __attribute__((nonnull)) with __nonnull_args() to standardize > nonnull attribute usage across the tree and keep the attribute's quirks > in one place rather than open-coded at every call site. > > Suggested-by: Miguel Ojeda > Signed-off-by: Dmitry Ilvokhin Acked-by: Jani Nikula > --- > drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 ++-- > drivers/gpu/drm/i915/i915_request.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h > index a2f4b6758a65..648d0b4139cf 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h > @@ -127,7 +127,7 @@ __deprecated > struct drm_gem_object * > drm_gem_object_lookup(struct drm_file *file, u32 handle); > > -__attribute__((nonnull)) > +__nonnull_args() > static inline struct drm_i915_gem_object * > i915_gem_object_get(struct drm_i915_gem_object *obj) > { > @@ -135,7 +135,7 @@ i915_gem_object_get(struct drm_i915_gem_object *obj) > return obj; > } > > -__attribute__((nonnull)) > +__nonnull_args() > static inline void > i915_gem_object_put(struct drm_i915_gem_object *obj) > { > diff --git a/drivers/gpu/drm/i915/i915_request.h b/drivers/gpu/drm/i915/i915_request.h > index b09135301f39..f559203c332d 100644 > --- a/drivers/gpu/drm/i915/i915_request.h > +++ b/drivers/gpu/drm/i915/i915_request.h > @@ -437,12 +437,12 @@ void i915_request_cancel(struct i915_request *rq, int error); > long i915_request_wait_timeout(struct i915_request *rq, > unsigned int flags, > long timeout) > - __attribute__((nonnull(1))); > + __nonnull_args(1); > > long i915_request_wait(struct i915_request *rq, > unsigned int flags, > long timeout) > - __attribute__((nonnull(1))); > + __nonnull_args(1); > #define I915_WAIT_INTERRUPTIBLE BIT(0) > #define I915_WAIT_PRIORITY BIT(1) /* small priority bump for the request */ > #define I915_WAIT_ALL BIT(2) /* used by i915_gem_object_wait() */ -- Jani Nikula, Intel