From: Jeremy Kerr <jk@codeconstruct.com.au>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] drm/aspeed: Fix vga_pw sysfs output
Date: Fri, 19 Nov 2021 14:54:01 +0800 [thread overview]
Message-ID: <483e616cb69c780f6102ae058a26704a0443d38f.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20211117010145.297253-1-joel@jms.id.au>
Hi Joel,
> Before the drm driver had support for this file there was a driver
> that exposed the contents of the vga password register to userspace.
> It would present the entire register instead of interpreting it.
>
> The drm implementation chose to mask of the lower bit, without
> explaining why. This breaks the existing userspace, which is looking
> for 0xa8 in the lower byte.
>
> Change our implementation to expose the entire register.
As a userspace consumer of this:
Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>
Thanks!
Jeremy
next prev parent reply other threads:[~2021-11-19 6:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 1:01 [PATCH] drm/aspeed: Fix vga_pw sysfs output Joel Stanley
2021-11-17 2:28 ` Oskar Senft
2021-11-19 6:54 ` Jeremy Kerr [this message]
2021-11-19 7:07 ` Joel Stanley
2021-11-19 11:00 ` (subset) " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483e616cb69c780f6102ae058a26704a0443d38f.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).