Linux-Aspeed Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2] ARM: dts: aspeed: Add IBM P11 BMC boards
Date: Tue, 16 Apr 2024 09:32:30 +0930	[thread overview]
Message-ID: <48ad6bcccae315e68bc0aa10669eed645c495139.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240415154931.10775-1-eajames@linux.ibm.com>

On Mon, 2024-04-15 at 10:49 -0500, Eddie James wrote:
> Add the Blueridge and Fuji BMC systems.
> 
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> Changes since v1:
>  - Change "ody" to "odyssey"
> 
>  arch/arm/boot/dts/aspeed/Makefile             |    2 +
>  .../dts/aspeed/aspeed-bmc-ibm-blueridge.dts   | 1752 +++++++
>  .../boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts   | 4016 +++++++++++++++++
>  .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 1704 +++++++
>  4 files changed, 7474 insertions(+)

A few points:

- Altogether this patch is pretty large. Can we do one for each of the
FSI topology and the platforms?

- The only list to which you've sent the patch is linux-aspeed, which
doesn't appear to be archived on lore. Can you please add at least one
that is? There are a few that should probably be included regardless.

- I don't plan to merge the patch until it has had review from ideally
more than one other IBMer

On the review front:

It looks like you still need to update
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml with the new
platform compatible strings.

Also, can you please run?

```
make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-{blueridge,fuji}.dtb
```

and address the warnings? This is best done by first applying the patch
on top of my tree below. It goes some way to eliminating many of the
warnings currently produced for the Aspeed BMC SoCs:

https://github.com/amboar/linux/tree/dt-warnings/all

Andrew

  reply	other threads:[~2024-04-16  0:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 15:49 [PATCH v2] ARM: dts: aspeed: Add IBM P11 BMC boards Eddie James
2024-04-16  0:02 ` Andrew Jeffery [this message]
2024-04-25 21:41   ` Eddie James
2024-04-26  0:03     ` Andrew Jeffery
2024-04-26 13:32       ` Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48ad6bcccae315e68bc0aa10669eed645c495139.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox