From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jeffery Date: Thu, 25 Jul 2019 10:40:32 +0930 Subject: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro In-Reply-To: <2a0c5ef5c7e20b190156908991e4c964a501d80a.camel@perches.com> References: <2a0c5ef5c7e20b190156908991e4c964a501d80a.camel@perches.com> Message-ID: <4f6709f8-381f-415c-8569-798b074b66c5@www.fastmail.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, 25 Jul 2019, at 02:46, Joe Perches wrote: > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > Arguments are supposed to be ordered high then low. > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > index a10358bb61ec..095ea03e5833 100644 > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h > > @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); > > /* CTRL2 */ > > #define CRT_CTRL_DAC_EN BIT(0) > > #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & CRT_CTRL_VBLANK_LINE_MASK) > > -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31) > > +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20) Reviewed-by: Andrew Jeffery > > ping? > > >