From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A338CEF06FF for ; Mon, 9 Feb 2026 06:48:52 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4f8ZzQ5sGnz2yFm; Mon, 09 Feb 2026 17:48:50 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=203.29.241.158 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1770619730; cv=none; b=JcLjG3cgowiXg60L3srXNi27ZwTF+0fwOL+5r3KuFQdAcg+HQ+3ty8H9T9yuW7vuo5cN5R6MjU8Uh9LV2FceZouSIjC2hr+nYjQ6WtVKe4D8uqwXp/e5YmYqp1UJ2LS6qa5VTHnTI/kjtASH4al/nmAdEYI91u431jGEKoRG45tlD4/llOttuqivp2eoIj04ozReWeq19yshA8NaKBBvnetOZTf6kWic8rBMXIu1jUJUVCJAl8zqjEROeC29nbx1KoM/vzgiIpVXNuKa+RHx9D4YrPE/gbnSlgvoWUGZbhqPgJ02OYNjfybeHeTqOJbQ+TYwSmJWR6k9B6dQaqf29A== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1770619730; c=relaxed/relaxed; bh=3h399uqdq25x5hxIFW7zZwuybkzAN1xO/8T0xQ5AjvU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=mRqVbGcmb5npZXExY5ITrODvzsAoW2CsMhbsmXkCfBApG/0yZLbmSROohF+mVCQ+eOf+yVA8vakdMAbYlxBpA6SuiHIUhKMQiY+s51wRHclLnIAePWIpkeanR+DYgeHlLeagtnt/SDPDujTL8ZLZKIWE7QNDvAWh9yNgTxhIMl42Vy71JoMYp2hy5QtKmGF00M3cTsy4297dsj8SZHhgh30Oq9CoKZzE+5vQAYxxcFEHiehMQTeeG8JPUI/JEyWbFdVM1IWPoQ90p+OvG0oWP6qT4WkmaPurF5rTqnjxRcHzvRTZxOHjAGjtP2MItKO4z9bSpdVZ8PH6UyD0bEd6og== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; dkim=pass (2048-bit key; unprotected) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.a=rsa-sha256 header.s=2022a header.b=aMKEZF13; dkim-atps=neutral; spf=pass (client-ip=203.29.241.158; helo=codeconstruct.com.au; envelope-from=andrew@codeconstruct.com.au; receiver=lists.ozlabs.org) smtp.mailfrom=codeconstruct.com.au Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.a=rsa-sha256 header.s=2022a header.b=aMKEZF13; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=codeconstruct.com.au (client-ip=203.29.241.158; helo=codeconstruct.com.au; envelope-from=andrew@codeconstruct.com.au; receiver=lists.ozlabs.org) Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4f8ZzP4YvVz2xHX for ; Mon, 09 Feb 2026 17:48:49 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1770619728; bh=3h399uqdq25x5hxIFW7zZwuybkzAN1xO/8T0xQ5AjvU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=aMKEZF13ngPb4ltFbv/7dlAQBi3w4hNbKatvSU5ni0L+HP2hn04pPNZ1PJxJbfe3J hKKj/z4yG30GvmWiAqpk6YDtSYVA7lFSerKA++iT12J0tJAygkO/h8lhOmfjNXqNSw cuaQ0gks35WQRpAtTmmtEnva/ojY0qR03anUlUqYnyaoOEShsmfG28l7dpqUGQ12Ns HdBBYHBeH2elUrmDYLKdNaxCBKkOZVZiphXzp4I9EBi68D8NtHAfjV4Xpr4FyBaUAX K/AJ8/8Y0fPSMlVaXTSNj2R6H6GKs7KwI9edm4MZgugxZ+LjAto2okRuM3HWnfrwD+ uwM19bR/jynpQ== Received: from [192.168.68.117] (unknown [180.150.112.60]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 6D38A602DE; Mon, 9 Feb 2026 14:48:46 +0800 (AWST) Message-ID: <505227cc664cf309eede2640442bad45af1dcf37.camel@codeconstruct.com.au> Subject: Re: [PATCH] ARM: dts: aspeed: anacapa: add new sgpio line names From: Andrew Jeffery To: Colin Huang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Colin.Huang2@amd.com, Carl.Lee@amd.com, Peter.Shen@amd.com Date: Mon, 09 Feb 2026 17:18:45 +1030 In-Reply-To: <20260202-anacapa-dts-sgpio-v1-1-a3a7b0b087f0@gmail.com> References: <20260202-anacapa-dts-sgpio-v1-1-a3a7b0b087f0@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 X-Mailing-List: linux-aspeed@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Hi Colin, On Mon, 2026-02-02 at 14:31 +0800, Colin Huang wrote: > Updated items: What's below repeats what the diff tells us, and as such isn't useful information. The useful information is missing: The motivation for these changes. Why are you adding these now? Why were they not added previously? Are they all in support of the same high-level feature? Or are multiple features driving the addition of each of these line names? If there are multiple motivations, why should these all be added in one patch and not several? Generally, please try to take onboard the suggestions here: https://docs.kernel.org/process/submitting-patches.html#describe-your-chang= es > - Add BMC_AINIC0_WP_R2_L and BMC_AINIC1_WP_R2_L > - Place LEAK_DETECT_RMC_N in the correct slot ... for instance, why did it end up being described for the incorrect slot? Was it just a mistake in the documentation? A mistake by the original DTS author? Or a new (and incompatible) revision of the hardware design? Answering these kinds of questions tends to motivate making such changes their own patch. > - Add PRSNT_NFC_BOARD_R > - Add IRQ_NFC_BOARD_R and RSMRST_N > - Add DC_OFF, EAM_MOD_PWR_GD_TIMEOUT, CPLD_AMC_STBY_PWR_EN > - Add FM_MAIN_PWREN_RMC_EN_ISO >=20 > Signed-off-by: Colin Huang > --- > The following changes are included: > - Add BMC_AINIC0_WP_R2_L and BMC_AINIC1_WP_R2_L > - Correct placement of LEAK_DETECT_RMC_N > - Add PRSNT_NFC_BOARD_R > - Add IRQ_NFC_BOARD_R and RSMRST_N > - Add DC_OFF, EAM_MOD_PWR_GD_TIMEOUT, CPLD_AMC_STBY_PWR_EN > - Add FM_MAIN_PWREN_RMC_EN_ISO This repeats what's in the commit message and also isn't useful, though at least it's not ultimately included in the commit itself. > --- > =C2=A0.../boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts=C2=A0=C2=A0 | 1= 9 +++++++++++-------- > =C2=A01 file changed, 11 insertions(+), 8 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts b/a= rch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts > index 221af858cb6b..37bccf64c77b 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa.dts > @@ -852,15 +852,15 @@ &sgpiom0 { > =C2=A0 "Channel1_leakage_EAM0", "FM_SCM_JTAG_MUX_SEL", > =C2=A0 "Channel2_leakage_Manifold1", "FM_BRIDGE_JTAG_MUX_SEL", > =C2=A0 "Channel3_leakage", "FM_CPU0_NMI_SYNC_FLOOD_N", > - "Channel4_leakage_Manifold2", "", > - "Channel5_leakage_EAM1", "", > + "Channel4_leakage_Manifold2", "BMC_AINIC0_WP_R2_L", > + "Channel5_leakage_EAM1", "BMC_AINIC1_WP_R2_L", > =C2=A0 "Channel6_leakage_CPU_DIMM", "", > =C2=A0 "Channel7_leakage_EAM2", "", > =C2=A0 > =C2=A0 /* C0-C7 line 32-47 */ > - "RSVD_RMC_GPIO3", "", "", "", > + "RSVD_RMC_GPIO3", "", "LEAK_DETECT_RMC_N", "", > + "", "", "", "", > =C2=A0 "", "", "", "", > - "LEAK_DETECT_RMC_N", "", "", "", > =C2=A0 "", "", "", "", > =C2=A0 > =C2=A0 /* D0-D7 line 48-63 */ > @@ -893,7 +893,7 @@ &sgpiom0 { > =C2=A0 "PWRGD_CHIL_CPU0_FPGA", "", > =C2=A0 "PWRGD_CHEH_CPU0_FPGA", "", > =C2=A0 "PWRGD_CHAD_CPU0_FPGA", "FM_BMC_READY_PLD", > - "", "", > + "PRSNT_NFC_BOARD_R", "", > =C2=A0 > =C2=A0 /* H0-H7 line 112-127 */ > =C2=A0 "PWRGD_P3V3", "", > @@ -922,7 +922,8 @@ &sgpiom0 { > =C2=A0 "BRIDGE_R_MAIN_PG_R", "", > =C2=A0 "BRIDGE_L_STBY_PG_R", "", > =C2=A0 "BRIDGE_R_STBY_PG_R", "", > - "", "", "", "", > + "IRQ_NFC_BOARD_R", "", > + "RSMRST_N", "", > =C2=A0 > =C2=A0 /* K0-K7 line 160-175 */ > =C2=A0 "ADC_I2C_ALERT_N", "", > @@ -956,7 +957,9 @@ &sgpiom0 { > =C2=A0 "AMC_STBY_PGOOD_R", "", > =C2=A0 "CPU_AMC_SLP_S5_R_L", "", > =C2=A0 "AMC_CPU_EAMPG_R", "", > - "", "", "", "", > + "DC_OFF", "", > + "EAM_MOD_PWR_GD_TIMEOUT", "", > + "CPLD_AMC_STBY_PWR_EN", "", > =C2=A0 > =C2=A0 /* O0-O7 line 224-239 */ > =C2=A0 "HPM_PWR_FAIL", "Port80_b0", > @@ -966,7 +969,7 @@ &sgpiom0 { > =C2=A0 "FM_CPU0_THERMTRIP_N", "Port80_b4", > =C2=A0 "PVDDCR_SOC_P0_OCP_L", "Port80_b5", > =C2=A0 "CPLD_SGPIO_RDY", "Port80_b6", > - "", "Port80_b7", > + "FM_MAIN_PWREN_RMC_EN_ISO", "Port80_b7", > =C2=A0 > =C2=A0 /* P0-P7 line 240-255 */ > =C2=A0 "CPU0_SLP_S5_N_R", "NFC_VEN", >=20 > --- > base-commit: 26705fad17bd111f062f4208df2dd60e7a9c2ecd > change-id: 20260202-anacapa-dts-sgpio-e4e0ba5c2cd5 >=20 > Best regards,