From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: "Rob Herring (Arm)" <robh@kernel.org>, Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Chia-Wei Wang <chiawei_wang@aspeedtech.com>
Cc: Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node
Date: Fri, 08 Aug 2025 11:16:30 +0930 [thread overview]
Message-ID: <54e07d5e67b2d15810d79bc196e92c8bacabf789.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250807132909.3291770-1-robh@kernel.org>
On Thu, 2025-08-07 at 08:29 -0500, Rob Herring (Arm) wrote:
> The ASpeed lpc-snoop nodes have a "clocks" property which isn't
> documented. It looks like all the LPC child devices have the same clock
> source. Perhaps it is the parent device that should have the clock, but
> it's too late for that. The driver for lpc-snoop requires a clock to be
> present.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Thanks Rob.
Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>
prev parent reply other threads:[~2025-08-08 1:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 13:29 [PATCH] dt-bindings: mfd: aspeed-lpc: Add missing "clocks" property on lpc-snoop node Rob Herring (Arm)
2025-08-08 1:46 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54e07d5e67b2d15810d79bc196e92c8bacabf789.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=andrew@aj.id.au \
--cc=chiawei_wang@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).